From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71233A0560; Tue, 18 Oct 2022 21:45:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32CD040A8B; Tue, 18 Oct 2022 21:45:44 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 2EDFB427EE for ; Tue, 18 Oct 2022 21:45:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chYuSvBvUZHL9zPZLruGB1fJMkFp7s3rvJ5vMRHAWPtq1kNgzxWR1+q0+IoMu/KH/njKywTdD041GzknFKIzxKanQ4dBkyZ3I14GruolY8XShlmWAalkRGk3PAFcpPBfnaXGq/tCunQeVqt5yuwm31fD284oFpv2pJqxOdnP7LWnYztEkn39Ye/Vb11u2ScBluL2V0HDggUin89oy+JgTWs/YcAiAiWVag08qxk46l+7LwEdhqth0gGQtZ5wkN7nMQwvIDG4rV/tVJXWw3tcM2eVcIqO+F5PgfKcTw7RgyWd6WHn+BEC8VqctzUEvxYCZXsb2ZTqqB9grFa9IcnRJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=++7Aq6SVfmeh7NggLwUH9NQkRhnJPAMAlJKGu8DW8UE=; b=k1Jv4NqfTVymXvLntavf5U4SDlsEfWir5Wc1HbpqficPwK+4RY1wJT0nOIJ5mAeWsEY66JOHydiRm/pCdzl3G5IlYjx/pW2ihLrDX6u9HlcLOn9P6o2I58MxR2zKYVdW5PpJ09vGrkd0dwzbf4Hk1EaIdWt/nweJyyfXHZuLwKj5hqvkqmMBzDvP5Fpk5CLpy8z669ZmoW8DlS9U80cBQLO/CmK0odGuS027IytnjJFHsZafk0zxgyz8Pxl+aOKTkp7/zPApuax/dyW6zuYfkHPbs4WFY9dCbii3TYizS5U2W/hZEl+GRmPQBCBv82S2+kNvmnUQP1UhJC0LOqrbdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++7Aq6SVfmeh7NggLwUH9NQkRhnJPAMAlJKGu8DW8UE=; b=xHRelLvTO8PjH+kz6YSMGwWey1Mb6zbn1WC2Yuvr69oSzCWMm77U85ajvohJ9l+3XRrJ9Zalm+dv/S11LbJsJEktP3vdMFTwX1uT3JTyD15p8BsV+6g4uim3omnIkVBsT92rE9yLG+VaUaEd1XvYQBuYXApRaoOYEPOBevIPkwg= Received: from DS7PR03CA0225.namprd03.prod.outlook.com (2603:10b6:5:3ba::20) by PH7PR12MB6936.namprd12.prod.outlook.com (2603:10b6:510:1ba::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct 2022 19:45:40 +0000 Received: from DM6NAM11FT083.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ba:cafe::18) by DS7PR03CA0225.outlook.office365.com (2603:10b6:5:3ba::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33 via Frontend Transport; Tue, 18 Oct 2022 19:45:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT083.mail.protection.outlook.com (10.13.173.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5746.16 via Frontend Transport; Tue, 18 Oct 2022 19:45:39 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 14:45:39 -0500 From: Andrew Boyer To: CC: Andrew Boyer Subject: [PATCH v2 19/36] net/ionic: do one-time init of receive descriptors Date: Tue, 18 Oct 2022 12:41:14 -0700 Message-ID: <20221018194131.23006-20-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221011005032.47584-1-andrew.boyer@amd.com> References: <20221011005032.47584-1-andrew.boyer@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT083:EE_|PH7PR12MB6936:EE_ X-MS-Office365-Filtering-Correlation-Id: ac94913c-d826-475f-fc89-08dab1415603 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fKVUmtIjyjUcCjzzLegGN+WQUVXzTjBZEeLsnU6bgC0Vz9MgcsM5F5YIyGkMFDV+wf61F0D2yNXHEO9kpTIupSD0BXziOJ6CZlUecOhS0Sd0Eq+/aRwGjhJoVsqPYMglZGSjsgqlTVoNyGMJHXG+mCMhLIFYv3LhfHnFJhVxJhSug9ogjhDJ4jN0XWuMOqCZmFJkk6gEaufwF6aoWeMJ1fO1HueRKKMpwk13egtqHQrw3q71K1BJHke0jvJIFb1/K0RwG/aTB+eOBdA6XQ0G2Ho0x7HDCImDYW0rFff1bbi01dOGcgwy4wBMkLl4iyDc63yFvQMr/DYwhwU1gJtr0ukHBPElT1IxQxMaMSJGu0U0bukTa7rMdXP22HC/WAE2I6/ynaykqres4qTLf9u8GepITPqzIUlkD0kkQJ87SjMXDAvbblYcZgAMRteONEh8C24wOwy17qAPIt9Ftxg50cIkSmg+NOgYwewlj8YlHwcl6cDXMWDaoZk3zfi0lL+UCAIZlVPsEtN9rTJGdX4KSjVUGiRI/HxizVkvJVlxMY58aeTE/ZkR8Yen+lG5nNCGzkg4VsS2hTdYfpFiu4noni4yF4nK+M8eZh95F37AHbyus3u6Cw2RfPMKwPfBPSvMxdpFaIW5PAnaMsfOPPYUImdWRAEclm1w8j+QwKV6BzEYj+aG1qNP2s1HwXTFZ1sHVROec4mdXJ4JsK4xNazDuVpcgUoY0ggqVNmgftj309TH6bg0BGnbGBTc+T+ewiNt4dXtPb1bfBUZdD5tllfu8lvekkmzPGQJAIYPo5Ay9Ww= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(86362001)(81166007)(356005)(82740400003)(2906002)(83380400001)(6666004)(40460700003)(5660300002)(40480700001)(44832011)(26005)(16526019)(336012)(1076003)(186003)(2616005)(47076005)(426003)(36860700001)(478600001)(82310400005)(6916009)(41300700001)(316002)(70586007)(70206006)(8676002)(4326008)(8936002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 19:45:39.9657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac94913c-d826-475f-fc89-08dab1415603 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT083.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6936 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These fields don't need to be set in the hot path. This improves performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 38 ++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 93a29a0326..9812604c3f 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -941,9 +941,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq) desc = &desc_base[q->head_idx]; dma_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(rxm)); desc->addr = dma_addr; - desc->len = rxq->hdr_seg_size; - desc->opcode = (q->num_segs > 1) ? IONIC_RXQ_DESC_OPCODE_SG : - IONIC_RXQ_DESC_OPCODE_SIMPLE; rxm->next = NULL; prev_rxm_seg = rxm; @@ -963,7 +960,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq) data_iova = rte_mbuf_data_iova(rxm_seg); dma_addr = rte_cpu_to_le_64(data_iova); elem->addr = dma_addr; - elem->len = rxq->seg_size; elem++; rxm_seg->next = NULL; @@ -981,6 +977,38 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq) return 0; } +/* + * Perform one-time initialization of descriptor fields + * which will not change for the life of the queue. + */ +static void __rte_cold +ionic_rx_init_descriptors(struct ionic_rx_qcq *rxq) +{ + struct ionic_queue *q = &rxq->qcq.q; + struct ionic_rxq_desc *desc, *desc_base = q->base; + struct ionic_rxq_sg_desc *sg_desc, *sg_desc_base = q->sg_base; + uint32_t i, j; + uint8_t opcode; + + opcode = (q->num_segs > 1) ? + IONIC_RXQ_DESC_OPCODE_SG : IONIC_RXQ_DESC_OPCODE_SIMPLE; + + /* + * NB: Only the first segment needs to leave headroom (hdr_seg_size). + * Later segments (seg_size) do not. + */ + for (i = 0; i < q->num_descs; i++) { + desc = &desc_base[i]; + desc->len = rte_cpu_to_le_16(rxq->hdr_seg_size); + desc->opcode = opcode; + + sg_desc = &sg_desc_base[i]; + for (j = 0; j < q->num_segs - 1u; j++) + sg_desc->elems[j].len = + rte_cpu_to_le_16(rxq->seg_size); + } +} + /* * Start Receive Units for specified queue. */ @@ -1010,6 +1038,8 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id) IONIC_PRINT(DEBUG, "Starting RX queue %u, %u descs, size %u segs %u", rx_queue_id, q->num_descs, rxq->frame_size, q->num_segs); + ionic_rx_init_descriptors(rxq); + err = ionic_lif_rxq_init(rxq); if (err) return err; -- 2.17.1