From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4F16A0560; Tue, 18 Oct 2022 18:43:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C309142B7E; Tue, 18 Oct 2022 18:43:00 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C461C4114E; Tue, 18 Oct 2022 18:42:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666111373; x=1697647373; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ujuWBLN0H5zGviO91IjuIlvt/+F8FmYVJjE8wCPqksA=; b=SZJ6jhLJDzilQCm2U7bsKdz3OzMDNb8rn/fgLzNeT0U0CzZa1qZVrD6H yllSHXisr0OaaT246tLk7hRJ3LOr5rQxcZkxP+34y0PZc9mDk25lIZoqY HWrbmNRPA8ddw8oGHOKpqcNv4aUfCCOr/nvY9PdiA5U9UX/hRn2TK1Axq npBE6UaJyakZF/ExvRPEOvRSvFATtWl2yX3EKvhQ8hv/FCX47s9qnMZJz mn6PevYb2k6rOVd+8kyyo4TdwRTq6uKVohCF4wdcGCIdfMi/xBd9t2+0N 7Cm19+bAhpwZCuFKC8i3xu1FEJC07E03o/6WWNzwejQO5TKc2MSd4lYn5 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="368192064" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="368192064" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 09:42:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="803836054" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="803836054" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2022 09:42:51 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v4 10/30] baseband/acc100: fix clearing PF IR outside handler Date: Tue, 18 Oct 2022 17:38:58 -0700 Message-Id: <20221019003918.257506-11-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20221019003918.257506-1-hernan.vargas@intel.com> References: <20221019003918.257506-1-hernan.vargas@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Clearing of PF info ring outside of handler may cause interrupt to be missed. A condition in the ACC100 PMD implementation may cause an interrupt functional handler call to be missed due to related bit being cleared when checking PF info ring status. Fixes: 06531464151 ("baseband/acc100: support interrupt") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index b79a251e9f..f892b402ca 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -262,11 +262,12 @@ acc100_check_ir(struct acc_device *acc100_dev) while (ring_data->valid) { if ((ring_data->int_nb < ACC100_PF_INT_DMA_DL_DESC_IRQ) || ( ring_data->int_nb > - ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) + ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) { rte_bbdev_log(WARNING, "InfoRing: ITR:%d Info:0x%x", ring_data->int_nb, ring_data->detailed_info); - /* Initialize Info Ring entry and move forward */ - ring_data->val = 0; + /* Initialize Info Ring entry and move forward */ + ring_data->val = 0; + } info_ring_head++; ring_data = acc100_dev->info_ring + (info_ring_head & ACC_INFO_RING_MASK); -- 2.37.1