From: Abdullah Sevincer <abdullah.sevincer@intel.com>
To: dev@dpdk.org
Cc: jerinj@marvell.com, shivani.doneria@intel.com,
tirthendu.sarkar@intel.com,
Abdullah Sevincer <abdullah.sevincer@intel.com>,
stable@dpdk.org
Subject: [PATCH v2] event/dlb2: fix port COS range allocation
Date: Wed, 19 Oct 2022 19:07:33 -0500 [thread overview]
Message-ID: <20221020000733.4026522-1-abdullah.sevincer@intel.com> (raw)
In-Reply-To: <20221019194734.4009186-1-abdullah.sevincer@intel.com>
This commit fixes allocation of port COS
when application requested port COS exceeds
(e.g. beyond 0-15) the number of LDB ports for
the domain.
We limit application specified ports from a
COS to the max ports allocated for the COS
so that the rest of the of the ports can be
allocated from default(best) COS.
Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS")
Cc: stable@dpdk.org
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
---
drivers/event/dlb2/dlb2.c | 14 +++++++++-----
drivers/event/dlb2/dlb2_priv.h | 2 ++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 7fd89e940b..62e2bbeb3d 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -180,11 +180,14 @@ dlb2_init_port_cos(struct dlb2_eventdev *dlb2, int *port_cos)
{
int q;
- for (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++)
- if (port_cos[q] != DLB2_COS_DEFAULT) {
- dlb2->ev_ports[q].cos_id = port_cos[q];
+ for (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++) {
+ dlb2->ev_ports[q].cos_id = port_cos[q];
+ if (port_cos[q] != DLB2_COS_DEFAULT &&
+ dlb2->cos_ports[port_cos[q]] < DLB2_MAX_NUM_LDB_PORTS_PER_COS) {
dlb2->cos_ports[port_cos[q]]++;
+ dlb2->max_cos_port = q;
}
+ }
}
static void
@@ -840,8 +843,9 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2,
cos_ports = dlb2->cos_ports[0] + dlb2->cos_ports[1] +
dlb2->cos_ports[2] + dlb2->cos_ports[3];
- if (cos_ports > resources_asked->num_ldb_ports) {
- DLB2_LOG_ERR("dlb2: num_ldb_ports < nonzero cos_ports\n");
+ if (cos_ports > resources_asked->num_ldb_ports ||
+ (cos_ports && dlb2->max_cos_port >= resources_asked->num_ldb_ports)) {
+ DLB2_LOG_ERR("dlb2: num_ldb_ports < cos_ports\n");
ret = EINVAL;
goto error_exit;
}
diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h
index 9ef5bcb901..03ef15ac51 100644
--- a/drivers/event/dlb2/dlb2_priv.h
+++ b/drivers/event/dlb2/dlb2_priv.h
@@ -93,6 +93,7 @@
#define DLB2_NUM_SN_GROUPS 2
#define DLB2_MAX_LDB_SN_ALLOC 1024
#define DLB2_MAX_QUEUE_DEPTH_THRESHOLD 8191
+#define DLB2_MAX_NUM_LDB_PORTS_PER_COS (DLB2_MAX_NUM_LDB_PORTS/DLB2_COS_NUM_VALS)
/* 2048 total hist list entries and 64 total ldb ports, which
* makes for 2048/64 == 32 hist list entries per port. However, CQ
@@ -636,6 +637,7 @@ struct dlb2_eventdev {
};
uint32_t cos_ports[DLB2_COS_NUM_VALS]; /* total ldb ports in each class */
uint32_t cos_bw[DLB2_COS_NUM_VALS]; /* bandwidth per cos domain */
+ uint8_t max_cos_port; /* Max LDB port from any cos */
};
/* used for collecting and passing around the dev args */
--
2.25.1
next prev parent reply other threads:[~2022-10-20 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 19:47 [PATCH v1] " Abdullah Sevincer
2022-10-20 0:07 ` Abdullah Sevincer [this message]
2022-10-20 8:24 ` [PATCH v2] " Jerin Jacob
2022-10-20 17:50 ` [PATCH v4] " Abdullah Sevincer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020000733.4026522-1-abdullah.sevincer@intel.com \
--to=abdullah.sevincer@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=shivani.doneria@intel.com \
--cc=stable@dpdk.org \
--cc=tirthendu.sarkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).