From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44274A09FB; Thu, 20 Oct 2022 02:08:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF19A40DD8; Thu, 20 Oct 2022 02:08:24 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id BD9BA40A7D; Thu, 20 Oct 2022 02:08:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666224503; x=1697760503; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qRoDBunvx4iYbs6dZPL5tKODFTvni72S8t7Rad9+sMk=; b=FH2Btus+bF7e9ESovisV1rheXNuQjppXC5gTMT/WrcOxWyJshkGSFuqs ISJYQt7whCikJT9hcEKtcPPTL/g8BEDUf41O/C73+8prhL4k0U23mOZT/ xQo7fO3thnZEmji+nwPee1Ikv6fAqFmEIs4eTMOrDirhfFWhZmxDxkMbX 6SmsgwI1sOZRgLwkBJh+fbs/DI9AWwW+914Lv7+KEZSp+t6uTtu+wma8p KQWYMEN3I1hNPzvoMadZO6X1Q2214esmDBdMrnX5iybEB2Tcmf0Ks3KBl 3oLjHOfPLG3oHmzzRs5h9rAi9grYev+vkyBPnQra0FW/2u2bWkdPJjAdk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="333125655" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="333125655" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 17:07:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="629500632" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="629500632" Received: from txanpdk02.an.intel.com ([10.123.117.76]) by orsmga002.jf.intel.com with ESMTP; 19 Oct 2022 17:07:35 -0700 From: Abdullah Sevincer To: dev@dpdk.org Cc: jerinj@marvell.com, shivani.doneria@intel.com, tirthendu.sarkar@intel.com, Abdullah Sevincer , stable@dpdk.org Subject: [PATCH v2] event/dlb2: fix port COS range allocation Date: Wed, 19 Oct 2022 19:07:33 -0500 Message-Id: <20221020000733.4026522-1-abdullah.sevincer@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221019194734.4009186-1-abdullah.sevincer@intel.com> References: <20221019194734.4009186-1-abdullah.sevincer@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit fixes allocation of port COS when application requested port COS exceeds (e.g. beyond 0-15) the number of LDB ports for the domain. We limit application specified ports from a COS to the max ports allocated for the COS so that the rest of the of the ports can be allocated from default(best) COS. Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS") Cc: stable@dpdk.org Signed-off-by: Abdullah Sevincer --- drivers/event/dlb2/dlb2.c | 14 +++++++++----- drivers/event/dlb2/dlb2_priv.h | 2 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 7fd89e940b..62e2bbeb3d 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -180,11 +180,14 @@ dlb2_init_port_cos(struct dlb2_eventdev *dlb2, int *port_cos) { int q; - for (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++) - if (port_cos[q] != DLB2_COS_DEFAULT) { - dlb2->ev_ports[q].cos_id = port_cos[q]; + for (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++) { + dlb2->ev_ports[q].cos_id = port_cos[q]; + if (port_cos[q] != DLB2_COS_DEFAULT && + dlb2->cos_ports[port_cos[q]] < DLB2_MAX_NUM_LDB_PORTS_PER_COS) { dlb2->cos_ports[port_cos[q]]++; + dlb2->max_cos_port = q; } + } } static void @@ -840,8 +843,9 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2, cos_ports = dlb2->cos_ports[0] + dlb2->cos_ports[1] + dlb2->cos_ports[2] + dlb2->cos_ports[3]; - if (cos_ports > resources_asked->num_ldb_ports) { - DLB2_LOG_ERR("dlb2: num_ldb_ports < nonzero cos_ports\n"); + if (cos_ports > resources_asked->num_ldb_ports || + (cos_ports && dlb2->max_cos_port >= resources_asked->num_ldb_ports)) { + DLB2_LOG_ERR("dlb2: num_ldb_ports < cos_ports\n"); ret = EINVAL; goto error_exit; } diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h index 9ef5bcb901..03ef15ac51 100644 --- a/drivers/event/dlb2/dlb2_priv.h +++ b/drivers/event/dlb2/dlb2_priv.h @@ -93,6 +93,7 @@ #define DLB2_NUM_SN_GROUPS 2 #define DLB2_MAX_LDB_SN_ALLOC 1024 #define DLB2_MAX_QUEUE_DEPTH_THRESHOLD 8191 +#define DLB2_MAX_NUM_LDB_PORTS_PER_COS (DLB2_MAX_NUM_LDB_PORTS/DLB2_COS_NUM_VALS) /* 2048 total hist list entries and 64 total ldb ports, which * makes for 2048/64 == 32 hist list entries per port. However, CQ @@ -636,6 +637,7 @@ struct dlb2_eventdev { }; uint32_t cos_ports[DLB2_COS_NUM_VALS]; /* total ldb ports in each class */ uint32_t cos_bw[DLB2_COS_NUM_VALS]; /* bandwidth per cos domain */ + uint8_t max_cos_port; /* Max LDB port from any cos */ }; /* used for collecting and passing around the dev args */ -- 2.25.1