* RE: [PATCH v2] net/ice: support vxlan gpe tunnel offload
2022-10-21 12:59 [PATCH v2] net/ice: support vxlan gpe tunnel offload Mingjin Ye
@ 2022-10-21 9:14 ` Xu, Ke1
2022-10-24 3:37 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Xu, Ke1 @ 2022-10-21 9:14 UTC (permalink / raw)
To: Ye, MingjinX, dev
Cc: stable, Zhou, YidingX, Ye, MingjinX, Yang, Qiming, Zhang, Qi Z,
Somnath Kotur, Matz, Olivier, Ajit Khaparde, Andrew Rybchenko
> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Sent: Friday, October 21, 2022 9:00 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>;
> Matz, Olivier <olivier.matz@6wind.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Subject: [PATCH v2] net/ice: support vxlan gpe tunnel offload
>
> PMD tx path does not support VXLAN_GPE tunnel offload. Because it does
> not process RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE flag in mbuf, and then
> the "L4TUNT"
> field will not be set in Tx context descriptor.
>
> This patch is to add the RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE flag to
> support Tx VXLAN_GPE offload under the scenario if the offload tso and
> VXLAN_GPE tunnel are both required, so that it would avoid tx queue
> overflowing.
>
> Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Verified and passed.
Tested-by: Ke Xu <ke1.xu@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] net/ice: support vxlan gpe tunnel offload
@ 2022-10-21 12:59 Mingjin Ye
2022-10-21 9:14 ` Xu, Ke1
0 siblings, 1 reply; 3+ messages in thread
From: Mingjin Ye @ 2022-10-21 12:59 UTC (permalink / raw)
To: dev
Cc: stable, yidingx.zhou, Mingjin Ye, Qiming Yang, Qi Zhang,
Somnath Kotur, Olivier Matz, Ajit Khaparde, Andrew Rybchenko
PMD tx path does not support VXLAN_GPE tunnel offload. Because it does not
process RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE flag in mbuf, and then the "L4TUNT"
field will not be set in Tx context descriptor.
This patch is to add the RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE flag to
support Tx VXLAN_GPE offload under the scenario if the offload tso
and VXLAN_GPE tunnel are both required, so that it would avoid
tx queue overflowing.
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
drivers/net/ice/ice_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 697251c603..0a2b0376ac 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2690,6 +2690,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
/* for non UDP / GRE tunneling, set to 00b */
break;
case RTE_MBUF_F_TX_TUNNEL_VXLAN:
+ case RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE:
case RTE_MBUF_F_TX_TUNNEL_GTP:
case RTE_MBUF_F_TX_TUNNEL_GENEVE:
*cd_tunneling |= ICE_TXD_CTX_UDP_TUNNELING;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] net/ice: support vxlan gpe tunnel offload
2022-10-21 9:14 ` Xu, Ke1
@ 2022-10-24 3:37 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2022-10-24 3:37 UTC (permalink / raw)
To: Xu, Ke1, Ye, MingjinX, dev
Cc: stable, Zhou, YidingX, Ye, MingjinX, Yang, Qiming, Somnath Kotur,
Matz, Olivier, Ajit Khaparde, Andrew Rybchenko
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Friday, October 21, 2022 5:14 PM
> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>;
> Matz, Olivier <olivier.matz@6wind.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Subject: RE: [PATCH v2] net/ice: support vxlan gpe tunnel offload
>
>
>
> > -----Original Message-----
> > From: Mingjin Ye <mingjinx.ye@intel.com>
> > Sent: Friday, October 21, 2022 9:00 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye,
> > MingjinX <mingjinx.ye@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Somnath
> > Kotur <somnath.kotur@broadcom.com>; Matz, Olivier
> > <olivier.matz@6wind.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>;
> > Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Subject: [PATCH v2] net/ice: support vxlan gpe tunnel offload
> >
> > PMD tx path does not support VXLAN_GPE tunnel offload. Because it does
> > not process RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE flag in mbuf, and then
> the
> > "L4TUNT"
> > field will not be set in Tx context descriptor.
> >
> > This patch is to add the RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE flag to
> > support Tx VXLAN_GPE offload under the scenario if the offload tso and
> > VXLAN_GPE tunnel are both required, so that it would avoid tx queue
> > overflowing.
> >
> > Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
>
> Verified and passed.
> Tested-by: Ke Xu <ke1.xu@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-24 3:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-21 12:59 [PATCH v2] net/ice: support vxlan gpe tunnel offload Mingjin Ye
2022-10-21 9:14 ` Xu, Ke1
2022-10-24 3:37 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).