From: Suanming Mou <suanmingm@nvidia.com>
To: Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: <dev@dpdk.org>, <rasland@nvidia.com>
Subject: [PATCH] net/mlx5: remove unneeded SQ null checking
Date: Wed, 26 Oct 2022 09:33:26 +0300 [thread overview]
Message-ID: <20221026063326.2850-1-suanmingm@nvidia.com> (raw)
The ASO SQ is a dynamic array in the ASO pool struct. That means
the checking of the SQ pointer is incorrect and not needed. And
the mlx5_aso_destroy_sq() function internally also checks if inside
the SQ any resources need to be released or not. There is no need
to have that extra checking.
This commit removes the redundant checking code.
Fixes: aa90929cd5db ("net/mlx5: add HW steering connection tracking support")
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_aso.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c
index 1ddf71e44e..29bd7ce9e8 100644
--- a/drivers/net/mlx5/mlx5_flow_aso.c
+++ b/drivers/net/mlx5/mlx5_flow_aso.c
@@ -328,8 +328,7 @@ mlx5_aso_mtr_queue_init(struct mlx5_dev_ctx_shared *sh,
return 0;
error:
do {
- if (&hws_pool->sq[i])
- mlx5_aso_destroy_sq(hws_pool->sq + i);
+ mlx5_aso_destroy_sq(hws_pool->sq + i);
} while (i--);
return -1;
}
@@ -1149,8 +1148,7 @@ mlx5_aso_ct_queue_init(struct mlx5_dev_ctx_shared *sh,
do {
if (ct_mng->aso_sqs[i].mr.addr)
mlx5_aso_dereg_mr(sh->cdev, &ct_mng->aso_sqs[i].mr);
- if (&ct_mng->aso_sqs[i])
- mlx5_aso_destroy_sq(&ct_mng->aso_sqs[i]);
+ mlx5_aso_destroy_sq(&ct_mng->aso_sqs[i]);
} while (i--);
ct_mng->nb_sq = 0;
return -1;
--
2.25.1
next reply other threads:[~2022-10-26 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 6:33 Suanming Mou [this message]
2022-10-26 9:58 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026063326.2850-1-suanmingm@nvidia.com \
--to=suanmingm@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).