From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <dmiller423@gmail.com>
Cc: dev@dpdk.org, Mathew S Thoennes <tardis@us.ibm.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Beilei Xing <beilei.xing@intel.com>,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Harman Kalra <hkalra@marvell.com>
Subject: Re: [PATCH] Add support for IBM Z s390x
Date: Fri, 28 Oct 2022 15:51:17 -0700 [thread overview]
Message-ID: <20221028155117.2880b051@hermes.local> (raw)
In-Reply-To: <20221028215240.103365-1-dmiller423@gmail.com>
On Fri, 28 Oct 2022 17:52:40 -0400
David Miller <dmiller423@gmail.com> wrote:
> +#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> + switch (type) {
> + case RTE_UINT8:
> + {
> + uint8_t *temp = (uint8_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_UINT16:
> + {
> + uint16_t *temp = (uint16_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_UINT32:
> + {
> + uint32_t *temp = (uint32_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_INT8:
> + {
> + int8_t *temp = (int8_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_INT16:
> + {
> + int16_t *temp = (int16_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_INT32:
> + {
> + int32_t *temp = (int32_t *)&result;
> + result = *temp;
> + break;
> + }
> + default:
> + break;
> + }
> +#endif
You are indenting with 4 spaces.
The DPDK uses tab indentation like the Linux kernel.
Surprised that checkpatch isn't catching this.
next prev parent reply other threads:[~2022-10-28 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 21:52 David Miller
2022-10-28 22:45 ` Stephen Hemminger
2022-10-28 22:54 ` David Miller
2022-10-28 22:51 ` Stephen Hemminger [this message]
2023-07-06 22:47 ` Stephen Hemminger
2023-07-06 22:49 ` Stephen Hemminger
2023-07-07 0:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028155117.2880b051@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmiller423@gmail.com \
--cc=dmitry.kozliuk@gmail.com \
--cc=haiyue.wang@intel.com \
--cc=hkalra@marvell.com \
--cc=jgrajcia@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@nvidia.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=sameh.gobriel@intel.com \
--cc=tardis@us.ibm.com \
--cc=viacheslavo@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yipeng1.wang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).