From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34031A00C4; Sat, 29 Oct 2022 11:05:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D08A340694; Sat, 29 Oct 2022 11:05:27 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 00D6640146 for ; Sat, 29 Oct 2022 11:05:25 +0200 (CEST) Received: from [192.168.1.39] (unknown [188.170.73.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A5C085E; Sat, 29 Oct 2022 12:05:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A5C085E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667034325; bh=dRjcrrZC7UdA/1DJrytsrTSMHImttV35GnVnFHBIOI0=; h=Date:To:Cc:From:Subject:From; b=trWWCkMBBSNj0N/A/Iwq1aloeiogm53qZlRMwPX20iEmlONMMQh5sR+iyVgYtHwAg PCDuoWgxStcVX6hglLW7behIhPaBzH3h7roiIEERGpUjULzqqb7+i+E1g/kZXb+M/1 GNTFNjwi0clWES3YxGX511XmcP06l13hriFlADLc= Content-Type: multipart/alternative; boundary="------------0110hHxNqWRiwuOuevD6L0ia" Message-ID: Date: Sat, 29 Oct 2022 12:05:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: Raslan Darawsheh Cc: "dev@dpdk.org" , Thomas Monjalon , David Marchand From: Andrew Rybchenko Subject: DPDK main build is broken for me in net/mlx5 if I disable common/mlx5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. --------------0110hHxNqWRiwuOuevD6L0ia Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, DPDK main build is broken for me in net/mlx5 if I disable common/mlx5 ../src/drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config". It worked for me before and net/mlx5 is not built since common driver is missing. Andrew. --------------0110hHxNqWRiwuOuevD6L0ia Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi,

DPDK main build is broken for me in net/mlx5 if I disable common/mlx5

../src/drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config".

It worked for me before and net/mlx5 is not built since common driver is missing.

Andrew.
--------------0110hHxNqWRiwuOuevD6L0ia-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93791A00C3; Sun, 30 Oct 2022 01:17:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 321BC40A7F; Sun, 30 Oct 2022 01:17:27 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C531E40694 for ; Sun, 30 Oct 2022 01:17:25 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C6D725C008E; Sat, 29 Oct 2022 19:17:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 29 Oct 2022 19:17:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667085442; x=1667171842; bh=6H pp/UubcmqgKzL0qtK+iBZxKl3d+I88AAdX9IxoKjw=; b=px9geOkCsqunSWTTli RdhM4yWxfEz6KV0yW8JDMgiqrv+PBDJ4zoRhZr+TIXhBHBrR8H0E5Ndk9szha4xM vnY0hg8MTNxD2I9MKqTYqF5V8238Pf3GtXloCfAoR4QTOGdZTCvmjyzN0UdxMcxG heCC9pUr7QNsW/ViNQt45VD/qy6hlOX/RqCljZ3YWOCu5e9h4HnPVJqBh/4aQB08 e5T/9DyclSdmHitpxB7KxiyzQq7haWfTmUu0jtBaBU13hrDXpAna92yaXXMLvMx9 CyNhuxTXREemHFb7lHIFGKNgc22iZvxlJ6tmGTv8v1X9geD83i9Rn7wwy3nxzgSX H3Hg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667085442; x=1667171842; bh=6Hpp/UubcmqgK zL0qtK+iBZxKl3d+I88AAdX9IxoKjw=; b=bkGjjsrMjmjH0HWxuJ2yT5f4K4w0L dRJVKy5yVH5IMF675slkO1Nqt5emK6Im8X1FJREeEGgQbogFNtnmqxwjq9gMTMJM E7eyKdHfbE3HWx3JhGf09fw+QrvTDIRZFR5DiIUuZHLTXFmEE8nrer8XZvQthU98 Nej216KVLaRRIttJEGXqM5NCk7G/0LeD/tqmQl78BLbTs5QSOZMlUOrqd1w/7JDI ySX7/6rICYJPO5ZowVXmJWMO70viXzlMHPF/X4NkDHxJj+eJq22h9VMjBuQB+39U +5HNeyPYE/SgpKzsHMxqbqCFSJgjKHdsx2PMkersuzMto2N01X/lzXXUA== X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvjefhudeghedvtdeije eigeetuedugfejueekieeltdfhteevkeehhfeilefhtdenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Oct 2022 19:17:20 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, avid.marchand@redhat.com Subject: [PATCH 0/2] fix build disabling common/mlx5 Date: Sun, 30 Oct 2022 01:17:09 +0200 Message-Id: <20221029231712.773630-1-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Andrew reported a build failure when disabling mlx5 common driver. It is a blocker for -rc2 release. While fixing the use of a variable across mlx5 drivers in first patch, the consistency of its use is improved in a second patch. Thomas Monjalon (2): net/mlx5: fix disabling common/mlx5 dependency common/mlx5: move Meson config initialization and check drivers/common/mlx5/linux/meson.build | 2 -- drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/windows/meson.build | 4 ---- drivers/net/mlx5/hws/meson.build | 4 ++++ drivers/net/mlx5/meson.build | 8 +++++--- 5 files changed, 11 insertions(+), 9 deletions(-) -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20029A00C3; Sun, 30 Oct 2022 01:17:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 115CC41147; Sun, 30 Oct 2022 01:17:53 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 1A6FE40694 for ; Sun, 30 Oct 2022 01:17:52 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CCCA55C007C; Sat, 29 Oct 2022 19:17:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 29 Oct 2022 19:17:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667085471; x=1667171871; bh=na 1KP6TF96qfQWtj5RxyZ2uVqvwLDvWulLux6SufzLg=; b=jgH28oczlrqn0IO4t8 QlmkKsvKqR27mcy+qp4pBDaKqD/Q5++rNtuNswUA8mspXs8oHoGqeW3JzT7Iw4eR wvI35kB6TXdTtAgcZTAEesugXu+guIoeecqiE4uPhhvG2BTym8TgXYAb42EXxlpK Dkv290JpC2TuY/M+e9ieO7jcmt+ccVi8o6acMLT+wHc4pR3ERtrbn/JIVQt53DLA c2FwTUUxGvjCmz+qqRACe4lHRevAmg++imT/1RdwK4CnON867K0xA2+u741NR+Pv rXl3MTR553Bg/u8hWRBuNSxEe/XQrLpSNrPrtecYuIpkyv26zS+auB1aa3gHaGuu 6McQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667085471; x=1667171871; bh=na1KP6TF96qfQ Wtj5RxyZ2uVqvwLDvWulLux6SufzLg=; b=ir/RsBaNCT5fa9FvkFFo22F+1SW3I EgkbAqQecNm6CiucbTYpg1UeoFVZlVDWjDG4vnRJP0zGfA6snP9CAPQ3LbgxC4qY am4KJ3cTLjglVhNQrJzdT6iwKdS2PxLjECaZsjleap1wkfldr7XgcW7trBUd65iP 6fEcdGqkielIlfTrWafj8JZOj7An1mixVxRb5864xE54pYWMUEWrz8bDtfNfZAaI TR23pVzUFIBRjYQ9jdzFC+8hBOY/WhCLwqbfxt51fIrlIqQp4ieLtrUT10neTPJq 7LZgeAO6xl+Jyt6a8VW8x9YVo1nNXdTgDZHesVH+xrTJ+LgEsyMnl+w3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Oct 2022 19:17:49 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, avid.marchand@redhat.com, Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 1/2] net/mlx5: fix disabling common/mlx5 dependency Date: Sun, 30 Oct 2022 01:17:10 +0200 Message-Id: <20221029231712.773630-2-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221029231712.773630-1-thomas@monjalon.net> References: <20221029231712.773630-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not explictly disabled, Meson will read the full recipe of net/mlx5 and will fail when accessing a variable from common/mlx5: drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config". The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. The deps array must be defined before stopping, in order to automatically disable the build of net/mlx5 and print the reason. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Reported-by: Andrew Rybchenko Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/meson.build | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index ff84448186..9a8eb0bc19 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -9,6 +9,10 @@ if not (is_linux or is_windows) endif deps += ['hash', 'common_mlx5'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif headers = files('rte_pmd_mlx5.h') sources = files( 'mlx5.c', -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67C66A00C3; Sun, 30 Oct 2022 01:18:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56A384280E; Sun, 30 Oct 2022 01:18:01 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id E97D74280C for ; Sun, 30 Oct 2022 01:17:59 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9D3C15C0090; Sat, 29 Oct 2022 19:17:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 29 Oct 2022 19:17:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667085479; x=1667171879; bh=OM cptTW21hH+iqYF4WtL5bTuRcYZxnz8qkR56e+o0JI=; b=fqLWWH8WkqnbFc4El9 e1Ychec9CbwoFC2UOhWZC9760NOs/4vK7rE0LXCZonu1iSWJKzLJOW3wZU1McQXx OnZdrZm0J8I2A/WYhdNDYQdngGvAdSZoV51XHHknYx+uLd/VVVvSNczeFoIiR3W/ KvJTpVvOz6HJEkVg5ryVilH+ylhuqT8fvIqdYxZAiCx/i0DCbIOOFfftySSgWpjH TdmmiCEdzR2EHrbUZdoLanw9Y1MCzNt/8/R1rRkbSOAWET9SoinWWcRZeZLzE74I +SSlJPyIoOOMnVZDOqOserFFzJ7Mt4+EDnltwvxoTz1z3lR4hpIY+hgDlaB67p3T HF1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667085479; x=1667171879; bh=OMcptTW21hH+i qYF4WtL5bTuRcYZxnz8qkR56e+o0JI=; b=cL4IkQKmVnR9vqyxyCAPpqQ196KHX vhce6TGtVvXOkePl2dT2Ht1Aj1HCoOIYZjaAZLoYHorqIF+dqy8ZHpKUSXJOxYxe daP2iQsrohU1Cn2MtPZYY/92txlS837yZb6Xrtkf2MdDknhF0rVg9njDu77ILEtq fWZsnUarXOfVqo6J2taGbAll6LiccheNCp9TzP1aO8QXi2r2FEAkN2ZQcHBnqGPY hk1DWiXerXmyzWNlmX9m+RiRhwNN1zDMj8A6FohRAF9sSJz69a8bzTxIdmA2zU99 z+tSzmaJy7gm81qSGHJhG6sCVnbfs9LnswQJL3ZBkJGHEvorqTc9YMV0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Oct 2022 19:17:57 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, avid.marchand@redhat.com, Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 2/2] common/mlx5: move Meson config initialization and check Date: Sun, 30 Oct 2022 01:17:11 +0200 Message-Id: <20221029231712.773630-3-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221029231712.773630-1-thomas@monjalon.net> References: <20221029231712.773630-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The variable mlx5_config may be used by other mlx5 drivers and should be always initialized. By moving its initialization (with configuration file generation), it is made consistent for Linux and Windows builds. And the check of mlx5_config in net/mlx5 is moved at the top of net/mlx5/hws/meson.build so HWS requirements are in the right context. Signed-off-by: Thomas Monjalon --- drivers/common/mlx5/linux/meson.build | 2 -- drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/windows/meson.build | 4 ---- drivers/net/mlx5/hws/meson.build | 4 ++++ drivers/net/mlx5/meson.build | 4 +--- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build index 84e2a1ad8c..2b57b299bd 100644 --- a/drivers/common/mlx5/linux/meson.build +++ b/drivers/common/mlx5/linux/meson.build @@ -8,7 +8,6 @@ dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE = 'librte_common_mlx5_glue.so' LIB_GLUE_VERSION = abi_version LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION -mlx5_config = configuration_data() if dlopen_ibverbs dpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1) cflags += [ @@ -232,7 +231,6 @@ foreach arg:has_member_args file_prefix = '#include <' + arg[1] + '>' mlx5_config.set(arg[0], cc.has_member(arg[2], arg[3], prefix : file_prefix, dependencies: libs)) endforeach -configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config) # Build Glue Library if dlopen_ibverbs diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build index 6ddbde7e8f..d7ca21d2cf 100644 --- a/drivers/common/mlx5/meson.build +++ b/drivers/common/mlx5/meson.build @@ -37,4 +37,6 @@ else cflags += [ '-UPEDANTIC' ] endif +mlx5_config = configuration_data() subdir(exec_env) +configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config) diff --git a/drivers/common/mlx5/windows/meson.build b/drivers/common/mlx5/windows/meson.build index edbbaa9ae1..cc486014a8 100644 --- a/drivers/common/mlx5/windows/meson.build +++ b/drivers/common/mlx5/windows/meson.build @@ -39,7 +39,3 @@ if get_option('buildtype').contains('debug') else cflags += [ '-UPEDANTIC' ] endif - -# Generate an empty mlx5_autoconf.h file for compatibility with Linux -config = configuration_data() -configure_file(output : 'mlx5_autoconf.h', configuration : config) diff --git a/drivers/net/mlx5/hws/meson.build b/drivers/net/mlx5/hws/meson.build index d2bb864fd2..38776d5163 100644 --- a/drivers/net/mlx5/hws/meson.build +++ b/drivers/net/mlx5/hws/meson.build @@ -1,6 +1,10 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 NVIDIA Corporation & Affiliates +if not (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) + subdir_done() +endif + includes += include_directories('.') sources += files( 'mlx5dr_context.c', diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index 9a8eb0bc19..66b23f5584 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -77,6 +77,4 @@ testpmd_sources += files('mlx5_testpmd.c') subdir(exec_env) -if (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) - subdir('hws') -endif +subdir('hws') -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5AC8A00C2; Sun, 30 Oct 2022 08:34:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8372740693; Sun, 30 Oct 2022 08:34:13 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9D59540151 for ; Sun, 30 Oct 2022 08:34:12 +0100 (CET) Received: from [192.168.1.39] (unknown [188.170.73.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 776055A; Sun, 30 Oct 2022 10:34:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 776055A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667115251; bh=eLYkIYZsmUyspUMIM1Gn1hBTux8Jp9J/b8iz6cKd1YA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wzsb78fQrYk8e4ohuy7Ts6XgbuSAquneEavXElrT+EdQfEVkrm/mRNwLFuPcy7D/G Eb5sr/Y9qSuusZhrBvCaWeIPXqlUHp5KmxjojN/rmNCaDP9Dd5SY8HkYb1NOZpRab8 VhlBsaXXvKFTxjScMFgQwd/Thw9z7/HD1CSGIlLM= Message-ID: <16f78136-45ee-dff0-942c-19147d9b4f25@oktetlabs.ru> Date: Sun, 30 Oct 2022 10:34:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 0/2] fix build disabling common/mlx5 To: Thomas Monjalon , dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, rasland@nvidia.com, avid.marchand@redhat.com References: <20221029231712.773630-1-thomas@monjalon.net> Content-Language: en-US From: Andrew Rybchenko In-Reply-To: <20221029231712.773630-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/30/22 02:17, Thomas Monjalon wrote: > Andrew reported a build failure when disabling mlx5 common driver. > It is a blocker for -rc2 release. > > While fixing the use of a variable across mlx5 drivers in first patch, > the consistency of its use is improved in a second patch. > > Thomas Monjalon (2): > net/mlx5: fix disabling common/mlx5 dependency > common/mlx5: move Meson config initialization and check > > drivers/common/mlx5/linux/meson.build | 2 -- > drivers/common/mlx5/meson.build | 2 ++ > drivers/common/mlx5/windows/meson.build | 4 ---- > drivers/net/mlx5/hws/meson.build | 4 ++++ > drivers/net/mlx5/meson.build | 8 +++++--- > 5 files changed, 11 insertions(+), 9 deletions(-) > Many thanks, it solves my build problem: Series-tested-by: Andrew Rybchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AF0AA00C2; Sun, 30 Oct 2022 09:27:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C89E40693; Sun, 30 Oct 2022 09:27:41 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id A563040151 for ; Sun, 30 Oct 2022 09:27:40 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2F6455C00D9; Sun, 30 Oct 2022 04:27:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 30 Oct 2022 04:27:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667118460; x=1667204860; bh=iO jBVy09AB4lrZrcl6OqG1VJrmzleaO7CK94uUM6h20=; b=vTZGQa1pHeOgKs1SSU C/un3+F341n09DlRp+8w0UhAo0vKsBOgSGEeBghjh1JIqjLmrNHonFLPoC4LMMnO zvdqIA/3SBzLnGejFZHZSqj27e4ir8bA0n3iBtgrXmns3nF50xC9K+3ttmrrfaTx qfc64LnWr124xIEkQPpHO0nTY0nvmlvpxB7EwZoonhLrvNzwlAVj2iNZbRWTCywa R/dHAI+RMQgwWWtMw/BMhYhphGhGs7sB9uz4P7EPToMzwbSTy6ZKCZwJeLjo7daw vxi3HTnMI6tpoifyuEhq68Gv4iRBonARF/R9H1CqoKfqgmmtJGK/k8BosKHP94pk 58Hw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667118460; x=1667204860; bh=iOjBVy09AB4lr Zrcl6OqG1VJrmzleaO7CK94uUM6h20=; b=U3Csuk5B7QPwsR2/v93URcRr9BuA+ oBXUi6SreDMaN7gru7G1mLhIhiPVOLtKPJFDjPK6uFShG3TySKlFAbb+CUjSK15r TWAxfqeATga/xiOJcWyc4GDUK5eXW8fMfl68Lk+ePSKrAklX4qus9j78mgFMeQty UwaZlyjbV2EmLBXwLYOvTH6kJ+TJblkoiaLiOZPrZjUzrgslbevnJw1n1qK2sufE eR/Vg1BlZZULFeOsTxKJeQTcAk55rd/1BtmfTz9G7/b9MjhMriGAOfTM/WKbDqsM 9+OmFwV8MHK5Aylk8RieIaUaLSP3ceK8gC6sMLEdO7t/9Ph8qb7Ckb1oQ== X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddufeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 04:27:38 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, Matan Azrad , Fan Zhang , Ashish Gupta , Viacheslav Ovsiienko , Ori Kam Subject: [PATCH v2 1/2] common/mlx5: fix build disabling Date: Sun, 30 Oct 2022 09:27:21 +0100 Message-Id: <20221030082722.1333530-2-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221030082722.1333530-1-thomas@monjalon.net> References: <20221030082722.1333530-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not explicitly disabled, Meson will read the full recipe of net/mlx5 and will fail when accessing a variable from common/mlx5: drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config". The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. The deps array must be defined before stopping, in order to automatically disable the build of net/mlx5 and print the reason. The same protection is applied to other mlx5 drivers, so it will allow using the variable mlx5_config in future. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Reported-by: Andrew Rybchenko Signed-off-by: Thomas Monjalon Tested-by: Andrew Rybchenko --- drivers/compress/mlx5/meson.build | 5 +++++ drivers/crypto/mlx5/meson.build | 5 +++++ drivers/net/mlx5/meson.build | 5 +++++ drivers/regex/mlx5/meson.build | 5 +++++ drivers/vdpa/mlx5/meson.build | 5 +++++ 5 files changed, 25 insertions(+) diff --git a/drivers/compress/mlx5/meson.build b/drivers/compress/mlx5/meson.build index 7aac329986..49ce3aff46 100644 --- a/drivers/compress/mlx5/meson.build +++ b/drivers/compress/mlx5/meson.build @@ -9,6 +9,11 @@ endif fmt_name = 'mlx5_compress' deps += ['common_mlx5', 'eal', 'compressdev'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_compress.c', ) diff --git a/drivers/crypto/mlx5/meson.build b/drivers/crypto/mlx5/meson.build index 9d9c9c00bc..7521c4c671 100644 --- a/drivers/crypto/mlx5/meson.build +++ b/drivers/crypto/mlx5/meson.build @@ -9,6 +9,11 @@ endif fmt_name = 'mlx5_crypto' deps += ['common_mlx5', 'eal', 'cryptodev'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_crypto.c', 'mlx5_crypto_dek.c', diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index ff84448186..fa15158039 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -9,6 +9,11 @@ if not (is_linux or is_windows) endif deps += ['hash', 'common_mlx5'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + headers = files('rte_pmd_mlx5.h') sources = files( 'mlx5.c', diff --git a/drivers/regex/mlx5/meson.build b/drivers/regex/mlx5/meson.build index e553dcb83d..70edc5b6da 100644 --- a/drivers/regex/mlx5/meson.build +++ b/drivers/regex/mlx5/meson.build @@ -8,6 +8,11 @@ if not is_linux endif deps += ['common_mlx5', 'eal', 'regexdev'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_regex.c', 'mlx5_rxp.c', diff --git a/drivers/vdpa/mlx5/meson.build b/drivers/vdpa/mlx5/meson.build index 9d8dbb1a82..54a4eac6f4 100644 --- a/drivers/vdpa/mlx5/meson.build +++ b/drivers/vdpa/mlx5/meson.build @@ -8,6 +8,11 @@ if not is_linux endif deps += ['hash', 'common_mlx5', 'vhost', 'pci', 'eal', 'sched'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_vdpa.c', 'mlx5_vdpa_mem.c', -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77680A00C2; Sun, 30 Oct 2022 09:27:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A51740A8B; Sun, 30 Oct 2022 09:27:42 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id A8B2940693 for ; Sun, 30 Oct 2022 09:27:40 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6F3D85C00D1; Sun, 30 Oct 2022 04:27:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 30 Oct 2022 04:27:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667118457; x=1667204857; bh=9U o15bfPseHnxpZDlly5UBIMco/pmbt+hvOCQLHlVmg=; b=AsE5r64z9hXlujDdLf 1qZeT7+f7xM0EVDeGZjcKjKf9zq6gkn7Qh2CFEWrqjL74LfhaSH8yl3Y+nJsklnW kxJxPUZAxjDrVqz0GwKAeHKOgL5KdMVy7gO7T2N9/5+i6HrJxvqbqtwsn247DJfl p4/2Cp79IwHV+efB+8zTuMTKT1VrpSM6es+pVotXF40c9UPcTr+WM4+dG7Nzqfil D1VWLd8aFawXgTnfZDTrULw920eCbxh5ADxUjcZ5+lk3BVyAf5PAwLt4q2ApY5+m RseK6lpo3tWiPWh+Nkch/i5OCG5nxPCwXpPP96I+yyI+/wGPkuxAkXoZ5K1Nglww gLGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667118457; x=1667204857; bh=9Uo15bfPseHnx pZDlly5UBIMco/pmbt+hvOCQLHlVmg=; b=EIDGslBJVP+0kbiPkchiEjtf8jUbx T6zYOdm7/b9sK/Hxwh3HjHKPNZfa06N07jGqeq0XNBdifqiRgVP7QrELBpaPLXGf k1jmbLCf0gRYyKW1fSTtEw9AY5HyOKMduON+BGBbEWcMphjWJNuVyhhSqKPxEp/k 9F43LN3oqKXGV4BY3EZlLYpEMUgrEKUAr8UkN+Md/88PzGtQfTj/gsdAWq323ZlA YgOpQJHIuLXaXoDSiywerRXokSHl5N4Qywjc1UjtomN/T/pAclwXKj+ZCvPFZjyO cvLiKbgrQm8Tb1N7c9PsY7R1nButtGp+X8lY0mGn4L0SYL4uDQ6j8rbbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddufeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdejhfdugeehvddtie ejieegteeuudfgjeeukeeiledthfetveekhefhieelhfdtnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 04:27:35 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com Subject: [PATCH v2 0/2] fix build disabling common/mlx5 Date: Sun, 30 Oct 2022 09:27:20 +0100 Message-Id: <20221030082722.1333530-1-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Andrew reported a build failure when disabling mlx5 common driver. It is a blocker for -rc2 release. While fixing the use of a variable across mlx5 drivers in first patch, the consistency of its use is improved in a second patch. v2: apply the same protection to other mlx5 drivers Thomas Monjalon (2): common/mlx5: fix build disabling common/mlx5: move Meson config initialization and check drivers/common/mlx5/linux/meson.build | 2 -- drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/windows/meson.build | 4 ---- drivers/compress/mlx5/meson.build | 5 +++++ drivers/crypto/mlx5/meson.build | 5 +++++ drivers/net/mlx5/hws/meson.build | 4 ++++ drivers/net/mlx5/meson.build | 9 ++++++--- drivers/regex/mlx5/meson.build | 5 +++++ drivers/vdpa/mlx5/meson.build | 5 +++++ 9 files changed, 32 insertions(+), 9 deletions(-) -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4980A00C2; Sun, 30 Oct 2022 09:27:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5916440A7F; Sun, 30 Oct 2022 09:27:46 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 7616E410D1 for ; Sun, 30 Oct 2022 09:27:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 32C2E5C00C3; Sun, 30 Oct 2022 04:27:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 30 Oct 2022 04:27:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667118463; x=1667204863; bh=eu xx7cVwfiEQK1NfzCzy8eNwku8cHyUPoZpzdgypBwE=; b=pwRuU7sfXvHXn2WC3K XtWD6vBWwAe9PGNquFDDwaqFNQifNyirEdd5fN/hPBGqspfwLOoSR9GDYJNFp82r tp2qZEIjZBkbvzdBIoZ70EqvJ6nZOqaYSXQwE8m5P8PB1P6ku0WGzFrqqWq61gFG TMufasgNjOaZOLeQfkJbKtHLvs5izccrsNWTtNRS+VU6M7/PweRiTWlKeigIbRzm x2sxGG58FLmOz7bYn7bmFQ41KMbalV9z9+lbV7M9dPywqEM3LAHyVvpGh5Gvu4CP S8jcHyhGEp/tWirXUN6W625A8oNU1XacakB+kB1H+e3mKcsXlEQKxf282H+SJkoG lL8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667118463; x=1667204863; bh=euxx7cVwfiEQK 1NfzCzy8eNwku8cHyUPoZpzdgypBwE=; b=UZ1OcmH39TX46/VoPpUBoqYabJ6Nr /kybZUTc4kreHIc2GFLMv85J7psPmLwkbL3vmVluphRyWmXjjTI7VfcT68WwwVh4 9waDM1C+KyCFjKi5o2o4E2d29OFlV4UkYtoiwSlTGvqSy2sUav0U+kEsLsJZrU9c NJOmvf78aY4+x2ux7q/tHuYSqSwnsg0z+/+oyjtQCQbBElC1ZXhYYFqjByOfIYHY jjFjpJqPBx6K1vfqOMdQifGmSjKnPrxEGvvRh/lXaDTISUvVae9TCkuqiz8hFWJ5 dROBfnJwXouKBHd927oATDbL6cPlvwJS7TmdIpEGSibbpYKfl9ItsnY1g== X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 04:27:41 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v2 2/2] common/mlx5: move Meson config initialization and check Date: Sun, 30 Oct 2022 09:27:22 +0100 Message-Id: <20221030082722.1333530-3-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221030082722.1333530-1-thomas@monjalon.net> References: <20221030082722.1333530-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The variable mlx5_config may be used by other mlx5 drivers and should be always initialized. By moving its initialization (with configuration file generation), it is made consistent for Linux and Windows builds. And the check of mlx5_config in net/mlx5 is moved at the top of net/mlx5/hws/meson.build so HWS requirements are in the right context. Signed-off-by: Thomas Monjalon Tested-by: Andrew Rybchenko --- drivers/common/mlx5/linux/meson.build | 2 -- drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/windows/meson.build | 4 ---- drivers/net/mlx5/hws/meson.build | 4 ++++ drivers/net/mlx5/meson.build | 4 +--- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build index 84e2a1ad8c..2b57b299bd 100644 --- a/drivers/common/mlx5/linux/meson.build +++ b/drivers/common/mlx5/linux/meson.build @@ -8,7 +8,6 @@ dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE = 'librte_common_mlx5_glue.so' LIB_GLUE_VERSION = abi_version LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION -mlx5_config = configuration_data() if dlopen_ibverbs dpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1) cflags += [ @@ -232,7 +231,6 @@ foreach arg:has_member_args file_prefix = '#include <' + arg[1] + '>' mlx5_config.set(arg[0], cc.has_member(arg[2], arg[3], prefix : file_prefix, dependencies: libs)) endforeach -configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config) # Build Glue Library if dlopen_ibverbs diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build index 6ddbde7e8f..d7ca21d2cf 100644 --- a/drivers/common/mlx5/meson.build +++ b/drivers/common/mlx5/meson.build @@ -37,4 +37,6 @@ else cflags += [ '-UPEDANTIC' ] endif +mlx5_config = configuration_data() subdir(exec_env) +configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config) diff --git a/drivers/common/mlx5/windows/meson.build b/drivers/common/mlx5/windows/meson.build index edbbaa9ae1..cc486014a8 100644 --- a/drivers/common/mlx5/windows/meson.build +++ b/drivers/common/mlx5/windows/meson.build @@ -39,7 +39,3 @@ if get_option('buildtype').contains('debug') else cflags += [ '-UPEDANTIC' ] endif - -# Generate an empty mlx5_autoconf.h file for compatibility with Linux -config = configuration_data() -configure_file(output : 'mlx5_autoconf.h', configuration : config) diff --git a/drivers/net/mlx5/hws/meson.build b/drivers/net/mlx5/hws/meson.build index d2bb864fd2..38776d5163 100644 --- a/drivers/net/mlx5/hws/meson.build +++ b/drivers/net/mlx5/hws/meson.build @@ -1,6 +1,10 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 NVIDIA Corporation & Affiliates +if not (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) + subdir_done() +endif + includes += include_directories('.') sources += files( 'mlx5dr_context.c', diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index fa15158039..f1aab18f82 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -78,6 +78,4 @@ testpmd_sources += files('mlx5_testpmd.c') subdir(exec_env) -if (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) - subdir('hws') -endif +subdir('hws') -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED2DEA00C2; Sun, 30 Oct 2022 10:15:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D04CE40693; Sun, 30 Oct 2022 10:15:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 58E9C40151 for ; Sun, 30 Oct 2022 10:15:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667121312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpKiSeHXgoOBHOIejyE2O/R6bbEq+3557Z7EdXmxEoc=; b=d4xgB3YhlLB9Xm2Jfupo9xS153hcJ2DQJsIWfR0y1L/px9wOqJqt0kan0qg+u/VsWaog+8 zDnY4j16S/gSQUEbMvxrQM7m3fgUwRdWOzo+3CEp6X6qcveFgTEsehbPEBrMEu/yungtPO TbU9dQ3YJGqnRbKm+pKTpgOYVDiM4XQ= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-226-n0MrIZm2N3ShUwoZHhjZTQ-1; Sun, 30 Oct 2022 05:15:08 -0400 X-MC-Unique: n0MrIZm2N3ShUwoZHhjZTQ-1 Received: by mail-pl1-f199.google.com with SMTP id b18-20020a170903229200b00186e357f3b9so6259266plh.6 for ; Sun, 30 Oct 2022 02:15:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LpKiSeHXgoOBHOIejyE2O/R6bbEq+3557Z7EdXmxEoc=; b=CEH9I7a6SbiSm56ifRS7+xQA/fJbiwWTRuAu4YT4ND3Y2JcRqHe3sQ8ASV1bixpC/3 sdXaAOb7bANuWAf+DIOB/aXfrf3qC5q6ELG5JMX0G21sFpyqHkGwUUsRqG1eh1gPukTI 12jPouLCnKRrKk9tQ2kWTwGRFAHFJz3uiXuhgP4nqidyOqeN5ABMN8i63yAob5t6C0LU dmLJMgiBzeIODjl6LWU1SrDC+fj/gm8RNF0/1/lhQGdXtXRR0gZUFiEhur06aRDQB1+a FqWhyhpVBV9a6va7qu7baek3GQnIA+z6zz9Pr3nfCFme5AGlmnOAUQg/AvUGlRaOE0xS dlOA== X-Gm-Message-State: ACrzQf0/3Wch5h13YuQwCAjEoxVL88krQ8xEvqieO/CHfll6/lqfCap4 dH7G4pwxvLCsmEK7sqWYYJHI7MIkRpcMijLbnhIGzm4pi/f6ct9Dp4TeN3GKchJKbhKSN31d5wT NT/H/W6ELtpEvxsofTsk= X-Received: by 2002:a62:b411:0:b0:56c:5afe:649f with SMTP id h17-20020a62b411000000b0056c5afe649fmr8230839pfn.60.1667121307479; Sun, 30 Oct 2022 02:15:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4iM61dlMtQIa6gi468hpWzAZU5KDO8+zfNYaryzJRtgVPjVNBdg7UaoTSacV2xa74jL6NX80V3Yg7M36JNd90= X-Received: by 2002:a62:b411:0:b0:56c:5afe:649f with SMTP id h17-20020a62b411000000b0056c5afe649fmr8230821pfn.60.1667121307227; Sun, 30 Oct 2022 02:15:07 -0700 (PDT) MIME-Version: 1.0 References: <20221030082722.1333530-1-thomas@monjalon.net> In-Reply-To: <20221030082722.1333530-1-thomas@monjalon.net> From: David Marchand Date: Sun, 30 Oct 2022 10:14:55 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] fix build disabling common/mlx5 To: Thomas Monjalon Cc: dev@dpdk.org, valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Oct 30, 2022 at 9:27 AM Thomas Monjalon wrote: > > Andrew reported a build failure when disabling mlx5 common driver. > It is a blocker for -rc2 release. > > While fixing the use of a variable across mlx5 drivers in first patch, > the consistency of its use is improved in a second patch. > > v2: apply the same protection to other mlx5 drivers > > Thomas Monjalon (2): > common/mlx5: fix build disabling > common/mlx5: move Meson config initialization and check > > drivers/common/mlx5/linux/meson.build | 2 -- > drivers/common/mlx5/meson.build | 2 ++ > drivers/common/mlx5/windows/meson.build | 4 ---- > drivers/compress/mlx5/meson.build | 5 +++++ > drivers/crypto/mlx5/meson.build | 5 +++++ > drivers/net/mlx5/hws/meson.build | 4 ++++ > drivers/net/mlx5/meson.build | 9 ++++++--- > drivers/regex/mlx5/meson.build | 5 +++++ > drivers/vdpa/mlx5/meson.build | 5 +++++ > 9 files changed, 32 insertions(+), 9 deletions(-) For the series, Reviewed-by: David Marchand -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF8A4A00C2; Sun, 30 Oct 2022 10:16:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C36A64280E; Sun, 30 Oct 2022 10:16:30 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48]) by mails.dpdk.org (Postfix) with ESMTP id 8E0D84281A for ; Sun, 30 Oct 2022 10:16:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FZk3cfRm4MUyVa+WKqbHo4jfFVpeHPvXLQCbA7K1bADcS9kwa7vklTothaHMcrjwWk9He38fxNm/s19UQD8qtoQLpm+wlAbjreRLMIbeb/8aRwxG1bYPXj/Ck3AFKJhd6tbM7GOD9hbg5kIyEZiL7lgdL0AuBUHV5QCTaY6IfCtLVEVRfcg3mDAOA7sbY8TYNppFTtlmok5snNgIL6onapJve7sBpZ+ln4n67d39gDX5rcwTagrWlB88aQjpw+OOEoibAVggRRd4tJMYXWYCFR2nKSRb1h/WhgdiC5qfDqJGKm4DQjJ3OzgDP98xGwMkD+thQT1X2G4E8VjGTHbLLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IT8KDIadXAEJ3lXLIYPpa/x5FYBxK6i8WTylV8pw5PU=; b=oVaPZo83cFRE00Nx7ajuRpVWtZpOpuJnt+FfOpgem2HH/g8T5vTjEqb8vJBl4MN278q4fBmqtPMC4nb2rwvbRtWRYayTve64CLVjdp1bO033JzIyX4WGsTmmCg1kWKynfvPITI384e3nDU1JzbSUQVuwiNoBGyC2uZ/Fl9UAWxmmy4oMtRUmIWvZLe0A+l4VvutvVbUcOnsrCWrls8Ftulw2jEXikRpEsxlICjECRzV6qcVVxEXjR+498GEJo4WDln09tIC9LdEzKU20qYpSo8o1qGKAy3ClhMvZitk/dj0Dr/N+FRG/WV1A8RNBBqpiavxmXISYS1QpKcD9GmiQTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IT8KDIadXAEJ3lXLIYPpa/x5FYBxK6i8WTylV8pw5PU=; b=lIK6pGlizFH/qrQi+3L1lqoCEio8tNHg4PDMFWE+PWKh+WkWE5Q5N+A0rTc6KLETQs6BpKTimZpHwu8JUd/fl7ZHSJ2b6dpMKCz0W621tpFLmtP1Tx2beUCPE4XiMYBafw4WgTykMC8Vlyf7T3HtA/EpcRlAYDz3Y+FL+Z+IjYxbJwQdh0nll6ZUKUHG1ySIPNqLYGPy1vGEh0gkCUjzk/3nhVmbAJidk6IsWvzH3/i0Ei9CNN35+p9gcwBuOaZ7cK8DYYC4TzxutRemHrCm5xNwLB34OKSn5vkAqoH9ODXpa3FPrMbqEE9K67/YQi68lOcxznkCEN7JgOtlZm6F6Q== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by DM4PR12MB6181.namprd12.prod.outlook.com (2603:10b6:8:a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.18; Sun, 30 Oct 2022 09:16:28 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2d6:9f4e:4ff7:c45e]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2d6:9f4e:4ff7:c45e%8]) with mapi id 15.20.5769.018; Sun, 30 Oct 2022 09:16:28 +0000 From: Matan Azrad To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: Alex Vesker , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Raslan Darawsheh , "david.marchand@redhat.com" , Fan Zhang , Ashish Gupta , Slava Ovsiienko , Ori Kam Subject: RE: [PATCH v2 1/2] common/mlx5: fix build disabling Thread-Topic: [PATCH v2 1/2] common/mlx5: fix build disabling Thread-Index: AQHY7Dl6ZmBz2+NPFEq2lex1ZeNWz64mqBAg Date: Sun, 30 Oct 2022 09:16:27 +0000 Message-ID: References: <20221030082722.1333530-1-thomas@monjalon.net> <20221030082722.1333530-2-thomas@monjalon.net> In-Reply-To: <20221030082722.1333530-2-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5389:EE_|DM4PR12MB6181:EE_ x-ms-office365-filtering-correlation-id: 4c4886a6-8ed0-4015-1f26-08daba576d05 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q+t57wPOKy3KO1q6SYyhr2jeYceGRNLvKXrynpo9SJIFt7lMomhiXz5LzlOm+WVHsaCuHXSV830TBXo36CJ+c5dPToWgvJ/dpreqVELVQNmnwgzlNNgc21cLh3CTG6ks6AcDfBsnf/WpEX7CFE2KspKwaXy0CcyzPXW7jlK3gtTj8grO4IkrmR6zqt+Uw2tPFBnNktdwVIKPaeN47vH9CWpvUlgv1hGJdf2UxL8p+617UCluxbd21Pp7CEE/9WGb38S7/rZLVSB5Z0RaL40RxU5dUWZ3XAx19tR0YFUmZtc3HOqPlndBQT9jcOQ1a2awM0rKCss8yk9aOWHeW1EAu3IQky1h0DIySkoefR60YhWGgw3MjrwSLyQJrPXpbbyBhyng9MpXcUmrzsxpOE6m7ngJzsHejmcrOb2XDdNhvisIyEyfvjZXD0nt3Mt1JzWysExaPY77xHf1KUgL4++0KlNkvvLMTGmH++sHeqpPxVUKBYSbkVpzrOjpUq9IFMtoZJ9Rubmow1h0LkX8eR1vQUQKLQ01Xqh41Bs8Coxcm4hcSQPpdmtV8GI/1xlKsHOVd1rkGExUeeut2hrYuJI+kD6uFKLstQRHTk6qc8buqql5p7YJEVjeo960Hs/xYoRLJ+TVE1eWDIyoMywV19PYU6JpuH6SoWuSAqTkrYmnGEI3VCFkLCiXvskHluVuAS6muhwixBO8PvO18//y9unUFKyUvnMzHJ0/pigqmeaRlxeGaNprqpxpHsmVBZlaxzxHJJaNoC0lcVxSrH2eY5mywg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(451199015)(54906003)(316002)(110136005)(66946007)(4326008)(76116006)(64756008)(66556008)(66476007)(66446008)(6506007)(5660300002)(186003)(38070700005)(122000001)(71200400001)(2906002)(33656002)(38100700002)(55016003)(52536014)(8676002)(7696005)(86362001)(8936002)(83380400001)(41300700001)(9686003)(107886003)(4744005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m8LNqPzUFsg8qOP0tZr4slv9LJoLbKCDz6JS1iWV4gAhk5SexXEvjUKX3WUB?= =?us-ascii?Q?rUW8He1VmwmzA/vLuMrAMFchSC64MFJFe0VU+2hu2fLESpEjEgmoGI2q43b1?= =?us-ascii?Q?d1O+LEaEEkEK5O0z7ur/ccLhEkjOLduQYIdvb5CtbCoIJAR+XVv1Ge9RGnrW?= =?us-ascii?Q?xJpdU6oUOV/E8SCRkJM7mts9lQPJAiir16oLjZxDzZM2CtD8HRZQx+GjWAtK?= =?us-ascii?Q?OoVK/x20cwtq0+e+YiexHt7euNf4l7gapU/xoEad+wloCOp6DNhOpQFXikGG?= =?us-ascii?Q?r6EZ5+prnRUjVgFn17QcRJoaRKBdWLF2u2VRMChdR1uIZmqUqYL2dusjGb+L?= =?us-ascii?Q?Zt9BOkE3lTU4S1op2SmwTvPhFL5ITGTGyl6RRptFnhM3DlkUUEdIsYaBA74A?= =?us-ascii?Q?fMId3bpW1YJknjvnrDfcM2idi9ymguDC0VagwW8A7EcFebpCC+i1edyEQdhk?= =?us-ascii?Q?71Ss+DJCCqmMKPSZ8xU00T7mMv0PMqnImZYOV2DhAQVh2VaFP+3LXyg7MqWN?= =?us-ascii?Q?bUQmi9z8lUIJpYT4PnEbzAqt0KJBOVSTrF+RwbHcGtpVyRcrnzqhqVoOeDYY?= =?us-ascii?Q?IGVqYFX/BIVHepvVc5cqQnE1FrQybiXOSZeXSl6OxCdVp8QLDHIhYMBK4IIx?= =?us-ascii?Q?REXN7AGMnno6OVNsyHjZpEeOenADIsyZqsNwFo3coEszHHnDcD6f+wJ1oKPO?= =?us-ascii?Q?dGjoSsAL3nkJSaJktZ4NdfC/Ou4sHkxHKrjGFXyta1ahNsdkIpcSpGRr94kF?= =?us-ascii?Q?n4JY96vfUhYndxYKtZAQptzfKQlRoVTSltpCRBtBiq3D8ZqLz6ywwE3SewAt?= =?us-ascii?Q?QxGTaM9ZqpurUBw44obZph8KfOajLnKuHkITZRAAikpiXm8s6INAEiSS9u43?= =?us-ascii?Q?L1C5K4/YKjG9W7TK5SWnKH6CpZsOAM1EftCYwfZHCPbNMXEtnrv5DLfgE47o?= =?us-ascii?Q?wekhIW8eaQGm3oGgq+07a2Pnti/RBvmADi/g2MX0iRYEskOc0R9zaaQjioY9?= =?us-ascii?Q?vWe8WXI6apJDFD868rlF2laI0PZLV9+dECRyeCj4+Z2P2OQD6Dh8BEIn3v03?= =?us-ascii?Q?jtDsQr0b7dJ+uxz11UeH/JlfZNee7NTXulwTRQeUEUiadXbDezsAi0gCBqTf?= =?us-ascii?Q?vXSEUJI0y1BnLtrK+3QIotcnzy7+y2UnqewqpdTQcKFoTkxLElsDivnBdXcG?= =?us-ascii?Q?d4lHR9afJZMzPJXMowmjfD8bpMEzZYQxHNku7JV1AqxvfhuNZLUIwTVmOFRi?= =?us-ascii?Q?Fg02VX0noCUPTuFpL2uE6PL52zUOeYupJVcltLNI/WqMxKRhjChMo62DI0a8?= =?us-ascii?Q?59YwcwH668R6WNET7arrvhiR+AgG0gVKQhOc0n9FGIByOvxyDpFzFv7pGFSl?= =?us-ascii?Q?y52b+RQi/FUOm7E/tEXdRW82UCpbv1eRb5TAmQi+FvAkLqsf6XLTq0c+WB4H?= =?us-ascii?Q?yU7KTgXBYlky9+R3RXTqepL0FGp5hlcBSSAoOjUPMeQTii4dmTnAnBTag7MJ?= =?us-ascii?Q?7nQy7kiLj/4VX9wNUybrvCkN4ybh1/Y0kGvRA0giPjZef+8V5RmZUxuATGez?= =?us-ascii?Q?H9G0vFQa3aifiNA44YhPSU+rJXooberp72zj2J7QDy4Fo2m0NxPt0IKiO+RH?= =?us-ascii?Q?X00mLcxOLFznd3SSWKY3XsNIV2Vzc7V+rOCwSMmp3Pu8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c4886a6-8ed0-4015-1f26-08daba576d05 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2022 09:16:28.0007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 88x8a5MSXWwNcRoPwzouikZ3vr8ud1OVGv3Sz248Duy1r0H7R1ogf9JcFe7hcUSuOpLhOcgyW07rZje4SfQ/Og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6181 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not > explicitly disabled, Meson will read the full recipe of net/mlx5 and will= fail > when accessing a variable from common/mlx5: > drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable > "mlx5_config". >=20 > The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. > The deps array must be defined before stopping, in order to automatically > disable the build of net/mlx5 and print the reason. >=20 > The same protection is applied to other mlx5 drivers, so it will allow us= ing the > variable mlx5_config in future. >=20 > Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") >=20 > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko Acked-by: Matan Azrad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3163A00C2; Sun, 30 Oct 2022 10:16:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D86424282E; Sun, 30 Oct 2022 10:16:41 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2058.outbound.protection.outlook.com [40.107.93.58]) by mails.dpdk.org (Postfix) with ESMTP id 355C34282E for ; Sun, 30 Oct 2022 10:16:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXDzx32NVtPW3G5/bTUZY0ZaIVakefnVrEpShg0k3Bnd5yK43KQwz7LGA0AOxKWCbY+awjmsoBifF2ZclLPyzhhRuL1/0LiEmt3V7lpeT31YsVgl6yl5GIZ2ccqSOb3BASFjB+2ZUOE08RD4qF7eltNxZW1hsTyOdU0BXncIEWIEcN2B39C+NjILkXHW/pybmZCs0tdIK4Q0O/9r5vhzfHw7iYd9AIsRPBBgouw4x25qj+DRobxf1xSxzxJAJhehuT3kXYEdZr983vxiYpG7qFzTaNC0etJAhKdWCXnBE3JQht3pSczNxBOsJsPulQgFsiELXvkiMPxlF4p5+OMB4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PaOmaY56o7lEmByHCFyoSA/IYWY3yzDGXGvWJF1Q/dU=; b=A2+Ja9e1dACXXbaUyKr3UVqPgzdd/r39PAPtOgkLfZSpfzfucMz3+K/xQ/zRKX499FiOtXu4DioCj2Rq3ah+zOq3sc+kZac+0gDNzpYMx+4ryNpLpapEklOwnZEtDsJEwDIou8PvoAV3qxHdS9He19ZMbpzbudv/znJJ+kjksPDopAWJZRTltru8rLSX575hT+nohtwSKX54fVlI1tmZnlriBkn67GcMgJ4cT5vN7YTcqwX/0lFwdcpeMmwCdR9wVDLJbEAlHQC1pxSqj8DHh9TG85/Ea/o6d1khVF7HlPzP+vV44pTJ69TkDO8praMi19ruh3PktPCUa8YbNGBenA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PaOmaY56o7lEmByHCFyoSA/IYWY3yzDGXGvWJF1Q/dU=; b=JXb9QhmytriSsk01X32807WChiDG71Y08bA4QCs4pByL+sw0wdnC9TWV15n3O1MBDyzDdZTQ6kKsUKrBQkAQRxI/hYifOVHwXVmOb2JEMU6O94osfCzJTWwOfRGlpusz79rWclJ1ReixosiKaD47UbkJaj7UnnasrKpqotko04EYnwFxM11ckUygY9Zleex+l1ec+mRVey3dQWwyzYLLVh2CuQwNMIIVyH9B6qkoQudTLRzZw1CzioqS5SC4BICbU2yw0e0uNcgyxpm2Zt3SvZ7/bBUZ8H14vwcorAVGo7CXykAjs8EAJZiQBgtrd+hSpMEiF1Rq3S2a0kHGjgk9Zg== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by DM4PR12MB6181.namprd12.prod.outlook.com (2603:10b6:8:a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.18; Sun, 30 Oct 2022 09:16:39 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2d6:9f4e:4ff7:c45e]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::2d6:9f4e:4ff7:c45e%8]) with mapi id 15.20.5769.018; Sun, 30 Oct 2022 09:16:39 +0000 From: Matan Azrad To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: Alex Vesker , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Raslan Darawsheh , "david.marchand@redhat.com" , Slava Ovsiienko Subject: RE: [PATCH v2 2/2] common/mlx5: move Meson config initialization and check Thread-Topic: [PATCH v2 2/2] common/mlx5: move Meson config initialization and check Thread-Index: AQHY7Dl9ZhLj8m595ECgacH+63j1Wq4mqCKw Date: Sun, 30 Oct 2022 09:16:38 +0000 Message-ID: References: <20221030082722.1333530-1-thomas@monjalon.net> <20221030082722.1333530-3-thomas@monjalon.net> In-Reply-To: <20221030082722.1333530-3-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5389:EE_|DM4PR12MB6181:EE_ x-ms-office365-filtering-correlation-id: 14d32183-0f7a-4207-28b3-08daba577387 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cDKLSL153niOTofsgQHg3dkMDxS0uLy7E/8eYeL0eRL0NBUlkxeyAvezT10tRGUyPBROFe+kfVAJZC1tYg13xg+dsGVT95A0YcZPDsIqaCo955GKZwuPeFJcYcHTdA4ZIJpR/H014DWnCe8/4uWAblVflq1EN5M3u2W+eOGfZO9WQbk7yyhO37kzkumWHUmb1KHgOPx9H0lI3FM9G5XQdo5lLHgUCsphpZ4p7qmd+0ThhbYiL5o1w6uxJocSf0aZfGZdlR+zuoKakSA/eeOFop3yZvp5DCDVfkPYasC9rPFYHpAssj2Odv2fI7+g011wE1q6Xs/MnVunRhQaweV/2W6jAkRZFslvLludtUiQH+KU3Bp0UUlgLTwl0M3xqVzo8Alj/ntD7qLGrwABkmvdft955Kp08yWBOhU5+wgRON9v2RV2CEUmzt2VQ0ROpPoGUqxo+pZFMTpUFezSYLYKKXtaKZDlb+FTv4BqZUUzwKjF1VRyYTxlC7jXSQFMkRZuUxJGQLq8r0MjWp3oHEWzrqVgzU8ku44a3pTz13w6eHnnsUpvH/fNYir/4VCKKIctvV8dzxFpuw6Ck2mrnVY5jFYrVVLNe/FqS7s5Y8MSyxneo1ddbtTfW+Ugg4Z9+uqi0CJGdJZ+2SJt/ZUXzG93/R8LS1mDWKal6bnJyU0vHhC6trlGalGTcI9y0k2RkF1HyjYS/Rx395YnBof3GQQ5dkb0rqfxWDSZG2dFHUYAJlDXYGsHb1ehSRUq2zjv7zFaRWNKA8fJFkW1erygPu9/AQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(451199015)(54906003)(316002)(110136005)(66946007)(4326008)(76116006)(64756008)(66556008)(66476007)(66446008)(6506007)(5660300002)(186003)(38070700005)(122000001)(71200400001)(2906002)(33656002)(38100700002)(55016003)(52536014)(8676002)(7696005)(86362001)(8936002)(41300700001)(9686003)(107886003)(4744005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gXq8A7lcBoazb5DHE2rUvOQxuPplmRJr+zaKGLo6PjehTInPFOknLS8KI7Ay?= =?us-ascii?Q?v3QS9EH9N1CF1LnE1JQUNnAQnXYM5hrwlkZSJHfykkcZyb8r9lcu4nD7ezcO?= =?us-ascii?Q?VJ6sBtEBaMDsvy19evaZkjeDCgb7YMa0qUjSFHNCjxTLmC4MCZOlRLLch5MI?= =?us-ascii?Q?igBsemoMHmlqGkbj9As2SCXGW7Q3g9caDE1V5n3ER3WAhbw66H4hxHpk8wc1?= =?us-ascii?Q?XCkd4sXgdIcNdHr5gAAV13BG5aPrsLHoysW9yRaldyMLQc9o0B/SLDsK/jCp?= =?us-ascii?Q?3OuoHAlmOApu4M5sR9B/z/QDFvAiMHs5nlGyg/tJz2+nfu3P1VOwSVMQMiDN?= =?us-ascii?Q?lDcUqEiPGjqjBQt57Nw1WfelniAg/gL1Rq26XRhiAMV33XEeFDyWql0mvYpi?= =?us-ascii?Q?+hD5pS6LXUXlQlZl83oUaFubA+5gMuf389Dwe9cC6ujl8fF7tLOguyYjJE+S?= =?us-ascii?Q?JVyHpBBxViU/L+EpsyVYjAIMjKK9elVAGEBhWlvDRdcYfjKoUtCajN1sHymf?= =?us-ascii?Q?+nPfMT94p86hmZfVfgf57YarUmHET0G2VxluaN84yhlB3ojCOAgGnB89OEMq?= =?us-ascii?Q?Bkm7I9rLlnKBIVu6kkqziPgnlT1ka8rhrpUaIkLZQp2nKya/iMJ+Oi+ftA5S?= =?us-ascii?Q?he6jpq6U23J6AOOH9Lqh0gSe7JtD9Vt7V0k9BoWkjwSymx6t8t/8BUvPYQbs?= =?us-ascii?Q?7FlKIIFpOYirvtlS914UCMYa7bH7EoukC5xRcFAtPorNtihU3CVRgTEhWJhg?= =?us-ascii?Q?jtNG33xQ6PHMmS3xBBUdDD1W5nrkDJZ/LSO31zj2EQi1pDu62o+WCb5eutZk?= =?us-ascii?Q?jc4Lfs35r+AO1P2UZejp5Y4zUipNYGrS8CPCBqdGZBFlhUVcIiL08npB0pLf?= =?us-ascii?Q?H0nrE8Bc11/b7WVH3JNHuavtgPFXRc6nwiKDpCHtPXq8Zs0HPiS5BEAexPkM?= =?us-ascii?Q?m3s4AyjnZUt3b1BxsTxMy3wHAUoIXC86Oi88KOiuXsONJafArZGgbaiJYXyn?= =?us-ascii?Q?495hdXervjT3SfHshqurHZDCxxkob18+4v0g3T4UbDU8vRxqtSTXLMx46aT/?= =?us-ascii?Q?xyipbfDwYM4TW9S166yVKw9CLIQV7/TBI7RoekkkB2tCWo5u7TjTHX4pRIx6?= =?us-ascii?Q?6m18gMW9WYYKnSAcV1nOIepeM2BXyzNHr9pChAkDrukFxr1zHpxbOPnDon/Z?= =?us-ascii?Q?EZbtsKN6Zmi3/uZCRU3KNxMfBzIvQ2A8d33s9BvdsDjzr3uvu29c69G7k2Ot?= =?us-ascii?Q?QrkxxhOFre9xKoEa9VlWWjbgAidzSQ3t9hs+lDmXufvCI4r3jTEkVl1o3tYw?= =?us-ascii?Q?sRylZXP7JzGA69d3iPlzgiZSK2jBbZY8R3mgquH3bMNf/6Mhfv6/5CVuah5+?= =?us-ascii?Q?h2S+p0p/esNNEe7kznwWic6WIuwjoumFxV38VbDJyXTdFr9+lVooRRMK2Gzr?= =?us-ascii?Q?KpeBvrHgQjy0ik83twdLO45gNCQul9ovBDYj+HdDz8vgHQRN4p4YidK7yAUJ?= =?us-ascii?Q?PpJZwCi8V7FYzk//ReMDDdNQ2AyBJ+t2V9DZ0nCNOx8L5PU6audeK1GpXHIR?= =?us-ascii?Q?GOdTYVHdKSQTTYBH8nFBn6lLgac0STtVrXTnWqu6nP9mr+amjvm80gw7qbFa?= =?us-ascii?Q?jIhB4+dTRXtz6rvhZpaadmhue5MTN3bq/BiqT3Hecr66?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14d32183-0f7a-4207-28b3-08daba577387 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2022 09:16:38.9344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uTbPp4grEYyM/ZBCfAYAj4ErgKDq2g+zDsN0iLKvSKWzx/Kpsen84YqmRyGAdw8S1OMjVt//5GkKPIlugve+fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6181 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > The variable mlx5_config may be used by other mlx5 drivers and should be > always initialized. > By moving its initialization (with configuration file generation), it is = made > consistent for Linux and Windows builds. >=20 > And the check of mlx5_config in net/mlx5 is moved at the top of > net/mlx5/hws/meson.build so HWS requirements are in the right context. >=20 > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko Acked-by: Matan Azrad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2A71A00C2; Sun, 30 Oct 2022 12:09:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77E1A40693; Sun, 30 Oct 2022 12:09:06 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 5794E40151 for ; Sun, 30 Oct 2022 12:09:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AA5215C00DA; Sun, 30 Oct 2022 07:09:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 30 Oct 2022 07:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667128144; x=1667214544; bh=0W G9qaUbjTj+jIdMRX85PztwKftgOsqLyy8hCYGM4eI=; b=yz0O23FjVqC9LJ3P4x x2riMBd4JUvHlqgPjJ6NcMNjCxG/oQXa+3xgpMXJy+Bc4s0cS1y2EYdSGdQykE62 MFMwC9OmE+SnhLOGpdDVNk8iqbWe2aut8OfP48TpBNGuKEQpfDmMVlBAbQxXDLhJ LGoLa8tLEfIz+Qbz5TRKMQSwx9K40PgZfCONLA6e+ZSaPGM9cVw3NEAC6HdRmrmo j7GDgbBIHxqAaLLK4lAs+yTVZm3MFsEi/ZXtZ8KUjBeysBvkbkoLHsvM5JW39s4y bKGxEkbesDSEgiQDylPiIUBpmJEH4ouYU/PRvQu7WZdkzqbUhw4xLwzZXUVvH9pQ yRYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667128144; x=1667214544; bh=0WG9qaUbjTj+j IdMRX85PztwKftgOsqLyy8hCYGM4eI=; b=ZYeaF5/rks1N1xWIeK4xpEkRfTBV5 gBohWm6q0WTQWKx5Vz8W4GqdD3kL3p3GqlP+52q9uoGej6aDDiLZtz9/W/s9qmYM 7Vv2ucuq7kx8cg8Ojs5snwcvMOuCWaGb3PwfWBzmsJwrYhCov+HypRhiub6RrA4z BRzsvRYnWojSXk2R0Rv5T3oeVzUAzzbEEzCVLaU2n6w/LdR98IEoasQTW69g/Y4a WIy4q8WSXp3dHTcXeDim7Wfd3Kx/bm/Kh+ULfiKS1OCX3+u8pfNyqt0ZV2MIqYoH M2B9mBnyMUqeSDpLJiF1r3dR7c/cKHMCHJWOF2FmVIo15yyqPeAEpfngw== X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedruddtgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvjefhudeghedvtdeije eigeetuedugfejueekieeltdfhteevkeehhfeilefhtdenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 07:09:03 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com Subject: [PATCH v3 0/2] fix build disabling common/mlx5 Date: Sun, 30 Oct 2022 12:08:24 +0100 Message-Id: <20221030110827.1994953-1-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Andrew reported a build failure when disabling mlx5 common driver. It is a blocker for -rc2 release. While fixing the use of a variable across mlx5 drivers in first patch, the consistency of its use is improved in a second patch. v2: apply the same protection to other mlx5 drivers v3: fix ibverbs_link=dlopen (include directory was missing) Thomas Monjalon (2): common/mlx5: fix build disabling common/mlx5: move build config initialization and check drivers/common/mlx5/linux/meson.build | 3 +-- drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/windows/meson.build | 4 ---- drivers/compress/mlx5/meson.build | 5 +++++ drivers/crypto/mlx5/meson.build | 5 +++++ drivers/net/mlx5/hws/meson.build | 4 ++++ drivers/net/mlx5/meson.build | 9 ++++++--- drivers/regex/mlx5/meson.build | 5 +++++ drivers/vdpa/mlx5/meson.build | 5 +++++ 9 files changed, 33 insertions(+), 9 deletions(-) -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44B9EA00C2; Sun, 30 Oct 2022 12:09:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3461542B6C; Sun, 30 Oct 2022 12:09:13 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id C5EAF42905 for ; Sun, 30 Oct 2022 12:09:11 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6FF885C00B9; Sun, 30 Oct 2022 07:09:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 30 Oct 2022 07:09:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667128151; x=1667214551; bh=Cu gQIlfbabHdZdi7pVEUW9Q8ebmrFhLdvrcEwjKMX4c=; b=zJAb8sQZ8KkO+aAfgn iNuoj8KuuZiEF84CEuZgo2qx7QlpkEo08Msxt3qkVN5Tc0BUH0JkMY+7RFDUSoFw YZWZMbYDs8G2tM5DLu/zngSO6/MnIcNp0o5+TuIy96G5zoAiF9sx4lgtfEHBmd+N JVITiFl9nspbLwCqg9lpedbsUvt10ikbAckm0PXOm9txiHYSpesSnmMtLg+1kymF Lu2VZ6NILVSz3sE6OBnNH9Tliqc1EmGTp3w9ns+hS7LT4VrC5pWOj67P4Ai+gk1Y 61TP0wNciXcOc/W3/8yB39Fi8i4sayhZE8ohOVLRbh56FFh9jr8cCy9COU7+SA9D eM4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667128151; x=1667214551; bh=CugQIlfbabHdZ di7pVEUW9Q8ebmrFhLdvrcEwjKMX4c=; b=mwCSyaR0PwugpqF36+BpJ2kokWqXI J0KdzWZMADH0OSHep7rX/x/lLrT0a6C/NYHAYaizJ47uaHrkduN4akiEOYzYeHY3 zyzgIBYgUCHOgNaxK/8uOz9m2zAo0Q/D8K4l2NkE642tbPC+DbodCqPQ+tXUlHyc r5zr4prLH9kGQN8CQ2eB3M/Xs3lJmSYNRcMGbjzg1LKS0akYwBoice1tKE3Q7PXt VEQ6MyI44VJqeyD+9GiXWOAvVO97xL8j9D714ObCdBLEafsNrwecYbyP/kNtfO4T Vprtf6sHrLEtFM515F4OOSTYf/zz3Y2JwnzaLed6rVg/u6I4kcEvtu7VQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedruddtgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 07:09:09 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, Matan Azrad , Fan Zhang , Ashish Gupta , Viacheslav Ovsiienko , Ori Kam Subject: [PATCH v3 1/2] common/mlx5: fix build disabling Date: Sun, 30 Oct 2022 12:08:25 +0100 Message-Id: <20221030110827.1994953-2-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221030110827.1994953-1-thomas@monjalon.net> References: <20221030110827.1994953-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not explicitly disabled, Meson will read the full recipe of net/mlx5 and will fail when accessing a variable from common/mlx5: drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config". The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. The deps array must be defined before stopping, in order to automatically disable the build of net/mlx5 and print the reason. The same protection is applied to other mlx5 drivers, so it will allow using the variable mlx5_config in future. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Reported-by: Andrew Rybchenko Signed-off-by: Thomas Monjalon Tested-by: Andrew Rybchenko Reviewed-by: David Marchand Acked-by: Matan Azrad --- drivers/compress/mlx5/meson.build | 5 +++++ drivers/crypto/mlx5/meson.build | 5 +++++ drivers/net/mlx5/meson.build | 5 +++++ drivers/regex/mlx5/meson.build | 5 +++++ drivers/vdpa/mlx5/meson.build | 5 +++++ 5 files changed, 25 insertions(+) diff --git a/drivers/compress/mlx5/meson.build b/drivers/compress/mlx5/meson.build index 7aac329986..49ce3aff46 100644 --- a/drivers/compress/mlx5/meson.build +++ b/drivers/compress/mlx5/meson.build @@ -9,6 +9,11 @@ endif fmt_name = 'mlx5_compress' deps += ['common_mlx5', 'eal', 'compressdev'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_compress.c', ) diff --git a/drivers/crypto/mlx5/meson.build b/drivers/crypto/mlx5/meson.build index 9d9c9c00bc..7521c4c671 100644 --- a/drivers/crypto/mlx5/meson.build +++ b/drivers/crypto/mlx5/meson.build @@ -9,6 +9,11 @@ endif fmt_name = 'mlx5_crypto' deps += ['common_mlx5', 'eal', 'cryptodev'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_crypto.c', 'mlx5_crypto_dek.c', diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index ff84448186..fa15158039 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -9,6 +9,11 @@ if not (is_linux or is_windows) endif deps += ['hash', 'common_mlx5'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + headers = files('rte_pmd_mlx5.h') sources = files( 'mlx5.c', diff --git a/drivers/regex/mlx5/meson.build b/drivers/regex/mlx5/meson.build index e553dcb83d..70edc5b6da 100644 --- a/drivers/regex/mlx5/meson.build +++ b/drivers/regex/mlx5/meson.build @@ -8,6 +8,11 @@ if not is_linux endif deps += ['common_mlx5', 'eal', 'regexdev'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_regex.c', 'mlx5_rxp.c', diff --git a/drivers/vdpa/mlx5/meson.build b/drivers/vdpa/mlx5/meson.build index 9d8dbb1a82..54a4eac6f4 100644 --- a/drivers/vdpa/mlx5/meson.build +++ b/drivers/vdpa/mlx5/meson.build @@ -8,6 +8,11 @@ if not is_linux endif deps += ['hash', 'common_mlx5', 'vhost', 'pci', 'eal', 'sched'] +if not ('mlx5' in common_drivers) + # avoid referencing undefined variables from common/mlx5 + subdir_done() +endif + sources = files( 'mlx5_vdpa.c', 'mlx5_vdpa_mem.c', -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E1D4A00C2; Sun, 30 Oct 2022 12:09:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 322CA42B70; Sun, 30 Oct 2022 12:09:20 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 0BECB42905 for ; Sun, 30 Oct 2022 12:09:18 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BA5B95C00B9; Sun, 30 Oct 2022 07:09:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 30 Oct 2022 07:09:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667128157; x=1667214557; bh=ja VSCHNBCGSydmgD6rSicAwcqkLT8NKAhpR+6+nWhpw=; b=K1A54kSvKkV/okvYdJ MzROFfOBFN7Wyth8LU3xnIfbYYLq3rQvzOu8zp6ID35YGTFy7mXaCD0uMkPABHFK rj/9iJj04rI+dtd2bcGVniuXLGdZ+7/qjCDiYbtR9hrkAwd4m2ciC7FU8uGvGx28 qmmM+WpNMku5cRdJhLqMu4oqdsqMjJt4TaPTkojQdC9TPKJSlNn8VQNzp1cwR3X0 vq6Luw+1QllnXIKA9xPXwo4YGFXqqFAa8fDitY6dpYW5ryK56/T6RNk3x+LXPjFZ QjEfAbLR3IUhLmnPgKl3y6DStI8nb02mEFe8Vtn+ZS2K7fCAR2W/x8YcwRQm6qQ2 ibwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667128157; x=1667214557; bh=jaVSCHNBCGSyd mgD6rSicAwcqkLT8NKAhpR+6+nWhpw=; b=JxwsiRVG5TELZ6pcT2hkJNuBQRnfg kplYhSbN1zynChaYTRd46DHwCAHujPIDS7zH9aNDdlJtOzyWEWC8VHJuepK5taiD r0yQHbAne03LIbjS7WTNar5i66g/b1/a/3LJuwBqLIrwlfLE/TGXnlYIhq+Z+iQD wP+RSeVJsRLVGI0ExmpEjAUiJRp1PIxUshpxoH96t8bKRRDjWFZSg35oYKSX22nw teiBaIvcLVky151dnvC6izeU+8Zoz68XmZTjGZnh6LaT1L1WL+XOlu3YdtLDXwC8 jiz7FwYCZBiQGHMHGwKRNFWlhdwnsO2xumi8ZlrZsJTexpQiyfyZ04ing== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedruddtgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy:

Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 07:09:16 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v3 2/2] common/mlx5: move build config initialization and check Date: Sun, 30 Oct 2022 12:08:26 +0100 Message-Id: <20221030110827.1994953-3-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221030110827.1994953-1-thomas@monjalon.net> References: <20221030110827.1994953-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The variable mlx5_config may be used by other mlx5 drivers and should be always initialized. By moving its initialization (with configuration file generation), it is made consistent for Linux and Windows builds. And the check of mlx5_config in net/mlx5 is moved at the top of net/mlx5/hws/meson.build so HWS requirements are in the right context. Signed-off-by: Thomas Monjalon Tested-by: Andrew Rybchenko Reviewed-by: David Marchand Acked-by: Matan Azrad --- drivers/common/mlx5/linux/meson.build | 3 +-- drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/windows/meson.build | 4 ---- drivers/net/mlx5/hws/meson.build | 4 ++++ drivers/net/mlx5/meson.build | 4 +--- 5 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build index 84e2a1ad8c..7e1575efc8 100644 --- a/drivers/common/mlx5/linux/meson.build +++ b/drivers/common/mlx5/linux/meson.build @@ -8,7 +8,6 @@ dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE = 'librte_common_mlx5_glue.so' LIB_GLUE_VERSION = abi_version LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION -mlx5_config = configuration_data() if dlopen_ibverbs dpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1) cflags += [ @@ -232,7 +231,6 @@ foreach arg:has_member_args file_prefix = '#include <' + arg[1] + '>' mlx5_config.set(arg[0], cc.has_member(arg[2], arg[3], prefix : file_prefix, dependencies: libs)) endforeach -configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config) # Build Glue Library if dlopen_ibverbs @@ -243,6 +241,7 @@ if dlopen_ibverbs dlopen_install_dir = [ eal_pmd_path + '-glue' ] dlopen_includes = [global_inc] dlopen_includes += include_directories('../../../../lib/eal/include/generic') + dlopen_includes += include_directories('..') shared_lib = shared_library( dlopen_lib_name, dlopen_sources, diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build index 6ddbde7e8f..60ccd95cbc 100644 --- a/drivers/common/mlx5/meson.build +++ b/drivers/common/mlx5/meson.build @@ -37,4 +37,6 @@ else cflags += [ '-UPEDANTIC' ] endif +mlx5_config = configuration_data() subdir(exec_env) +configure_file(output: 'mlx5_autoconf.h', configuration: mlx5_config) diff --git a/drivers/common/mlx5/windows/meson.build b/drivers/common/mlx5/windows/meson.build index edbbaa9ae1..cc486014a8 100644 --- a/drivers/common/mlx5/windows/meson.build +++ b/drivers/common/mlx5/windows/meson.build @@ -39,7 +39,3 @@ if get_option('buildtype').contains('debug') else cflags += [ '-UPEDANTIC' ] endif - -# Generate an empty mlx5_autoconf.h file for compatibility with Linux -config = configuration_data() -configure_file(output : 'mlx5_autoconf.h', configuration : config) diff --git a/drivers/net/mlx5/hws/meson.build b/drivers/net/mlx5/hws/meson.build index d2bb864fd2..38776d5163 100644 --- a/drivers/net/mlx5/hws/meson.build +++ b/drivers/net/mlx5/hws/meson.build @@ -1,6 +1,10 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 NVIDIA Corporation & Affiliates +if not (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) + subdir_done() +endif + includes += include_directories('.') sources += files( 'mlx5dr_context.c', diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index fa15158039..f1aab18f82 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -78,6 +78,4 @@ testpmd_sources += files('mlx5_testpmd.c') subdir(exec_env) -if (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) - subdir('hws') -endif +subdir('hws') -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A56AAA00C2; Sun, 30 Oct 2022 14:34:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4844A40693; Sun, 30 Oct 2022 14:34:01 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by mails.dpdk.org (Postfix) with ESMTP id 6FDF340151 for ; Sun, 30 Oct 2022 14:33:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IrwtLKjFjae30vAziGDMwOionVQhwUQcWEQ9mdjZGpdXbRAQDzR7ksKfDErtwgX6uHniTSlFrxYeJCwAIMkVGrtVdjNp7mftYvta3aEvksIM7jiLd7Mgzrkc9IcCDFOWAXzgXlYWJafK94nArpCzRn4xMxVb8NdI7tqOJnJA3yYjcojR68mbiNPkoLXLI8HcZW2TdiiIJg6ObV0gHpqDzxf+hjPV8ckP5ixx6ijn/xTIJMTjvFZcOXonohcl8RXNAVxVoPwrzVsOhHc2vasm7GLy1IQxeIPiRuJoMrAiiNOBECZ5ofVxp3W8tfMiNklQByvUt0I4B92yAjueWLreXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m3yxh7peRZmL9GdhjhWIyiYm7o/Q3JPNofEMNqoDLGc=; b=gyFhq0VvDqOmtg7KxxsXXHrMmOBUgn4dp87TtFWMBvF/b/jixugyh4Ep4pMwI8S9WnmSFe39J8nfuHbZmC6xxo7OmRwC3+YfDaHJD/yqU58Zsn+tuVLj2tyyaxc/JjFOp9At2sHKi17TE1pIncCF6w78CJMUBrD9XRkPCis9xTemYVDwdyWOMZsD8HmXOSu7VSU5VVm4ti/ppWhKCd7nmbzjE56yVVD7Ks36Gua6/e4dOwbDgFVhPjns9rkRJGv9RlYxWiESPGcvHbkTGcD9XkVsg8ChaAzuZNOEMkxTRKv+2KXjCdtByvbS7UEuCZ6GSQAqYNMiDvI4PSxBqRBUsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m3yxh7peRZmL9GdhjhWIyiYm7o/Q3JPNofEMNqoDLGc=; b=h86hrGPdz2pUk0YyPTlWnzRT3Y/D/C4Gxu1g3oZY0r+vFv1Y34sZud3jsfBOSP+q1K54fY/WqFPgIcOVPPkyvZyklCVaxKlKInyvmqCXqO+7w8PLP+ta+5rOvVBiURAv3qBsr0cAZVBvK+KD2bjC4/7mwo7OATRMiIzjfe0Km7jXaqBhwKscqs95Jk+8Wx8aWfaJP8IPm5C1EaGwvtQOcWCURL8v0Snle6HchgNZdnT4ieiKwzZfEP2xWdaHMy421F+72qgdEIMdz1JTpW52GhXy3dBx1Awb85E85/dbI6o5rUnHNPvCZRy4Lb7k7+9xZidbJbYY6xP3ilqvpgrLZQ== Received: from DM4PR12MB5150.namprd12.prod.outlook.com (2603:10b6:5:391::23) by CY8PR12MB7561.namprd12.prod.outlook.com (2603:10b6:930:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Sun, 30 Oct 2022 13:33:56 +0000 Received: from DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883]) by DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883%9]) with mapi id 15.20.5769.019; Sun, 30 Oct 2022 13:33:56 +0000 From: Alex Vesker To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Raslan Darawsheh , "david.marchand@redhat.com" , Matan Azrad , Fan Zhang , Ashish Gupta , Slava Ovsiienko , Ori Kam Subject: RE: [PATCH v3 1/2] common/mlx5: fix build disabling Thread-Topic: [PATCH v3 1/2] common/mlx5: fix build disabling Thread-Index: AQHY7FAMbL8HjoaoskOjTvefoAzWwa4m78Pw Date: Sun, 30 Oct 2022 13:33:56 +0000 Message-ID: References: <20221030110827.1994953-1-thomas@monjalon.net> <20221030110827.1994953-2-thomas@monjalon.net> In-Reply-To: <20221030110827.1994953-2-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5150:EE_|CY8PR12MB7561:EE_ x-ms-office365-filtering-correlation-id: e0eb1146-8f0a-4a41-2bac-08daba7b6522 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 31RVNtDBRh6oaRe27vvH1Mmef1yJL0Sam5sUVVKj/MtWi5oxts7wOxaTgTK5bF3Y8hGBY9p/XlSTfDK6M6DupIusbnI+xexuIyb0yFepCN1g8PUb0qFuwdWH3Jw5g8gokmV6kAHYC/dma0oz96VAyobsXGKlr4MfgFFGiSTDMFA33P6cCiDq0VVBSuKIxGbk/nOp/5HJFmf+RaJP5NddtuTdnV9hPYcTQ8HziHjCoLdriysDi/Ha22VneB14swjLOTXQeWXd+B4NSawXI2o/cph2M0tUGGaCsQSa4YIkrzTrIPhqskv8cMqE+jzHJRrO1r0XtdQsRPYftx+Cuows0KDoEWv8xaRYFrYM14uIQYj//KTZB7JX2Y5VlgwYhgcOevMLCVrFjzTiWxujwgjWMIlDlZnpjlb4Hau6pw6uIlFuWUyg29vopasYfrJpxxQlWW9wNZtbp17l6K2tjo40JlseL5K7M/yflm/FCe04/QHDBhU6n+nDFsL4vHgmEgl546FIyndUjIb31xa2zcvhzyQ3N5mCIEDkjElc5Enbdj8gb/xvJ67NccGVOWech/4meiPiSn1gtu7PkziSuHy+WyPadpZ1c7aDOhpEnGCnf5bmCKqUtkEOlzNpNDjj5elui+toXyFlYDglP81onGe5mQ1UvSvld6if4kzrJ9lqJbMawjupozhnqhH+VfB7aW9lZ9jJCenKTPnhVjlcfe+3hWXjPPvkZ8vsSjOR2harLXzjxAPx93k1hdEnukwkIoGSY5xYdENeHTSz+Lavl3/rTQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5150.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(83380400001)(55016003)(2906002)(54906003)(86362001)(38070700005)(5660300002)(38100700002)(52536014)(122000001)(186003)(8936002)(8676002)(66946007)(478600001)(9686003)(7696005)(6506007)(64756008)(41300700001)(66476007)(66556008)(33656002)(71200400001)(110136005)(107886003)(53546011)(76116006)(316002)(4326008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VF6rEg6PfPpEXamEZqJfgajzDtNQdNGrDdTE6zQRhYVma67B0uBmtVgruOIq?= =?us-ascii?Q?Y7OW9zN5xJyRhotLJyrle9VGHJbBTVE9Q+fjrKGT76/nQG4lMjIrfs89o468?= =?us-ascii?Q?w5neBuhiaORyw4KrNudmwSlAcT4iqOUlYU03tybkJcMeUxxyinJ9ubCtiLh9?= =?us-ascii?Q?gQphVY1rWqsR2EwPEVtq/v3IpaEYl4Al2gjrG/w6H7zSabE3U89ztgWnoWdC?= =?us-ascii?Q?erSa95miz8cVOpGNqTXpbJSo0h6uK4vRO/oNt3y1fOYEwLJw8jNu45BvYvmA?= =?us-ascii?Q?WTz/eIfF7gMP+J+dM3cnpLjDGzsEyqEWXIHm5FRi0K//T81L67IAeBJ0bed/?= =?us-ascii?Q?ZFb/oQdU+gE9LwE3KFh0Y7xl03C7dxKk0SgWSGrzfAyrRY4/wSJmWgiQk7/g?= =?us-ascii?Q?Je1NFauSzJyqBqXG7wyCQHua5EzEO9M0Mm8bzkcIjWfbKhyYmtr8kaLWxZGA?= =?us-ascii?Q?x5WnNKiG0wj1tevzfYIaDMq/MzyYdp/hmpn1D2oc6Pma8AmB4HxME3zRoh3M?= =?us-ascii?Q?mWSdMEAouZHaU/NXemkSxwMF/BC7dKvRn/sC+nO0Tv004ioJlaMFQnfMHpQM?= =?us-ascii?Q?QtV4kdcVN4o5sfb2idsXnQ/iI7VWdEHO91YMITHLb30azx3t+QXx12cFdIub?= =?us-ascii?Q?r7YuHGgfbhqZpbs1d/8+pqn3RP8G7P6nyR6lrSUPPU78KUDpKE5xX7Lv9ENB?= =?us-ascii?Q?vDkASI7XbV9q/D+AVnlYRhwlRONF2cSE42uuQw9Il4W59QY2MK/tz/MiUfpB?= =?us-ascii?Q?HNypRc4f//HYQjrLrNlX4CZSut6t3Nzr4tnS5pGnlGSDZ9YZzSRyV+bwmJKd?= =?us-ascii?Q?djrTZ5ReyGYgb/+PQL66N3Iv3ef8uhRaCpTj0T+bY8W9WVkY2lQXuCyMa4bX?= =?us-ascii?Q?fxYPS076/SP6cE+K2E03AmIST4d0rXQiGPkKpDpYJVjz1kmJfT3jS7kCQ/ji?= =?us-ascii?Q?vcPnnP2dJBeMEAgBThyD5L63M0b+8EX3AugHBGpx44uGoRnbW8fSWjTZJVr9?= =?us-ascii?Q?QmhsaqzkqdNXN8pdAEqWqABvD8gOl8Y9ZLAGgFTBU5Qs70kpFcjWJUuVV8P8?= =?us-ascii?Q?ZtOzXvSgY2Yvpu5TTHDRtwUJZHKdX4E8U0Ym8ZL7+77Wc42yKqidB1WjYfkn?= =?us-ascii?Q?3ogtaPQR4iedNvZ2ELtxJ7aczk4murri3L+Mpsdjn1VFP7qOc+o02pI8KJkW?= =?us-ascii?Q?6nAud5vGIjry2x+kJWOwtOOAVvHBPReL/xOba/j3f/eKTG1sLqfWyiDpHCBh?= =?us-ascii?Q?QqGSGU6w0Fy51sChR1LqYaP3mtPVeO3klx9TYdi4CFY2ykZLbvNFBBEn1Aso?= =?us-ascii?Q?/V9xBq4X9EVxa6ED/tevisn1/EPHW8y9/pz4Qa6kB6+/fszBMdx0DK1dGoV+?= =?us-ascii?Q?qA4bd4y+y+gOMgTwJlJXT3yNaFQTViSg4nO3Nl95OgiPrqSZmMmEzaAuGEV7?= =?us-ascii?Q?QTemQWhuUDD33GcI8f3aLU7V9BCy8RZO0KRS0k8ROmTD511taAUdUn8y7QUS?= =?us-ascii?Q?T2+IahoEHDhp9T+AA50OQXIjDVYZg4jkloSgWC4dyjwO0u7nVImwC1u/evuV?= =?us-ascii?Q?MRIKwD+Z+rWvjfFSqL26EawH/+WMPGE0AkRezc8YuKQqXxPhRn9CUhtS4C58?= =?us-ascii?Q?MeL4Zcq7l/WZayQ7/A/eg6cGmqdhvM3FX8v9HJFGLYz7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5150.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0eb1146-8f0a-4a41-2bac-08daba7b6522 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2022 13:33:56.6515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aKcN1wWfhX83aDOBNrokusXiMEQIZLDVYatfMJqy0DTBD2qaEhFON0UrSmuI7wmHltoimuROxKTF0HgWMKIvtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7561 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, October 30, 2022 1:08 PM > To: dev@dpdk.org > Cc: Alex Vesker ; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Raslan Darawsheh ; > david.marchand@redhat.com; Matan Azrad ; Fan > Zhang ; Ashish Gupta > ; Slava Ovsiienko ; > Ori Kam > Subject: [PATCH v3 1/2] common/mlx5: fix build disabling >=20 > If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not > explicitly disabled, Meson will read the full recipe of net/mlx5 and will= fail > when accessing a variable from common/mlx5: > drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable > "mlx5_config". >=20 > The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. > The deps array must be defined before stopping, in order to automatically > disable the build of net/mlx5 and print the reason. >=20 > The same protection is applied to other mlx5 drivers, so it will allow us= ing the > variable mlx5_config in future. >=20 > Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") >=20 > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko > Reviewed-by: David Marchand > Acked-by: Matan Azrad > --- > drivers/compress/mlx5/meson.build | 5 +++++ > drivers/crypto/mlx5/meson.build | 5 +++++ > drivers/net/mlx5/meson.build | 5 +++++ > drivers/regex/mlx5/meson.build | 5 +++++ > drivers/vdpa/mlx5/meson.build | 5 +++++ > 5 files changed, 25 insertions(+) >=20 > diff --git a/drivers/compress/mlx5/meson.build > b/drivers/compress/mlx5/meson.build > index 7aac329986..49ce3aff46 100644 > --- a/drivers/compress/mlx5/meson.build > +++ b/drivers/compress/mlx5/meson.build > @@ -9,6 +9,11 @@ endif >=20 > fmt_name =3D 'mlx5_compress' > deps +=3D ['common_mlx5', 'eal', 'compressdev'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_compress.c', > ) > diff --git a/drivers/crypto/mlx5/meson.build > b/drivers/crypto/mlx5/meson.build index 9d9c9c00bc..7521c4c671 100644 > --- a/drivers/crypto/mlx5/meson.build > +++ b/drivers/crypto/mlx5/meson.build > @@ -9,6 +9,11 @@ endif >=20 > fmt_name =3D 'mlx5_crypto' > deps +=3D ['common_mlx5', 'eal', 'cryptodev'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_crypto.c', > 'mlx5_crypto_dek.c', > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index ff84448186..fa15158039 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -9,6 +9,11 @@ if not (is_linux or is_windows) endif >=20 > deps +=3D ['hash', 'common_mlx5'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > headers =3D files('rte_pmd_mlx5.h') > sources =3D files( > 'mlx5.c', > diff --git a/drivers/regex/mlx5/meson.build > b/drivers/regex/mlx5/meson.build index e553dcb83d..70edc5b6da 100644 > --- a/drivers/regex/mlx5/meson.build > +++ b/drivers/regex/mlx5/meson.build > @@ -8,6 +8,11 @@ if not is_linux > endif >=20 > deps +=3D ['common_mlx5', 'eal', 'regexdev'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_regex.c', > 'mlx5_rxp.c', > diff --git a/drivers/vdpa/mlx5/meson.build > b/drivers/vdpa/mlx5/meson.build index 9d8dbb1a82..54a4eac6f4 100644 > --- a/drivers/vdpa/mlx5/meson.build > +++ b/drivers/vdpa/mlx5/meson.build > @@ -8,6 +8,11 @@ if not is_linux > endif >=20 > deps +=3D ['hash', 'common_mlx5', 'vhost', 'pci', 'eal', 'sched'] > +if not ('mlx5' in common_drivers) > + # avoid referencing undefined variables from common/mlx5 > + subdir_done() > +endif > + > sources =3D files( > 'mlx5_vdpa.c', > 'mlx5_vdpa_mem.c', > -- > 2.36.1 Acked-by: Alex Vesker From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6589A00C2; Sun, 30 Oct 2022 14:34:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A796242B72; Sun, 30 Oct 2022 14:34:13 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by mails.dpdk.org (Postfix) with ESMTP id 48AE642B70 for ; Sun, 30 Oct 2022 14:34:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ew8V991c7V+oj59ImviEsMQKugWXJiuxh/PEBnKV9QnzwtTeO9MAv+1i+ZB+mHwLNLybZKIB4v04ZHbxpp2NDHkEs/WMYJe87QOisX/MjYu5HC+weP4kbB0MkxD2eCFSpaOg5+Dkoj0lkVAPob/WlDSrHpvFOzULPH1mm5fBurH69BxU+ChO2vvBzYs+9P2fP+k/NMRJB75IFFz00wwUZfOxyz0jKyS5/6ylRRjOXhfNDkKSZeJSZCnPJ2nG17SUg15GOfelZRzRH4+9I2n+lDpKeOlOfuoXJpDvmGRO974rHL/1SpBWw/KhlvkE56ohNlqxqCT+WCVPjTkupA3thw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hAm724J0HbJGN24KjSLzX/HVRJs7HUO+vKsO9rNVUqs=; b=KPQtsElmAFRWB4Y9bUha7IFe3zMqzTLveLKAFa2cjfmvHNGa3uPnr2MBAEfmaairFQ6nwzBY1Pb7mfFtIYqjNc4jhgrdrs5Lj860ZpR6hlS6xHg+gVyNXNRM+koBr/msizhiCrN3TBkHMEGIEQBkD7Sf60qvw33E7IcLNfcMaz+Mfmyr2wMyzZ5mXnV9evIcekzR7cdlgjZd5jwL//YX1QwiHXE264R+UyAAORWy5KEUEXByWGfZgrvqL2IXSwdoyBS7nR3S/YGG393GFopJwVf8uir0SuuLWSx18ZRLAL12YOSXxMsGdipj/dQkYMvzxREsQg0UdvE7NEvY9+g4QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hAm724J0HbJGN24KjSLzX/HVRJs7HUO+vKsO9rNVUqs=; b=MPtHWV5/eZTtpNLi/BQiYdQGCWwueY5xMSbtrzUOP+Oh2YpHAC84advu5j/5KBcZiFKEoDKivgRcQL6+O9APN1jBHu4kfMLGTu4AkYI8KjZFBxjY7EFw53Rb9htzP2SekrILgEkStbHUa8EYs2+Jdnz99Hqo7iNSvWZ2L/dJjbw13FmYBQAVzmKpUV0zR+8rCCbgEW0gYnwTXaLpB2DfyXkbZaEiLQCOzViRENkx9iTZGL0ZOk2ycd9wooCg+SIdBY7X6mstG0NXuJkpj+hFdoNNfv+wvkGMklKAiCJOcBrn5UfCwDHO3LuvPuoPBhC8kV7isKl4pR/TWSn+blzZNQ== Received: from DM4PR12MB5150.namprd12.prod.outlook.com (2603:10b6:5:391::23) by CY8PR12MB7561.namprd12.prod.outlook.com (2603:10b6:930:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Sun, 30 Oct 2022 13:34:09 +0000 Received: from DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883]) by DM4PR12MB5150.namprd12.prod.outlook.com ([fe80::67b0:c86d:6345:c883%9]) with mapi id 15.20.5769.019; Sun, 30 Oct 2022 13:34:09 +0000 From: Alex Vesker To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Raslan Darawsheh , "david.marchand@redhat.com" , Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH v3 2/2] common/mlx5: move build config initialization and check Thread-Topic: [PATCH v3 2/2] common/mlx5: move build config initialization and check Thread-Index: AQHY7FAPungzXko1wEmL+W/YC590BK4m7+cw Date: Sun, 30 Oct 2022 13:34:09 +0000 Message-ID: References: <20221030110827.1994953-1-thomas@monjalon.net> <20221030110827.1994953-3-thomas@monjalon.net> In-Reply-To: <20221030110827.1994953-3-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5150:EE_|CY8PR12MB7561:EE_ x-ms-office365-filtering-correlation-id: 0275dc57-179a-4a06-cc1b-08daba7b6cb9 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3+03YGcY/yjFLAR49sLBEpyRkvBpLGGKfmPBUNL8qQxUJeYU/caM0kSyh4l1nG6pfXsNVUOG8oN9r8zFUW/MlGqA6J8NAsxOVnhxE47GztbStusmpd7OfCOVL20erNIbmaGnKR6on4FfTXCA9F+IhP3ShRXvBpYeM7uTDvFU21d1zgD8aGySXHnG3Zb/464/XSJ0e5pnnG0zfnPBwzNVUPikuTnkVaAL499CVczhw6AIgZtmeH65ufyXPAoEFPxmuZA6yp1F9RH5qck2z9Ty1e829wHPWCH6nvZDFFPAM3OlxAVdKMZFfejU7fXp6ZUv5CWO14Myxs5V6bglWIjJU3E9GUikTTYzKhmh58sDjuwe4UELVWdP/aVWzzvjE5iPMjpjBG38k7Dkt7mDHRVc7FQNyE0BQqVtwWHCvtNw1mV29HvUcVDMD1QtnYOc4rf2xIga0CXoi9m1JRelHM9VY/WB94VMviDKdEWOo35UZ5pIm1ldO1n12GX0lKqejwzpC9HwkfXTSQdi40rmJYVKVTOE8/+oXUmVQRR0SST1VRTEGJZexDswdyY7JEtsdVTd9/qj6HKIuNN4VsJdsVnA3em5IJgfFLIMINTmlylzg7HoDJnSfWX2KKwTZrR/L466PijHvFzy2TmVB+yHb7m8UNiekd2UBv+QXCJXvPxh0eI/lfHjRaJ7F/YRueQe1qgOlQGBc6mp0t/sywNzmsAfi2vumPe+Wd3k6JuUHaNazpftiXKxamboWCGBw59XMdmqkJrGeybvXUvk5BlbTmM/+A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5150.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(83380400001)(55016003)(2906002)(54906003)(86362001)(38070700005)(5660300002)(38100700002)(52536014)(122000001)(186003)(8936002)(8676002)(66946007)(478600001)(9686003)(7696005)(6506007)(64756008)(41300700001)(66476007)(66556008)(33656002)(71200400001)(110136005)(107886003)(53546011)(76116006)(316002)(4326008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YPrc7jK4zz7TRycM0/bIDUib/D00xb5XHxRH+Mo2Qb+M7FQXftCLw2oZ3p8V?= =?us-ascii?Q?BKl7eyIuTRj5ERXzqlL80rgzWr8bFZ6tIA2D+QViIHYDlqpPibcB8ULBV1MA?= =?us-ascii?Q?KzYqLp71QbTvxP7QZIKjEs1laanPo2ayfzlQwLZ8u0+IPuK4kztI3uvoIg9e?= =?us-ascii?Q?MhwEH84b7YPv5S0yJefgy1KPmJHekI6u2KOp3VPPUcw7Blmrzdu4oUysU7an?= =?us-ascii?Q?+GlEiJgJStTLBj1HQVT0PuB9Eg3UiaTlTQu/IamybVL9ZU2Y1fSVwruQ1FIV?= =?us-ascii?Q?uiTTQDpkzhUtsFEHNmZi+7jTUm8E5gyrpZYeXCkmLRKLHy9AzsAZoQ33+NzG?= =?us-ascii?Q?/gWLl5kP1XtZxZl5tn4gtNr96Iy5A9o/fx4FZhE7rrNQP1quwc7W7BHW8+HA?= =?us-ascii?Q?/M8o/eN7tCucmplYBcNcIMNublXVlC/XVCm/WN2hHkNKTERLXt15TKsLXdTA?= =?us-ascii?Q?O5IHtSQBOVrr+YWMPFoEjEeFD8UJ8bgoSi+QLISEQ6ksf86e0ntpOx/FXKvQ?= =?us-ascii?Q?ppCWY9ZOlqt639/ogkCq0TmbAPzFkPlMVBg704f454+eZVvwc+l5a+QSRrJP?= =?us-ascii?Q?+3PlPYBtjfX4eQzJccSP2knrBdqDkRgcgFi9zaFcVx0DigUBlxacrLH4RlfF?= =?us-ascii?Q?XsqUzaWnKDF+9GxIy1M9swCaEuJY/VDrU8uEOFOiOgpJSuhpiJeUUYPjRtjt?= =?us-ascii?Q?7uEzYQF8tfu+41LxKX9YoGHzroVW4Sy+gmsgH9AOmaJSGO5OZ8lgKRMEGNP9?= =?us-ascii?Q?ZwtDK22eOed+kQuNNVOf1/ysy+eDLxDvkp5SJnRsAKxVEBZY/K4wk7Y23ASa?= =?us-ascii?Q?SlrtRzduBhupmEt07DvXMIy2rPsYQ+TRzCKpJ2leg5FIuCo0gtvDtGv/Duyd?= =?us-ascii?Q?pubBBPOcx8VA5AqYnzaG7yn5sBLHDYsu1JS96jSsRA5pvGm8k7g0QWEKfyYn?= =?us-ascii?Q?8RJBiEamfZOwMlPRnuwieMEzbKnr8KI+EW7/OGmpIg1bDwXwAIgttsF8heph?= =?us-ascii?Q?GmdWgvkilj357axF3XTRT7/H4goQcfavthVpZ6VOXDt5HWznkri7VAqEoMWt?= =?us-ascii?Q?gziBOdhD4deFP7hhHRLzF9dUTy+dKCnuafg/Bd5bsts9BXNo9TNVmlyM6Q6i?= =?us-ascii?Q?QyH+AFvhuiw4vOvmwEfp3vm8w8auGXsuIW2Y+yXcMv9U2AOxx3SAoZ0mGq03?= =?us-ascii?Q?YsIfJ/Xc4k/pM8lcyW+y/LShsvL+MDsr2LoWwX0zvdBXv1PqmVDeK5alvvPI?= =?us-ascii?Q?BJMKBdqALefYw8KU6bUnSBScDOkzvarHSRM6ql7RQkPc/FM3SE6jjoRsE3iy?= =?us-ascii?Q?xVYao2lOjcFxaHNkQTkRzDTQ5hUdGKfoX6f/jC9AADje6pOQo/D7+A1CbLl7?= =?us-ascii?Q?nMYXeAhgK5YcXKqXMWM6m0bi72Kgvh4K5Fuuc7O2hS3tjzMIjV0hZ9tZwiM9?= =?us-ascii?Q?sggIDvfbFPiTPBK8+dd3G5ZpomtzyXH4KxiubR+qNehV07xfzgWr6maXftzF?= =?us-ascii?Q?FGDE+OeansNQiAeCh5sorbEUxi95R+6PXpPyyt2upO9NpnSaNpevda9zH7DP?= =?us-ascii?Q?A3D5hezZdukBYBU0d7ltOiR9OZ/RknAlNO9ww3dfcqMzNKrIYY+YwSin781D?= =?us-ascii?Q?jonCmP0jansj+ZWaolEr5unXufaolb13WhB3MoovXkJx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5150.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0275dc57-179a-4a06-cc1b-08daba7b6cb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2022 13:34:09.3893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IzQb8P5LbvdakfMJNU/TijZ2nVsIwllof8dfrmL53KdKS+MBh7Hbv23rtphJaeh/Bk4MzGKBKaTsxIBvTHFbkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7561 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, October 30, 2022 1:08 PM > To: dev@dpdk.org > Cc: Alex Vesker ; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Raslan Darawsheh ; > david.marchand@redhat.com; Matan Azrad ; Slava > Ovsiienko > Subject: [PATCH v3 2/2] common/mlx5: move build config initialization and > check >=20 > The variable mlx5_config may be used by other mlx5 drivers and should be > always initialized. > By moving its initialization (with configuration file generation), it is = made > consistent for Linux and Windows builds. >=20 > And the check of mlx5_config in net/mlx5 is moved at the top of > net/mlx5/hws/meson.build so HWS requirements are in the right context. >=20 > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko > Reviewed-by: David Marchand > Acked-by: Matan Azrad > --- > drivers/common/mlx5/linux/meson.build | 3 +-- > drivers/common/mlx5/meson.build | 2 ++ > drivers/common/mlx5/windows/meson.build | 4 ---- > drivers/net/mlx5/hws/meson.build | 4 ++++ > drivers/net/mlx5/meson.build | 4 +--- > 5 files changed, 8 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/common/mlx5/linux/meson.build > b/drivers/common/mlx5/linux/meson.build > index 84e2a1ad8c..7e1575efc8 100644 > --- a/drivers/common/mlx5/linux/meson.build > +++ b/drivers/common/mlx5/linux/meson.build > @@ -8,7 +8,6 @@ dlopen_ibverbs =3D (get_option('ibverbs_link') =3D=3D 'dl= open') > LIB_GLUE_BASE =3D 'librte_common_mlx5_glue.so' > LIB_GLUE_VERSION =3D abi_version > LIB_GLUE =3D LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION -mlx5_config =3D > configuration_data() if dlopen_ibverbs > dpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1) > cflags +=3D [ > @@ -232,7 +231,6 @@ foreach arg:has_member_args > file_prefix =3D '#include <' + arg[1] + '>' > mlx5_config.set(arg[0], cc.has_member(arg[2], arg[3], prefix : file_= prefix, > dependencies: libs)) endforeach -configure_file(output : 'mlx5_autoconf.= h', > configuration : mlx5_config) >=20 > # Build Glue Library > if dlopen_ibverbs > @@ -243,6 +241,7 @@ if dlopen_ibverbs > dlopen_install_dir =3D [ eal_pmd_path + '-glue' ] > dlopen_includes =3D [global_inc] > dlopen_includes +=3D include_directories('../../../../lib/eal/includ= e/generic') > + dlopen_includes +=3D include_directories('..') > shared_lib =3D shared_library( > dlopen_lib_name, > dlopen_sources, > diff --git a/drivers/common/mlx5/meson.build > b/drivers/common/mlx5/meson.build index 6ddbde7e8f..60ccd95cbc > 100644 > --- a/drivers/common/mlx5/meson.build > +++ b/drivers/common/mlx5/meson.build > @@ -37,4 +37,6 @@ else > cflags +=3D [ '-UPEDANTIC' ] > endif >=20 > +mlx5_config =3D configuration_data() > subdir(exec_env) > +configure_file(output: 'mlx5_autoconf.h', configuration: mlx5_config) > diff --git a/drivers/common/mlx5/windows/meson.build > b/drivers/common/mlx5/windows/meson.build > index edbbaa9ae1..cc486014a8 100644 > --- a/drivers/common/mlx5/windows/meson.build > +++ b/drivers/common/mlx5/windows/meson.build > @@ -39,7 +39,3 @@ if get_option('buildtype').contains('debug') > else > cflags +=3D [ '-UPEDANTIC' ] > endif > - > -# Generate an empty mlx5_autoconf.h file for compatibility with Linux - > config =3D configuration_data() -configure_file(output : 'mlx5_autoconf.h= ', > configuration : config) diff --git a/drivers/net/mlx5/hws/meson.build > b/drivers/net/mlx5/hws/meson.build > index d2bb864fd2..38776d5163 100644 > --- a/drivers/net/mlx5/hws/meson.build > +++ b/drivers/net/mlx5/hws/meson.build > @@ -1,6 +1,10 @@ > # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 NVIDIA > Corporation & Affiliates >=20 > +if not (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) > + subdir_done() > +endif > + > includes +=3D include_directories('.') > sources +=3D files( > 'mlx5dr_context.c', > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index fa15158039..f1aab18f82 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -78,6 +78,4 @@ testpmd_sources +=3D files('mlx5_testpmd.c') >=20 > subdir(exec_env) >=20 > -if (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false)) > - subdir('hws') > -endif > +subdir('hws') > -- > 2.36.1 Acked-by: Alex Vesker From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ABEFA00C2; Sun, 30 Oct 2022 16:12:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB19940693; Sun, 30 Oct 2022 16:12:21 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C464740151 for ; Sun, 30 Oct 2022 16:12:20 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BB9395C00A1; Sun, 30 Oct 2022 11:12:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 30 Oct 2022 11:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667142737; x= 1667229137; bh=bDpmNKR08pk7IT0tQwbrl17YaMrbX3zUohYMFTexl/w=; b=m edqMrjPiMi7F7M4eTAJnR3ARMw6K72Opqft8WVrRfiQFeHBeHA1+SId/ypxVZDz+ 0cRPl0fnmilO+IIGPoK01wYhrSV8JFsQ8OPMd7GXifGXL8Xd/cCUB7AospTLcKCX EbVXMVXFkJA4fyblgNM+9VQsneTISLuNc3SBK6QwmAJTGucqTt1PXw3ML9W3c1r7 RRd2bnyMgv2FHa08DH+vR/xtN9I4oI8lK/C2fFwIjPwd5Qv4Gg9AE2hISX9ZrMZj efWq8oOL3SImxZ9t4/0G0+JC2wp5Nn0mxM++TBzavTxUpCwlgWhk4ZLPJexkzvsW jKMtTsISIbqZeDL3B+nVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667142737; x= 1667229137; bh=bDpmNKR08pk7IT0tQwbrl17YaMrbX3zUohYMFTexl/w=; b=M b0HplTll4RSNf0gBy0I5LNmtdebSim25ziyZN30hRLYY2lIkzRwJZ9kCN7VEN8MG sxaWGy1Cb80X7oJc3U+DBPAVnqvv2/NfZyyjt5upPhLRJdt5pqsLYqFO5lcKvCk/ wsnrBSmaT462xEwGgzs0Vtye0z9ssABLdKQxj5AZZ1uADzlkp6tFZ0Q11weNZXlc hWGRjbng31nR5tFlY4FaF9CL7rfGBu4NlBwXmUd2cuuVhNwCslo2nuYGGGiQFsSu 09QS0iyNr9ZjsvKf8YNyGOTrAAC22nbSWahyx/IFUhx2ptzFqNv1eWrhEbZeRWmZ MLJnbgx2PKT3FYEsxv6xQ== X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedruddtgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvd elteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Oct 2022 11:12:15 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, "aaron.conole@redhat.com" Subject: Re: [PATCH v3 0/2] fix build disabling common/mlx5 Date: Sun, 30 Oct 2022 16:12:13 +0100 Message-ID: <3609957.RUnXabflUD@thomas> In-Reply-To: <20221030110827.1994953-1-thomas@monjalon.net> References: <20221030110827.1994953-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/10/2022 12:08, Thomas Monjalon: > Andrew reported a build failure when disabling mlx5 common driver. > It is a blocker for -rc2 release. > > While fixing the use of a variable across mlx5 drivers in first patch, > the consistency of its use is improved in a second patch. > > v2: apply the same protection to other mlx5 drivers > v3: fix ibverbs_link=dlopen (include directory was missing) > > Thomas Monjalon (2): > common/mlx5: fix build disabling > common/mlx5: move build config initialization and check Applied There is a CI error with Fedora 35 but it seems unrelated. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4963A00C2; Wed, 2 Nov 2022 13:10:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCD6E40223; Wed, 2 Nov 2022 13:10:15 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 569CC40041 for ; Wed, 2 Nov 2022 13:10:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667391014; x=1698927014; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=fa9/Y68TIZcN7Yj1PJ3VM5JiCYJv6qJRMIdLF9QUbv8=; b=ggxOQ+HRgo//kwnDZW8UWjBR3coHv1U1nowMQ4/O+7L+pIVzgiBsRHwb XwXIYxdnswQSTQkQ6BzupNuaopA/PMUeDrZ9rqA9FqYVcs/nFs/sOH3DQ H2e3atOV1VgiqfYoCHTLjbZUVVp106zj+szazSLfvzvXlc9lqSQ+H1PAo RpLI3u8uVJeYIcb+rNxi2YGTqBgUIM0kwDl1cQPxNfs2rsOz7JksgYK4+ hoZju4AofnrLfIDbVWnb4rM72hhrAUtwSUEmsXjoQUJqXwE2haofCtEdv sm3QN7c/39C0df0AfozOG0A6WQjh8lX5M1mtdncFubrd9thAEXNAdcHWe Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="336067947" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="336067947" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 05:10:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="963504160" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="963504160" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 02 Nov 2022 05:10:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 05:10:13 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 05:10:13 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 2 Nov 2022 05:10:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctIgL90WdMvR9UNjwuH36TfTT9FX/sK5LExcyC4Q00aP6YyvhwIOXYYPNYn6fzjpYsRzom+dfVSYKvGqxKDJfyVzL6HGUoC8YxxaOFmURPSoipVoqY4wwRs3FonBzHVHshpj5Z3Aoz4IFvPDn1QGMMhVA5DB6M5a1EqZvDvLJ5ekvzpQGxy9Jebg40PnLe2C967f2r1epLjc0tukEcfUAbQ0PC5NP+BrFxUGZ/YP/ftfzr1Hl7vN5C9hqMlljPeAWrBBs9rtN9z+TSp9uDeyhaBluVoqQ07/8+ekoK9bcxIUR3j7mx3h41xUcj1I08AsqfIU19QncblyaXle9Cq4Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WBrO5PWBt6XlVvvUTv1iNgjUWzVuIKSLBDy/17dn0w0=; b=DO4Ld78iQtOJrPBJqaS7VaXUdhddI3qC9JNLFobPWfvw5bEvkoP8NYgM/BC8VAC+SJK8nErEyhSWV+VixyRjF02cUaRDbiUSL3XPrg5FZniuuxlJL6q132/NrKun0XmxAO0LDCs4yP6SK3zxGHqCtnrSPSr3mR6wyGtQNf1PcQbkUn6AF16IWrxk3p1w3Hp4buNc1eR+/4AdsFBUxJCFyazJU8//ZFZdB/Vov1Ac/2JF+o4K+ayevUvY5bc6/zQOKp1LrxPVE0EaJqKAcV2OXewef/6tZb7TLVpgBergsBOvRExkRkYw11Lk7609A60xreoOB6GrH01RFX3STXM+zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by MN0PR11MB5962.namprd11.prod.outlook.com (2603:10b6:208:371::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 12:10:10 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::55af:6b82:6c7f:6c]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::55af:6b82:6c7f:6c%2]) with mapi id 15.20.5791.020; Wed, 2 Nov 2022 12:10:10 +0000 Date: Wed, 2 Nov 2022 12:10:03 +0000 From: Bruce Richardson To: Thomas Monjalon