From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 20029A00C3;
Sun, 30 Oct 2022 01:17:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 115CC41147;
Sun, 30 Oct 2022 01:17:53 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 1A6FE40694
for <dev@dpdk.org>; Sun, 30 Oct 2022 01:17:52 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id CCCA55C007C;
Sat, 29 Oct 2022 19:17:51 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Sat, 29 Oct 2022 19:17:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:sender
:subject:subject:to:to; s=fm3; t=1667085471; x=1667171871; bh=na
1KP6TF96qfQWtj5RxyZ2uVqvwLDvWulLux6SufzLg=; b=jgH28oczlrqn0IO4t8
QlmkKsvKqR27mcy+qp4pBDaKqD/Q5++rNtuNswUA8mspXs8oHoGqeW3JzT7Iw4eR
wvI35kB6TXdTtAgcZTAEesugXu+guIoeecqiE4uPhhvG2BTym8TgXYAb42EXxlpK
Dkv290JpC2TuY/M+e9ieO7jcmt+ccVi8o6acMLT+wHc4pR3ERtrbn/JIVQt53DLA
c2FwTUUxGvjCmz+qqRACe4lHRevAmg++imT/1RdwK4CnON867K0xA2+u741NR+Pv
rXl3MTR553Bg/u8hWRBuNSxEe/XQrLpSNrPrtecYuIpkyv26zS+auB1aa3gHaGuu
6McQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:sender:subject
:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; t=1667085471; x=1667171871; bh=na1KP6TF96qfQ
Wtj5RxyZ2uVqvwLDvWulLux6SufzLg=; b=ir/RsBaNCT5fa9FvkFFo22F+1SW3I
EgkbAqQecNm6CiucbTYpg1UeoFVZlVDWjDG4vnRJP0zGfA6snP9CAPQ3LbgxC4qY
am4KJ3cTLjglVhNQrJzdT6iwKdS2PxLjECaZsjleap1wkfldr7XgcW7trBUd65iP
6fEcdGqkielIlfTrWafj8JZOj7An1mixVxRb5864xE54pYWMUEWrz8bDtfNfZAaI
TR23pVzUFIBRjYQ9jdzFC+8hBOY/WhCLwqbfxt51fIrlIqQp4ieLtrUT10neTPJq
7LZgeAO6xl+Jyt6a8VW8x9YVo1nNXdTgDZHesVH+xrTJ+LgEsyMnl+w3g==
X-ME-Sender: <xms:n7RdYxy-USj63K8_XvtJgVWx8LQx8GnJSUWE01M2TjZygaVeUeOwag>
<xme:n7RdYxQ2YW2royK6h5RdgKXCUz06KGzzUySRHuOLYvWVoPYs1hCRBkSCDUrqo7hPj
cyDdJV7VSl1nG9w3g>
X-ME-Received: <xmr:n7RdY7VWyhLOS9DDwe1sJz9LrTCM272DKpJLe5ymqqeINb000LQAxXhqJDdkeNRMusFK5BhDydd9USvSjHcHMJg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgddvudcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek
hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:n7RdYzj1zPOOqOUKjmqzXRk0NV7-y6-VYgj7ZsMiK9Fx4Y9p-ssxfg>
<xmx:n7RdYzB9eM5dB-ukKEI_tcyedGLjzx45O-GP5hJgHh7CpSs4CEusdw>
<xmx:n7RdY8IJ7bLca5g-46v-DKyGEhDe5SEILMiyOYePKZFERDDzpvdsTw>
<xmx:n7RdY13iWjC_yjhHs4mEzrYvGDxFqLuqK89yDtkssnTsIklPGuyGbA>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
29 Oct 2022 19:17:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,
rasland@nvidia.com, avid.marchand@redhat.com,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: [PATCH 1/2] net/mlx5: fix disabling common/mlx5 dependency
Date: Sun, 30 Oct 2022 01:17:10 +0200
Message-Id: <20221029231712.773630-2-thomas@monjalon.net>
X-Mailer: git-send-email 2.36.1
In-Reply-To: <20221029231712.773630-1-thomas@monjalon.net>
References: <abaa5419-b66e-ff21-a5b8-da953a8542ec@oktetlabs.ru>
<20221029231712.773630-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
If the dependency common/mlx5 is explicitly disabled,
but net/mlx5 is not explictly disabled,
Meson will read the full recipe of net/mlx5
and will fail when accessing a variable from common/mlx5:
drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config".
The solution is to stop parsing net/mlx5 if common/mlx5 is disabled.
The deps array must be defined before stopping, in order to automatically
disable the build of net/mlx5 and print the reason.
Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering")
Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/mlx5/meson.build | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index ff84448186..9a8eb0bc19 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -9,6 +9,10 @@ if not (is_linux or is_windows)
endif
deps += ['hash', 'common_mlx5']
+if not ('mlx5' in common_drivers)
+ # avoid referencing undefined variables from common/mlx5
+ subdir_done()
+endif
headers = files('rte_pmd_mlx5.h')
sources = files(
'mlx5.c',
--
2.36.1