From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 955CFA0093; Wed, 9 Nov 2022 04:24:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7957B400D7; Wed, 9 Nov 2022 04:24:21 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id C6C61400D4 for ; Wed, 9 Nov 2022 04:24:20 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so662726pji.1 for ; Tue, 08 Nov 2022 19:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mvEupd2yZt0EHWPB2vaT3VnEQNNDUlLjTN8nopurBwc=; b=XohpW+hMGR0+K8Ge9Q7tth3hlFEeYUVaxUbPmdHMddDXTY8K8Ci5A839svsiU6/mJ9 HGpY5wTkCvZDmff+t69JxEWbM5LGN0u04DWQeoTSA3GAtQhayHiF4/J+m268hMgl7jdU kVGdl+qkRZVjY1jbhVnMO4wb91/jmQOKOotOV26MMX58xGLbwOeb4pTECd1f3PHnmGtB CcO8QwQ+MUb7I78TgdpZFCj+HciBCtu+jSW2inoQqrekvg6ti82IqT6sHyGRwPNZbvK4 H9ggSkgr2UGjg9JWPOr3qzMfhrNTYHqqQcxNjb/MTpOOHaOzT1tWdQbvFlTKWrlIU2QQ p9jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvEupd2yZt0EHWPB2vaT3VnEQNNDUlLjTN8nopurBwc=; b=rTTzEkJ13yc7jZUaCVCm+V5OXSft+uSCtfJIIJKS0wqUUuToo0LEl4Y/nQGDJTuHCM /yX3WdyI23Q7sFM9PcCguJvz3eASaZrFgf/7GUZc/XZMoY7UAVAnu6Rd1IUpQ4XCcEj4 2wTnPWSXJZGRcxr6QQ+FlRdMvkM1yMUGkNbGeGd+fmiK387GrGTDsAgMwndW6so+jUCm grPjaUc4/Dlg+0/SxdTEwJeWO/twnNovPdNCIWfIz2pPObCb9kS7CKxk+OkCDN+gtCex xG9t5szDCsDkk9I07ijqVfdYEzs3PNVa11BtknSx8jqrZtDI/wOyOdodv/ZZR8G2CqeX CJMQ== X-Gm-Message-State: ACrzQf2Zx6JFqplZH4i1XTGFfZFbxjGg2QUHbuljBnRp2GqNVFO06hA0 o+D+C/YoJxxv8BZt5X3pQnmKJg== X-Google-Smtp-Source: AMsMyM6TfHOmE0roq+rtWlqgC5qfFsTuEybO2AZq9qv+nPmEvmoj1CYv+ewI//Cj/+vip0SMXble2g== X-Received: by 2002:a17:90a:ad05:b0:212:c550:f0e9 with SMTP id r5-20020a17090aad0500b00212c550f0e9mr78643287pjq.246.1667964259870; Tue, 08 Nov 2022 19:24:19 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id r29-20020aa79edd000000b0056e32a2b88esm7105324pfq.219.2022.11.08.19.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 19:24:19 -0800 (PST) Date: Tue, 8 Nov 2022 19:24:17 -0800 From: Stephen Hemminger To: Huisong Li Cc: , , , <3chas3@gmail.com>, , , Subject: Re: [PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free Message-ID: <20221108192417.35ab2959@hermes.local> In-Reply-To: <20221109022237.49757-1-lihuisong@huawei.com> References: <20221108084038.25136-1-lihuisong@huawei.com> <20221109022237.49757-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 9 Nov 2022 10:22:37 +0800 Huisong Li wrote: > The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding > mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes > from the dev->data->dev_conf.txmode.offloads and processes as success in > bond_ethdev_configure(). But this still cause that rte_eth_dev_configure() > fails to execute because of the failure of validating Tx offload in the > eth_dev_validate_offloads(). So this patch moves the modification of txmode > offlaods to the stage of adding slave device to report the correct txmode > offloads. > > Fixes: 18c41457cbae ("net/bonding: fix mbuf fast free usage") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li Looks good thanks. Acked-by: Stephen Hemminger