From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A8E58A0542;
	Thu, 10 Nov 2022 17:13:43 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4A91940150;
	Thu, 10 Nov 2022 17:13:43 +0100 (CET)
Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com
 [209.85.210.172])
 by mails.dpdk.org (Postfix) with ESMTP id 797F9400EF
 for <dev@dpdk.org>; Thu, 10 Nov 2022 17:13:42 +0100 (CET)
Received: by mail-pf1-f172.google.com with SMTP id q9so2619346pfg.5
 for <dev@dpdk.org>; Thu, 10 Nov 2022 08:13:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=vvZbzYcw0VTnR2oSbnZ5LOGNxrwmvrhAL1SkSqNTS64=;
 b=ocGt9i/3zpubSuqhXeebPI8EEPcwEayFP3LvUEyD/b/W/1u0CM4NaCzV2zbVTbEoWB
 iC3L66jInCeLTQSLIbQEQBUg5wFM4JCzj7FgkLeEghu04fJRwmHjYQKLPYqMjxbnTLVH
 FraQG1KgVuRjVlJBdjujoUUfwlZiJa2hMTuQNAiDRTJY+PibzBg6DpspAv/aR8cr1xD8
 hug3bnkll9dobc0Jl5k6FEsFpdZprhlB3C2UIkeOJNp3GBlTeadHaLo09Bprvs6j5kD6
 zRbIUHHKBuvpewTTxuA5imhxcHl8Ye5+SFbfU/PlIq0bydx0KZ3qMeIBVMFEwwlOh79i
 KKUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=vvZbzYcw0VTnR2oSbnZ5LOGNxrwmvrhAL1SkSqNTS64=;
 b=H6xsHEFfI0zw463dyyEhFzP98bvHYSyVw6wmqKX/ka9uBBiW/50vYdPHPoSkTqaKwy
 h/EdsHCU5ul0sv55CPx2dOyym7BemPToEkkhre7tbhkOLehjohOjYcfUOrlh7s3/prcv
 41KU4Iqz5wvIVB8JvcQw5Y98+wpxPXfcN5shHpCDRZ1GbjdAhOS5GSZZPxNL6X2nF5Ea
 FG9RYxlqn4FkQiZqLAxPJKBBLM0eOQDpbR9EgzKF7/BiySg0Uca9djZqehjMrqLTcxvh
 aq3tBQ+ADe6froWlhaWjqREBWL9n8VWdn5kThW49eLP3bgMTETvcbIGZIprgPev/yrOy
 qtAQ==
X-Gm-Message-State: ACrzQf1ZuWztUXBR0azACT4cs2trFMcSgGFDqdB+85tA3jUQ89MHzNfk
 MbfCNlMfYr3+6JQfttTtDrNqmuGLUVFaQQ==
X-Google-Smtp-Source: AMsMyM55b6Sps3oWHRcvn3tfMGHnVfz54Rsrs+VvHNRbDcxhlbwUg5gEYkxzubHrB7kcQwOb17kmJQ==
X-Received: by 2002:a65:41ca:0:b0:434:f92f:d711 with SMTP id
 b10-20020a6541ca000000b00434f92fd711mr56554136pgq.151.1668096821419; 
 Thu, 10 Nov 2022 08:13:41 -0800 (PST)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
 by smtp.gmail.com with ESMTPSA id
 33-20020a631561000000b0046ae818b626sm9331772pgv.30.2022.11.10.08.13.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 10 Nov 2022 08:13:40 -0800 (PST)
Date: Thu, 10 Nov 2022 08:13:38 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, phil.yang@arm.com
Subject: Re: [PATCH v5] testpmd: cleanup cleanly from signal
Message-ID: <20221110081338.70c00a66@hermes.local>
In-Reply-To: <d3320896-eeaf-74a8-044d-6f1062fa5149@oktetlabs.ru>
References: <20221014172328.185219-2-stephen@networkplumber.org>
 <20221109172927.71411-1-stephen@networkplumber.org>
 <d3320896-eeaf-74a8-044d-6f1062fa5149@oktetlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


> > +		stop_packet_forwarding();  
> 
> force_quit() calls stop_packet_forwarding() if test_done is 0.
> So, there is no difference in test_done == 0 case.
> If test_done is not zero, stop_packet_forwarding() just logs
> "Packet forwarding not started" and does nothing. So, the
> difference is only in error message. Is it intentional?
> 
> > +		force_quit();
> >   	}

Will fix in new version, it was a logic error.