From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C8C1A056E; Wed, 16 Nov 2022 18:51:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1603940E03; Wed, 16 Nov 2022 18:51:41 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 3509B40DFB for ; Wed, 16 Nov 2022 18:51:40 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id q1so17337656pgl.11 for ; Wed, 16 Nov 2022 09:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dMVR6/UvpXedrK7SIcKak/oW07Xn82qWsCN+4vgu+do=; b=o/XBRBWo6TIkxOQQvR6s5WPayXVZncgIwMyHTQOmKn1uMelK4Tn+r27hWDRfifufAc aC5nyjjzNxeFGxGb5XPQfRgmXVqScgtikNaHPuAUh0t8Og0T41MDLdXbQ1mVu9nrca0L DPAAzTDFvAfAIVDGQKPFHx1mdEP7HnbvxjMU9nyMRrXiURk/IQDn4NCbV7xaZAI5sMK5 bBdaemn/VvVeblA0pHmSEnlTAD1ZF7gSQDpIqnfFkYbLqscK0Tfn9KsvnMEMRSKdlyW7 nE3yvfD1w18ML3fwXqfahr5XCnWf6NmsNAPI6Gm4ZZNNz15Of2LK2AzXRwzS18W9a+sE zbSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dMVR6/UvpXedrK7SIcKak/oW07Xn82qWsCN+4vgu+do=; b=sLVlOvlaBydpgalyjAxkmROl7kTDUivRgb6zSAnQLnaJvzPLEBG2qrv2ecFTOMdKAj Mp5DsRq0G0M03Wo63TswipfeLHRrOu4n4XC1K0RfvOEw7+LvVFDDCpfHN3bRw1Wb96rt yeICKxZrCyV2qc/UO3KA2eomis3EAp9IfVRsobwPIxScYiocrU+QfgukWa0iKYWHNfdj VltvT/qsibhMGrjukWqOOEAf0p59yB3uk/rV+2sGKfDPSkNKBKx6hVkLCGmeoXHY4IeG h+sDNsmY45XI6rkEQXGSn0ZPZH4eT9Px+UIOV9birDgQUpDKELMTCQ4G8drzLHXyB4jM wVFQ== X-Gm-Message-State: ANoB5pk389dxevOUy4MpYpBjh7a4/+OUbRz0FKR8Wsn9e4kHF8hTsIlY pg90uDg5qNh/Ss05ehmTUAcX6Q== X-Google-Smtp-Source: AA0mqf4E+U9y/uc+fGffwdGldFUJNZiA3SkjQv6FDgk2XI1uUUQfmDCcBGCTUsEFxi9b3J7kPeku/w== X-Received: by 2002:a63:5465:0:b0:46f:f2f6:b06 with SMTP id e37-20020a635465000000b0046ff2f60b06mr21642525pgm.376.1668621099325; Wed, 16 Nov 2022 09:51:39 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d29-20020aa797bd000000b0056c6e59fb69sm11112099pfq.83.2022.11.16.09.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 09:51:39 -0800 (PST) Date: Wed, 16 Nov 2022 09:51:36 -0800 From: Stephen Hemminger To: madhuker.mythri@oracle.com Cc: grive@u256.net, dev@dpdk.org Subject: Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id Message-ID: <20221116095136.498b2141@hermes.local> In-Reply-To: <20221116095224.1576-1-madhuker.mythri@oracle.com> References: <20221116095224.1576-1-madhuker.mythri@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 16 Nov 2022 15:22:24 +0530 madhuker.mythri@oracle.com wrote: > > + if (!rte_eth_dev_is_valid_port(PORT_ID(sdev))) { > + continue; > + } > + Looks ok but DPDK follows kernel style {} is unnecessary on single statement. Checkpatch will give you warnings on this.