From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FB9FA0568; Mon, 21 Nov 2022 20:53:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D57E84282D; Mon, 21 Nov 2022 20:53:28 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 08C5840DF6 for ; Mon, 21 Nov 2022 20:53:28 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4F56D20B83C2; Mon, 21 Nov 2022 11:53:27 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4F56D20B83C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669060407; bh=PCvXFCoQcti0GJxP2S3pCODSaTE/vZdNPdC7hR67CPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JM8032f+sih5k+muj+OFQgEwxMl0M7SRVs4vgVhrNJoYs/pHUSPnHEKIQchkxBb1k 9+D0G5A0EYmCz8erCo7WRNUUp8RxFAKtvLw/NWd/Uf5SxCH+VPMMNqN4z48gImPOu2 KON/YwsveQfywi3q1S5aApgkzWmKrSoj4DERDXe0= Date: Mon, 21 Nov 2022 11:53:27 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH] ring: build with global includes Message-ID: <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 21, 2022 at 10:31:29AM +0000, Bruce Richardson wrote: > On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > > ring has no dependencies and should be able to be built standalone but > > cannot be since it cannot find rte_config.h. this change directs meson > > to include global_inc paths just like is done with other libraries > > e.g. telemetry. > > > > Tyler Retzlaff (1): > > ring: build with global includes > > > > lib/ring/meson.build | 2 ++ > > 1 file changed, 2 insertions(+) > > > > I am a little confused by this change - how do you mean built-standalone? > The ring library depends upon EAL for memory management, does it not? Also, > no DPDK library can be built on its own without the rest of the top-level > build infrastructure, which will ensure that the global-include folders are > on the include path? > > In terms of other libs, e.g. telemetry, the only reason those need the > global includes added to their include path explicitly is because those are > built ahead of EAL. Anything that depends on EAL - including ring - will > have the global includes available. i'm having trouble seeing where in the meson.build that ring depends on eal can you point me to where it is? > > Can you explain a little more about the use-case you are looking at here, > and how you are attempting to build ring? so i found this by trying to understand other libraries dependencies through a process of disabling the build of various subsets. it's possible i didn't look deeply enough but i didn't see an explicit dependency on eal (in the meson.build files). maybe you can point out where it is because by just having rte_config.h available it compiles and links. e.g. i don't see. deps += ['eal'] is the dependency on eal the library or just eal headers? because if it is header only it is equivalent to telemetry i think? thanks! ty > > /Bruce