From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57081A056B; Mon, 21 Nov 2022 21:41:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C9D742D58; Mon, 21 Nov 2022 21:40:40 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mails.dpdk.org (Postfix) with ESMTP id 940F842D3D for ; Mon, 21 Nov 2022 21:40:35 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 64998B815DE for ; Mon, 21 Nov 2022 20:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C998FC433D6; Mon, 21 Nov 2022 20:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669063235; bh=AuYg0waQuxWd4B5EH2AbZ0Gkal/nrcpO9xrEg70Qxyg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JbjhVv9Zg5wG4eJBQWYEtKOi7l7ShW4p5gKmTcHRE3wVeQ+h4c78sDvx1vqfO8U8C t7Nw60kJ4NYzDnNEJAzZdPJwI5NOQDtJXFrHvA9bGlBuGq+QfwSsGyd4J/9RkrcWkZ 1/GtD2o+DK6zJ8Zdw/AT5GJ3PAUpcWNoDs5CqY+0cHC4Kgh/llycA3duAJH5KNVAw/ jLlnLDsp6hNuauRI7UmF6gDe0nEtquLTpU5Z7AybVukjLPdmrOFrv/5AoTzEtTSgMv It+McVNnxCJqJN/7bHGa1LSfG77D2Ml5onEQybW22aeefXi2iubURLEzTsBgBfZ+gv /Et8jm80IuC9Q== From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya Subject: [PATCH 08/11] malloc: check result of rte_mem_virt2memseg Date: Mon, 21 Nov 2022 15:40:14 -0500 Message-Id: <20221121204015.1135573-9-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221121204015.1135573-1-okaya@kernel.org> References: <20221121204015.1135573-1-okaya@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya In malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 11 ++++++++--- lib/eal/common/malloc_heap.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c index 83f05497cc..54d7b2f278 100644 --- a/lib/eal/common/malloc_elem.c +++ b/lib/eal/common/malloc_elem.c @@ -63,6 +63,8 @@ malloc_elem_find_max_iova_contig(struct malloc_elem *elem, size_t align) cur_page = RTE_PTR_ALIGN_FLOOR(contig_seg_start, page_sz); ms = rte_mem_virt2memseg(cur_page, elem->msl); + if (!ms) + return 0; /* do first iteration outside the loop */ page_end = RTE_PTR_ADD(cur_page, page_sz); @@ -91,9 +93,12 @@ malloc_elem_find_max_iova_contig(struct malloc_elem *elem, size_t align) * we're not blowing past data end. */ ms = rte_mem_virt2memseg(contig_seg_start, elem->msl); - cur_page = ms->addr; - /* don't trigger another recalculation */ - expected_iova = ms->iova; + if (ms) { + cur_page = ms->addr; + + /* don't trigger another recalculation */ + expected_iova = ms->iova; + } continue; } /* cur_seg_end ends on a page boundary or on data end. if we're diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 438c0856e2..1bf2e94c83 100644 --- a/lib/eal/common/malloc_heap.c +++ b/lib/eal/common/malloc_heap.c @@ -932,7 +932,7 @@ malloc_heap_free(struct malloc_elem *elem) const struct rte_memseg *tmp = rte_mem_virt2memseg(aligned_start, msl); - if (tmp->flags & RTE_MEMSEG_FLAG_DO_NOT_FREE) { + if (tmp && (tmp->flags & RTE_MEMSEG_FLAG_DO_NOT_FREE)) { /* this is an unfreeable segment, so move start */ aligned_start = RTE_PTR_ADD(tmp->addr, tmp->len); } -- 2.25.1