From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D0B9A0582; Tue, 22 Nov 2022 16:30:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2607642D70; Tue, 22 Nov 2022 16:30:59 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mails.dpdk.org (Postfix) with ESMTP id A0EA7427EB for ; Tue, 22 Nov 2022 16:30:57 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4A084B81BE9 for ; Tue, 22 Nov 2022 15:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8241C433D6; Tue, 22 Nov 2022 15:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669131056; bh=E4pkzY/rhciteGDTIx9m+T/RDyvtAMBSHsXQxQqE9I0=; h=From:To:Cc:Subject:Date:From; b=u3CKScJSRhKKWWp/EWLw2ArL8N9zddF09OcDda4dH3Tp0+RvF/osyHxiMYydbuto7 kiNVV2LvqzuT32HULrCMlxS8DyQsIebpvPMqhF7sQ1kWuneUnyeaL458oxa6I2v6Oe fAE6/557rPHDguyucGPAG2giPlAuWleFr4rRae84Ua+fvZIUnaPoI47hq4t+cLuzZr lKI3AwuwKJNQqlaxCUQXDA7qxL6jtNrAwoGbdwdbQY6o0SsDIlNMpvV98roH7O4oat FXc+FnipADoT4fdAs4I2AeAA7Kv8sX94Es3fDWDwK5TYETRMAV+/kUqW22UAGfNtkO uWgi+JF9N7Szw== From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya Subject: [PATCH RESEND v2 00/11] codeql fixes for various subsystems Date: Tue, 22 Nov 2022 10:30:42 -0500 Message-Id: <20221122153053.1172434-1-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya Following up the codeql reported problems first submitted by Stephen Hemminger here: https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ Posting a series of fixes about potential null pointer accesses. Changes from v1: - Remove braces around single line statements - use NULL comparisons Sinan Kaya (11): ethdev: check return result of rte_eth_dev_info_get net/tap: check if name is null memzone: check result of rte_fbarray_get memzone: check result of malloc_elem_from_data malloc: malloc_elem_join_adjacent_free can return null malloc: check result of rte_mem_virt2memseg_list malloc: check result of rte_fbarray_get malloc: check result of rte_mem_virt2memseg malloc: check result of malloc_elem_free malloc: check result of elem_start_pt bus/vdev: check result of rte_vdev_device_name drivers/net/tap/rte_eth_tap.c | 3 +++ lib/eal/common/eal_common_memalloc.c | 5 ++++- lib/eal/common/eal_common_memzone.c | 10 +++++++++- lib/eal/common/malloc_elem.c | 14 +++++++++++--- lib/eal/common/malloc_heap.c | 9 ++++++++- lib/ethdev/ethdev_vdev.h | 2 ++ lib/ethdev/rte_class_eth.c | 4 +++- 7 files changed, 40 insertions(+), 7 deletions(-) -- 2.25.1