From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>,
dev@dpdk.org
Subject: Re: [PATCH] ring: build with global includes
Date: Tue, 22 Nov 2022 08:22:41 -0800 [thread overview]
Message-ID: <20221122162241.GA30286@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <Y3yTvr1OzXg7uLwu@bricha3-MOBL.ger.corp.intel.com>
On Tue, Nov 22, 2022 at 09:17:50AM +0000, Bruce Richardson wrote:
> On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote:
> > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff
> > <roretzla@linux.microsoft.com> wrote:
> > >
> > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote:
> > > > 21/11/2022 22:27, Konstantin Ananyev:
> > > > > From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > > > > e.g. i don't see.
> > > > > >
> > > > > > deps += ['eal']
> > > > > >
> > > > > > is the dependency on eal the library or just eal headers? because if it
> > > > > > is header only it is equivalent to telemetry i think?
> > > > >
> > > > > rte_ring.c uses bunch of EAL functions:
> > > > > rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc.
> > > >
> > > > I think deps += ['eal'] is missing in ring meson file.
> > >
> > > i guess that's what i'm kind of getting at... if it was there then the
> > > patch i submitted is not required since depending on eal would drag in
> > > global_inc.
> >
> > It is implicitly added, via lib/meson.build:
> >
> > First eal is parsed before a lot of other components:
> >
> > libraries = [
> > 'kvargs', # eal depends on kvargs
> > 'telemetry', # basic info querying
> > 'eal', # everything depends on eal
> > 'ring',
> >
> > Then, there is:
> >
> > # eal is standard dependency once built
> > if dpdk_conf.has('RTE_LIB_EAL')
> > deps += ['eal']
> > endif
> >
> >
ah! thank you for pointing this out. i just couldn't see it.
> Since every library in DPDK that is built after EAL depends upon EAL, it's
> added as a standard dependency. However, if we prefer to have more explicit
> dependencies we can remove that and add it to what every libraries need
> it.
>
> [Ideally, I'd like to have all library meson.build files call out the
> full list of other libs they use, but I found in the past that it caused
> the configure time with meson to balloon as it tracked recursive
> dependencies, leading to entries appearing multiple times and then having to
> be pruned down. This is why in meson.build files dependency lists have been
> kept to a minimum up till now]
no, this is fine the way it works. i just obsessed about understanding
how it was working.
i'll withdraw the patch, it isn't needed.
thanks!
prev parent reply other threads:[~2022-11-22 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 23:22 Tyler Retzlaff
2022-11-18 23:22 ` Tyler Retzlaff
2022-11-21 10:31 ` Bruce Richardson
2022-11-21 19:53 ` Tyler Retzlaff
2022-11-21 21:27 ` Konstantin Ananyev
2022-11-21 21:36 ` Thomas Monjalon
2022-11-21 22:48 ` Tyler Retzlaff
2022-11-22 8:51 ` David Marchand
2022-11-22 9:17 ` Bruce Richardson
2022-11-22 16:22 ` Tyler Retzlaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122162241.GA30286@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).