From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18AD3A0582; Tue, 22 Nov 2022 17:22:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 007FC42D77; Tue, 22 Nov 2022 17:22:43 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4D101427EB for ; Tue, 22 Nov 2022 17:22:42 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5BEE820B717A; Tue, 22 Nov 2022 08:22:41 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5BEE820B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669134161; bh=rr1ZuIgQY6FuBXiE8dUuqV/iTGeBwtGO2yOIYZXd1GM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mAqKBdY4jRoYSi/FW+RphQitIu0R/3DNdju9nKw6NyMhEZJBPQemm6uTM7PvvW4LX V4LVuX5ofHgDsG3MkjLhXRdPmuZ+N3XfltslChwhCefOjJ2l4I3ARB17OMzxha3tSo EJFTKuIVHF1TgjziTcQ9BIfXRJ/S/yZcxNhpVtRk= Date: Tue, 22 Nov 2022 08:22:41 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: David Marchand , Thomas Monjalon , Konstantin Ananyev , dev@dpdk.org Subject: Re: [PATCH] ring: build with global includes Message-ID: <20221122162241.GA30286@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7452459.EvYhyI6sBW@thomas> <20221121224856.GB24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 22, 2022 at 09:17:50AM +0000, Bruce Richardson wrote: > On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote: > > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff > > wrote: > > > > > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > > > 21/11/2022 22:27, Konstantin Ananyev: > > > > > From: Tyler Retzlaff > > > > > > e.g. i don't see. > > > > > > > > > > > > deps += ['eal'] > > > > > > > > > > > > is the dependency on eal the library or just eal headers? because if it > > > > > > is header only it is equivalent to telemetry i think? > > > > > > > > > > rte_ring.c uses bunch of EAL functions: > > > > > rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc. > > > > > > > > I think deps += ['eal'] is missing in ring meson file. > > > > > > i guess that's what i'm kind of getting at... if it was there then the > > > patch i submitted is not required since depending on eal would drag in > > > global_inc. > > > > It is implicitly added, via lib/meson.build: > > > > First eal is parsed before a lot of other components: > > > > libraries = [ > > 'kvargs', # eal depends on kvargs > > 'telemetry', # basic info querying > > 'eal', # everything depends on eal > > 'ring', > > > > Then, there is: > > > > # eal is standard dependency once built > > if dpdk_conf.has('RTE_LIB_EAL') > > deps += ['eal'] > > endif > > > > ah! thank you for pointing this out. i just couldn't see it. > Since every library in DPDK that is built after EAL depends upon EAL, it's > added as a standard dependency. However, if we prefer to have more explicit > dependencies we can remove that and add it to what every libraries need > it. > > [Ideally, I'd like to have all library meson.build files call out the > full list of other libs they use, but I found in the past that it caused > the configure time with meson to balloon as it tracked recursive > dependencies, leading to entries appearing multiple times and then having to > be pruned down. This is why in meson.build files dependency lists have been > kept to a minimum up till now] no, this is fine the way it works. i just obsessed about understanding how it was working. i'll withdraw the patch, it isn't needed. thanks!