[PATCH 0/2] update ethdev deprecation notices

[PATCH 0/2] update ethdev deprecation notices

[Thomas Monjalon]

The deprecation plan was not followed for rte_flow actions and items.
It needs to be reflected before the release 22.11.

Thomas Monjalon (2):
  doc: update deprecation notice of legacy flow actions
  doc: update deprecation notice of flow items

 doc/guides/rel_notes/deprecation.rst | 47 +++++++++++++++++++---------
 1 file changed, 32 insertions(+), 15 deletions(-)

-- 
2.36.1

[PATCH 1/2] doc: update deprecation notice of legacy flow actions

[Thomas Monjalon]

The legacy flow actions, replaced with the more generic modify action,
are not completely replaced yet in DPDK 22.11.
The plan needs to be updated for this release,
and a new plan must be precised during the next release.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index e2efa2f8b0..8e4b1c08ff 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -54,9 +54,6 @@ Deprecation Notices
   us extending existing enum/define.
   One solution can be using a fixed size array instead of ``.*MAX.*`` value.
 
-* ethdev: Announce moving from dedicated modify function for each field,
-  to using the general ``rte_flow_modify_field`` action.
-
 * ethdev: The flow API matching pattern structures, ``struct rte_flow_item_*``,
   should start with relevant protocol header.
   Some matching pattern structures implements this by duplicating protocol header
@@ -87,10 +84,9 @@ Deprecation Notices
   ``DEC_TTL``, ``SET_TTL``, ``SET_MAC_SRC``, ``SET_MAC_DST``, ``INC_TCP_SEQ``,
   ``DEC_TCP_SEQ``, ``INC_TCP_ACK``, ``DEC_TCP_ACK``, ``SET_IPV4_DSCP``,
   ``SET_IPV6_DSCP``, ``SET_TAG``, ``SET_META`` are marked as legacy and
-  superseded by the generic MODIFY_FIELD action.
-  The legacy actions should be deprecated in 22.07, once MODIFY_FIELD
-  alternative is implemented.
-  The legacy actions should be removed in DPDK 22.11.
+  superseded by the generic ``RTE_FLOW_ACTION_TYPE_MODIFY_FIELD``.
+  The legacy actions should be removed
+  once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
 * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
   to have another parameter ``qp_id`` to return the queue pair ID
-- 
2.36.1

[PATCH 2/2] doc: update deprecation notice of flow items

[Thomas Monjalon]

The flow items are not yet cleaned up in DPDK 22.11 as desired.
The plan is updated for this release, with more details.
A new plan must be precised during the next release.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 37 ++++++++++++++++++++++------
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 8e4b1c08ff..a780c5b126 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -55,14 +55,35 @@ Deprecation Notices
   One solution can be using a fixed size array instead of ``.*MAX.*`` value.
 
 * ethdev: The flow API matching pattern structures, ``struct rte_flow_item_*``,
-  should start with relevant protocol header.
-  Some matching pattern structures implements this by duplicating protocol header
-  fields in the struct. To clarify the intention and to be sure protocol header
-  is intact, will replace those fields with relevant protocol header struct.
-  In v21.02 both individual protocol header fields and the protocol header struct
-  will be added as union, target is switch usage to the protocol header by time.
-  In v21.11 LTS, protocol header fields will be cleaned and only protocol header
-  struct will remain.
+  should start with relevant protocol header structure from lib/net/.
+  The individual protocol header fields and the protocol header struct
+  may be kept together in an union as a first migration step.
+
+  These items are not compliant (not including struct from lib/net/):
+
+  - ``rte_flow_item_ah``
+  - ``rte_flow_item_arp_eth_ipv4``
+  - ``rte_flow_item_e_tag``
+  - ``rte_flow_item_geneve``
+  - ``rte_flow_item_geneve_opt``
+  - ``rte_flow_item_gre``
+  - ``rte_flow_item_gtp``
+  - ``rte_flow_item_icmp6``
+  - ``rte_flow_item_icmp6_nd_na``
+  - ``rte_flow_item_icmp6_nd_ns``
+  - ``rte_flow_item_icmp6_nd_opt``
+  - ``rte_flow_item_icmp6_nd_opt_sla_eth``
+  - ``rte_flow_item_icmp6_nd_opt_tla_eth``
+  - ``rte_flow_item_igmp``
+  - ``rte_flow_item_ipv6_ext``
+  - ``rte_flow_item_l2tpv3oip``
+  - ``rte_flow_item_mpls``
+  - ``rte_flow_item_nsh``
+  - ``rte_flow_item_nvgre``
+  - ``rte_flow_item_pfcp``
+  - ``rte_flow_item_pppoe``
+  - ``rte_flow_item_pppoe_proto_id``
+  - ``rte_flow_item_vxlan_gpe``
 
 * ethdev: Queue specific stats fields will be removed from ``struct rte_eth_stats``.
   Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``,
-- 
2.36.1

Re: [PATCH 0/2] update ethdev deprecation notices

[Andrew Rybchenko]

On 11/24/22 17:26, Thomas Monjalon wrote:
> The deprecation plan was not followed for rte_flow actions and items.
> It needs to be reflected before the release 22.11.
> 
> Thomas Monjalon (2):
>    doc: update deprecation notice of legacy flow actions
>    doc: update deprecation notice of flow items
> 
>   doc/guides/rel_notes/deprecation.rst | 47 +++++++++++++++++++---------
>   1 file changed, 32 insertions(+), 15 deletions(-)
> 

Series-acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

RE: [PATCH 0/2] update ethdev deprecation notices

[Ori Kam]

> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Thursday, 24 November 2022 16:35
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
> dev@dpdk.org
> Cc: Ori Kam <orika@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>
> Subject: Re: [PATCH 0/2] update ethdev deprecation notices
> 
> On 11/24/22 17:26, Thomas Monjalon wrote:
> > The deprecation plan was not followed for rte_flow actions and items.
> > It needs to be reflected before the release 22.11.
> >
> > Thomas Monjalon (2):
> >    doc: update deprecation notice of legacy flow actions
> >    doc: update deprecation notice of flow items
> >
> >   doc/guides/rel_notes/deprecation.rst | 47 +++++++++++++++++++-------
> --
> >   1 file changed, 32 insertions(+), 15 deletions(-)
> >
> 
> Series-acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Series-acked-by: Ori Kam <orika@nvidia.com>

Re: [PATCH 0/2] update ethdev deprecation notices

[Thomas Monjalon]

> > > The deprecation plan was not followed for rte_flow actions and items.
> > > It needs to be reflected before the release 22.11.
> > >
> > > Thomas Monjalon (2):
> > >    doc: update deprecation notice of legacy flow actions
> > >    doc: update deprecation notice of flow items
> >
> > Series-acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> Series-acked-by: Ori Kam <orika@nvidia.com>

Applied