From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CEACA0551; Sat, 26 Nov 2022 18:34:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF85740150; Sat, 26 Nov 2022 18:34:39 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id EEAB340041 for ; Sat, 26 Nov 2022 18:34:37 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id k2-20020a17090a4c8200b002187cce2f92so10279318pjh.2 for ; Sat, 26 Nov 2022 09:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MmzA0NVs0WawrMcn5bjRP9SCBSj+RUWlLPxSOYmtlY8=; b=K0dGaSWfA8ab/1ZYjfo9SPEAJ2N8z40SaoZyzTM+FCBHAeZ9saVzwWn0CZHc963pkD mutwuM9VzlWxfW4ySZFdO2DbDsmKmRK8LNoe00tXXcNcGNHR3cvtxnj93nBV54OLfs6t 8916WVCjZMz+aABFvFJb6B0Sti+9Jo6sKA4zVnxWPRDNhNrIdemyktFY9QwKFvYnlsY+ AjWPRjIoswCuA11RnlWlIWuPrt8g9QkXWI4uXWMT7n9vVbgzq9eX3HhEYi2WiuBmGnwi 3gKYhITs1dk1uOTkRc0hkdytElxF05NRrsbAZd00TXqdqporTQyMwjR+XhcO9AuHTJ5M muHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MmzA0NVs0WawrMcn5bjRP9SCBSj+RUWlLPxSOYmtlY8=; b=Kb0TxzFrC4FxCRToY1h1vtDvXHR4Eoq8cN8R4ih8sMXlX8bAqD9czzwzoz5fvSDl36 lupEG8G8IBlMcML2XVwqb1F8nrtRqobItmOzcnbfba2IZIEUo7sLOjpxrBkc/fygo6ND QtiEjmdj4yhwTj+zFFaEU944Iney2mFm4g9mNyLAvrLJPqMAD20CXgoHsw2eqBXUBDrH bZsBaSxjg+q66ExB5ayokE2QGtBYufQJehJwE+ktcNICKjiiRSjrQ4Odjd78Vf0COq3z bO8zhqw+BCxYD8rRwEcrudVB2LO4SD9dShGgQJqR5x9ndPX1kj5IxHnesFECZmbyp0dc 7DIQ== X-Gm-Message-State: ANoB5pnAoWL7JQcx1pd8/HlbcwZAfybHGtIdWesv3NrLCwsBfz27pO62 l8J8m8ThbRWyxufht/pfisnTAQ== X-Google-Smtp-Source: AA0mqf73jC5/oMufVFrbmG5AfEziFI5cvw4XRu51QeaY6CEWJ3G3bCiGjl73j7XheejV1ONp9op2Og== X-Received: by 2002:a17:903:26c7:b0:186:e01d:8f2f with SMTP id jg7-20020a17090326c700b00186e01d8f2fmr23363607plb.40.1669484076847; Sat, 26 Nov 2022 09:34:36 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x11-20020a17090a8a8b00b002086ac07041sm4802956pjn.44.2022.11.26.09.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Nov 2022 09:34:36 -0800 (PST) Date: Sat, 26 Nov 2022 09:34:33 -0800 From: Stephen Hemminger To: Rushil Gupta Cc: Ferruh Yigit , Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, jeroendb@google.com, jrkim@google.com, Xiaoyun Li Subject: Re: [PATCH] net/gve: add support for basic stats Message-ID: <20221126093433.7b3b5078@hermes.local> In-Reply-To: References: <20221124073335.3985214-1-junfeng.guo@intel.com> <20221124085926.46430390@hermes.local> <12af66b4-0715-a0f0-a401-664632189e80@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 25 Nov 2022 19:16:00 -0800 Rushil Gupta wrote: > > > > > > The driver should be filling in the per-queue stats as well. > > > q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors > > > > > > Hi Stephen, > > > > Queue stats moved to xstats, and there is a long term goal to move all > > queue stats from basic stats to xstats for all PMDs, and remove interim > > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > > > > That is why request to new PMDs is to not introduce queue stats in basic > > stats, but in xstats. Agree that xstats are better but: * the current checked in version of GVE does not have driver op for xstats * if driver fills in the q_XXX[] stats then eth_dev_get_xstats_basic will be able to use it. The per queue stats are limited to 256 queues and bloats the info structure, but until an API breaking change is made to remove them, drivers should support it.