From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B9A9A0093; Mon, 28 Nov 2022 03:37:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A690A4067C; Mon, 28 Nov 2022 03:37:44 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2112.outbound.protection.outlook.com [40.107.220.112]) by mails.dpdk.org (Postfix) with ESMTP id EC34940156 for ; Mon, 28 Nov 2022 03:37:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HUF7NzZNgiQZ1WB+Oml/PSupfLeTxpQ5s9YUIHUBDheFh1k+Ps8KaPz1l2rS7NuGemuSBKVH1+Tx7oodplPLdsmzTCYFSeE6B96TDKB74r6MhrFTeVgjRnDc3srBBDoWK3A+/Z+N1yKU0qFLTwmIEOUHCHfJQfDnpUv+p25UXoy6Oct6K+Jm7rvrtYtrTaRZB6QqZg85oy01odAQfBESq0t7xuNrCOs75ATaFtInpSKW4f7DYimvbKKeJOWJujJFURBpIYfJpFBIT27QD1EL+mXpmQ2tFL8TAnQedTx3lTFNqsEABdyVXATHfpKn90U2/YnZsSpfWf/wyZE1vPo3ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QobCC6z7d20iDG+5jAruUWV9lFwxapoQR6KUnRkmjV0=; b=FHfC/AouMNQp6c51nMQH/F+n8IiHcIIo+XRUjv8f03PYkx0m2Z7VC6CoBBejcARqcW44oMFBlVR+P8dnHKWI2CzTdUx94F/Q4UovkETLXIlTC1Qvqp3ZUzNXJkB/cuVxDAyD7WQzJoxhatQ0UltZSYswfASdiQtNNPx1bFdEbLxActF+vCOZO6jrAviHAdr5IWM23vcX/8hkWeCvOcnFSy0LCJ0I47FGttLZw40PupZvJsyCDnO8jgeXR9WJZzCmOk0ABoKDiLtHtu1OjSFo2EwDcDB7y+ep669YO9toA02/q/h2Kz2EnAyr+wqXEUdY8lrCCyG0XE/GQO4h5Ip0Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QobCC6z7d20iDG+5jAruUWV9lFwxapoQR6KUnRkmjV0=; b=MtsRH3zVShdn06OIjHgPbPepgTySdcrWnt3kWAMjju5HeXIFSocVgmGovd0MUK7pfygPtnWoqfUu8GoLqC3IlLDiDMGkg05CuNSdPvKzjXQMiM6eVW9/Oy/0weY/nGlsBunNiDQgug/K997ULoiNXq55kW3B8xvKbhOZ0jWw26w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW4PR13MB5862.namprd13.prod.outlook.com (2603:10b6:303:1b5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 02:37:37 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::5122:8c31:51f3:4ee7]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::5122:8c31:51f3:4ee7%4]) with mapi id 15.20.5857.021; Mon, 28 Nov 2022 02:37:37 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang , Chaoyong He Subject: [PATCH] net/nfp: using the correct PCI name to look for the firmware Date: Mon, 28 Nov 2022 10:37:05 +0800 Message-Id: <20221128023705.32671-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0012.apcprd02.prod.outlook.com (2603:1096:3:17::24) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MW4PR13MB5862:EE_ X-MS-Office365-Filtering-Correlation-Id: 5584c9cf-5ef7-4b9a-b94e-08dad0e982f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ci4Pvy7zH9c2K4v/ZknFC6saUOEtWUFr/Sd9mJxtm86UmvLgoFqsDLfG++kwJl5UPoyVHiGdLm1Eb7DY1MmlV/ljR21jD6QRaMr6Fboyz94Q2pSVkXSHTvA+n/7V5DNL696qY84IoVJMCTTKAg8UO0grngnfU9CUKHEorwYN9EHU62peRaMUXGl36TUx1x94/1eUSxgAHAdUBwqHWJvZmQPJeuAyBUyENcVmlPtIfQ4i8f855JvWRiq2f14LWF+q/GQ+WjDcfitkC0bGPdWZwjpQAv19BPmbT4g6vfJuHG4usa7vEbMVijSQe3vXnKsI1iKe/FhaFgrjf4UGH1v29JRRAaRPZrAzWY21zWrXjYNmLTMElcOnCCjHgdh4uYP6L7CjqiRdfiJIlKc9SrxlRJ42UOQoM9urCBcU5a9aDLKOQHA/QIw/LIz01kDXzFA302GKFBvhWYQPgEx8/qqBeAYkATzCkenSKc3hscnm+2dnCV/Bs5lU2HFKY2cexAXEV9A2JLQaJPgTgykH4JlRU9JCIPWlcjODS/+k+UUkzaXsxqlWSAilCixaRlNw8ci5KLdOJHbqDB7/+yUYjL8Xqjy3Hn8EZG2sdcXK/ekmKdadSN2LpWGLJ5wOLM2U8c4fUa1kQ5m/X/8U7KVDMXkUnHkilbWo2gei/hCpjy609MUlRUEiOp1Z5B7XP87qRh4aA0Ivkxk/EJNzPUM1NvVWMOLhruvyV0BjO+Wp6xBCMPlWN1bpOz4y9AYvjhfHQBNR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39830400003)(136003)(346002)(376002)(366004)(396003)(451199015)(66574015)(83380400001)(54906003)(6666004)(6916009)(107886003)(6506007)(6486002)(6512007)(36756003)(86362001)(38350700002)(38100700002)(186003)(1076003)(2616005)(44832011)(8936002)(5660300002)(478600001)(52116002)(26005)(8676002)(66556008)(66476007)(66946007)(41300700001)(316002)(2906002)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDNubk1pa1h2My9tcXN4UHlwbE9VS0hLKzZadzF2YnprMzB6S1BkNVNLNEZK?= =?utf-8?B?YTU1TWIvTE54ZG0waVUzamp1NlVpYXpaVml0eDZhVktCTFh5Z29jckU1TG5q?= =?utf-8?B?Nlp5NjhYQ3lHeklNMEk2K0ppUzZnTUMxVzN0RGJTdWdFYTg0TVhFdUEwK0Vz?= =?utf-8?B?RDRxT25vcUIzU0VoZkRJcEpwK05EQm5XRHF6THpyZVM4YXBaVE5jSmVYTUd0?= =?utf-8?B?aktWVmFiUGI3UDBTWUd1VFJTRXRHaGIzTWlENE9uUXZ4UkVZM3VXUGw4NlFh?= =?utf-8?B?NEVqMzdYb1puNm4rd3RGdHZ6cEFBQnpFQUpybmNURlRkR1R2eVFsSnNmSXpw?= =?utf-8?B?Wi82RmE3ZjJrbHBOUGFMRHZZQWZ6dThmb0FkMTd5bWlnV1pCajhhMlVuYzVn?= =?utf-8?B?WlRla1pmWlpsL0lFTnE2RnYxa2JKWjNqWVB6Zitqam10anpldW50M0FFY05n?= =?utf-8?B?WTBlVzFpUTI3cjUrZHUrNFMvUjRaTjRZbkpUbDZ2a015elNncW1ESTF0VnFh?= =?utf-8?B?TUh3Wk1VQ1IyMnNuaUZYYU9EVlQyR1I4R0hZb1U2bWQxcDFiNjBDYUE2L2Ir?= =?utf-8?B?RkhRdjBhdFp6S0liUnk0WWx0dktPMTJYUjAvYnZPRW56ZDZHQURvdkZMS2hR?= =?utf-8?B?dGF2VWtSYTBTT2JYdUxKYy9ObTJoK3FuTG1xNG9lc0dCQnRDaE9YMk00VGFx?= =?utf-8?B?L1dHblIxZE5xbjhGZ3NYSVJLNXR0RERhRWJBbUFyQ1loaG1uMlZoUlk3K0RO?= =?utf-8?B?TFN6RytIMWI2dmhUQ0hZcWVNOVJVeTNYRVJ3ZXIveUgzbkNUQ285cVpqNWNI?= =?utf-8?B?WENZZThaY1ZqWTZ5elZ1Y0NlSFpZN3ZYVlNSdWVyWGxKK3pIeityZzk5ZXFp?= =?utf-8?B?M3QzZGhxbzNhWEt1TE9ySDF0eXNORnlxKzV6OUN1REZvbVZxaHUya3prWVhm?= =?utf-8?B?MmpoWW1zTTkvT0hlbXNJcitIcFE5MVliYVBoVFpRbFJHdUR5TnFveHpCVGZQ?= =?utf-8?B?K3hHNWRrbVkvSFpyL0QrL3U2MUYvb1JCSU1NOEw4QU95SGhXRXlaRUVjS3BU?= =?utf-8?B?ZTh5K2tGRjRQMjc1RWp0STZmaHV6aDZrVTQ0UTI0YzRoQnFlNlFJYVp5ZTZw?= =?utf-8?B?QkF4bVZSVE9KQUpDNE9BZkxlbVlZZEFJYTBTTnQxN2dwUGQ0TGVNSVpnZGhZ?= =?utf-8?B?MlkxYitYZE1VaElTYWpmU2hjdlNVd1FnQ004dzByQjBYTWRmTWw2M3N4Z3F2?= =?utf-8?B?R0xKbTgzakhFL0ZWQUZUSXErc1o2VEl1NW5mMVdleDU3N0Z0K1NRRHNrQ3l3?= =?utf-8?B?NVBVUDBhcFcxOU1BQ3FZdW8xTU56T0VIdmxuOG5YWlBSdktGYmZubG5nL1lW?= =?utf-8?B?RFlkdXdwMnEwb3JvNWY0VVlwbnBVbkIrSnpCRHlGZVVseEc3aG9yZ1p2WEVW?= =?utf-8?B?b2lEL2tNaTZzT2FCZmpOMTdpaVhJMCtRVnJTbi9PSEYxRllnbVVRVFYwRnZj?= =?utf-8?B?K0l6UjAvNzJMOHh4MWR4YlhtbXMvNmVlRjlwVjgyRk1SSmIrTHd6RTRpN2RL?= =?utf-8?B?SWZRZHhYMzh1OHFDUUhtdnB6cVBCd29zL1dBK29QY0U2SU1UK0NPV1BKcW1M?= =?utf-8?B?RWZBeXU5V2tlR1Q4WVM0Sm1ob1AxSGtwYTB0YWNyZGxtRFBGMEw2c3VMVWUx?= =?utf-8?B?bFRPeVQvZmNRMk5nVnI2Qk9HeTFHcjMweFdzSFNFS25GUkhkUTRTN3J6K0Z1?= =?utf-8?B?TXNISnJRVnVuNytBa3BpRnNCYW1ZMURVRWlDdWhDSUE3VkVuRlJrNTYvRnRq?= =?utf-8?B?RHNzbElWeWpNUWFTZkZrOHE0SW9wVTR6dVZpemRHQ0prVFRFcktGcTNsaldw?= =?utf-8?B?KzVtZzFkcVdGeVl6RVJMaHlOcTg2ck9UMkV0SVpibTVGWktmYzAvaHJQc1p0?= =?utf-8?B?MGVNcCtnNkRjdjQrWXVKZU5yOXZ2SDVaa0JlU3BjUVlVSjJockFsRmFxd05n?= =?utf-8?B?SUJYWEtXWWM2elFjdFA1a0NlL2Jwc3NET0NQeTNQdFZmdysvbVU1QTdEcU1u?= =?utf-8?B?SGs2QVlNT2ZyRDhYOFlqQW43aDNEdFp0cTVqVEtoZkVqdFZMT1hOb05PTlFa?= =?utf-8?B?M0dhci9wRmtkRkE2MW81Vzl2MHZrUmNTZG44ZTBzN0dsZGxWSC9JNkZueW02?= =?utf-8?B?NlE9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5584c9cf-5ef7-4b9a-b94e-08dad0e982f8 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 02:37:37.3223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5wVwTrHyf+Pl2VPWCe+5AisXJKZr7qiJUwALTUndsZlayGXOgzTSN/VFeblHu1nRJzRDwsa5y1zzRSBsQGFW5LU/MROqbEOdC46tRkAB7Uc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5862 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peng Zhang In the description of nfp document, DPDK PMD supports that the PF looks for a firmware file by the PCI name. After this commit, it will looks for the PCI name format such as pci-0000:04:00.0.nffw rather than pci-04:00.0.nffw, which will keep consistent with what is written in the nfp.rst. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 0956ea81df..f22ae24b53 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -724,7 +724,7 @@ nfp_fw_upload(struct rte_pci_device *dev, struct nfp_nsp *nsp, char *card) goto load_fw; /* Then try the PCI name */ snprintf(fw_name, sizeof(fw_name), "%s/pci-%s.nffw", DEFAULT_FW_PATH, - dev->device.name); + dev->name); PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name); if (rte_firmware_read(fw_name, &fw_buf, &fsize) == 0) -- 2.29.3