From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4F81A0093; Mon, 28 Nov 2022 18:24:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EE7740691; Mon, 28 Nov 2022 18:24:27 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id CE77D4067E for ; Mon, 28 Nov 2022 18:24:25 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id z17so6345868pff.1 for ; Mon, 28 Nov 2022 09:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HVvMeC82ozjevKd3mAqqcdMN7C68LDB230SiZ2xL5U0=; b=nr0TcIeDG4xsx6V3/cljICe+N7dSGCgspTX539GkQQ2+zGFnipRmqScXIj4FWGgoxu 2yQMnITS/Z1P91C9QGhcW5IEzx1oN6TsB3lUS1CBY7CmV0gtL7Z6Ds1VcqSbVlojSGp9 KSqPLcyizr6b3K9ulSpyZwhFhwSyUZDN1BuX8/DNjgufBcVc3RaYYaar8AdcrslaGaEJ WSjzE1QHKNPLZmrMmQGOnOoTt9nqUbsLE5g+vNTisRfDBM16UI7hiFYnWWvOx/al3Dcl 52/kufYAOAUJUr7vbBxCJWrDCr3y9a3VpbXJGVbY/JAnWw5KhPIgnlmFKdzghGQSGdVI Dl5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HVvMeC82ozjevKd3mAqqcdMN7C68LDB230SiZ2xL5U0=; b=ZA9ZCHwh6dpBMBUw0LKagblNx5U8SGDD+El1OWyarZ1gRPJpp4MSL6qQip6zZxbcnf hjmh3u7IpX3gvsMOs3vX9TFBQOkO0L9Ite/vt9z9zJyIMSJK8CCDznVrmHxxuxr4Az5D lbVoO9orK0SsxFFBRxgmaPnzeuYyEQwogKcrWCcqsh50YWQTQvBGSL7RhOw9HkIFvH4w vCN+KlMUf9XTyJ0Qd7JXlanHwvNawsA1LJeCQTduIuuikU8mgcEK4F3aXT//eXqTe3a/ pXbX06ireIp8YhX5sq2XW6qVvMBxRsm7+LXbChnVocZs4kGzubQHphwV2ZAw7qRoN+JZ 832Q== X-Gm-Message-State: ANoB5pkaaoFAjsIpjH0vFTtX/9/zUQSpulNXkMwFilEsTHTIT8Jn9Nm0 UK9HkFUHmZGCvlX7iBkAY3Cm3w== X-Google-Smtp-Source: AA0mqf4qnSyoWT6Ktd5kAZG2g1GMqFdoRA8kTOQzl/hSfU3r3tZ13Mgo+vZ8i5vh5utuy1wh8YGK6g== X-Received: by 2002:a63:7353:0:b0:477:467e:357f with SMTP id d19-20020a637353000000b00477467e357fmr28462829pgn.263.1669656264811; Mon, 28 Nov 2022 09:24:24 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k5-20020aa79985000000b0056ba6952e40sm8309223pfh.181.2022.11.28.09.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 09:24:24 -0800 (PST) Date: Mon, 28 Nov 2022 09:24:20 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: Rushil Gupta , Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, jeroendb@google.com, jrkim@google.com, Xiaoyun Li Subject: Re: [PATCH] net/gve: add support for basic stats Message-ID: <20221128092420.311409ad@hermes.local> In-Reply-To: <38d43919-f060-4ccc-67e6-180957015dc5@amd.com> References: <20221124073335.3985214-1-junfeng.guo@intel.com> <20221124085926.46430390@hermes.local> <12af66b4-0715-a0f0-a401-664632189e80@amd.com> <20221126093433.7b3b5078@hermes.local> <38d43919-f060-4ccc-67e6-180957015dc5@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 28 Nov 2022 11:12:38 +0000 Ferruh Yigit wrote: > On 11/26/2022 5:34 PM, Stephen Hemminger wrote: > > On Fri, 25 Nov 2022 19:16:00 -0800 > > Rushil Gupta wrote: > > > >>>> > >>>> The driver should be filling in the per-queue stats as well. > >>>> q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors > >>> > >>> > >>> Hi Stephen, > >>> > >>> Queue stats moved to xstats, and there is a long term goal to move all > >>> queue stats from basic stats to xstats for all PMDs, and remove interim > >>> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > >>> > >>> That is why request to new PMDs is to not introduce queue stats in basic > >>> stats, but in xstats. > > > > Agree that xstats are better but: > > > > * the current checked in version of GVE does not have driver op for xstats > > > > * if driver fills in the q_XXX[] stats then eth_dev_get_xstats_basic will be > > able to use it. > > > > That is an option, but it will require driver to add > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag what we want to get rid of in > long term. > That is why we are requesting new driver to add the xstats > implementation instead of adding queue support in basic stats. It is up > to PMD to provide xstats implementation if they want queue stats. Agreed, having xstats in driver is the best way. Doing what virtio does now would be a good example.