From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74319A0093; Mon, 28 Nov 2022 18:18:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 633874067E; Mon, 28 Nov 2022 18:18:16 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 43EE840150 for ; Mon, 28 Nov 2022 18:18:15 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 6C32220B717A; Mon, 28 Nov 2022 09:18:14 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6C32220B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669655894; bh=VzwFP232DlEx4y5pO/7YbWNjgkShijXO0RIlr5XcdhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rGyuqqmdSDVHS+yVkN6O1+uLbUaE/E8Y1kvkV8cP0qRANu+2LK18Xn6k1cBCLyLjq uvvXNM9NsEuYosi5smqLXS1XPX650GzRbFK/7Abo7JQY24Y9tXT/UT9LzBY+gNZY41 +dEeBhx7RKgLnWsaaR+MrUG6N1+J2nbZcauhMtYQ= Date: Mon, 28 Nov 2022 09:18:14 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: Bruce Richardson , Stephen Hemminger , David Marchand , dev@dpdk.org Subject: Re: [PATCH v4] mailmap: add file to DPDK Message-ID: <20221128171814.GB28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20201020130722.304989-1-bruce.richardson@intel.com> <20221124085154.13f5096f@hermes.local> <4185004.mogB4TqSGs@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4185004.mogB4TqSGs@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 24, 2022 at 06:19:57PM +0100, Thomas Monjalon wrote: > 24/11/2022 17:51, Stephen Hemminger: > > On Thu, 24 Nov 2022 13:43:07 +0000 > > Bruce Richardson wrote: > > > > > On Thu, Nov 24, 2022 at 01:13:20PM +0100, David Marchand wrote: > > > > From: Bruce Richardson > > > > > > > > Since a number of contributors to DPDK have submitted patches to DPDK > > > > under more than one email address, we should maintain a mailmap file to > > > > properly track their commits using "shortlog". > > > > > > > > It also helps fix up any mangled names, for example, with > > > > surname/firstname reversed, or with incorrect capitalization. > > > > By keeping this file in the DPDK repository, rather than committers > > > > maintaining their own copies, it allows individual contributors to edit > > > > it to update their own email address preferences if so desired. > > > > > > > > While at it, update our checkpatches.sh script and add some > > > > documentation to help new contributors. > > > > > > > > Signed-off-by: Bruce Richardson > > > > Signed-off-by: David Marchand > > > > --- > > > > Changes since v3: > > > > - fixed some issues with non iso characters in names, > > > > - added .mailmap to MAINTAINERS, > > > > - populated .mailmap with the contributors file Thomas and I maintain, > > > > - added a check so that people will stop mangling their own names, > > > > - added a note in the contributing guide, > > > > > > > Do we really want to require all contributors to add their names to the > > > mailmap file, it seems excessive to me and onerous on new contributors? I > > > would expect the mailmap to be only necessary for tracking mail updates, or > > > fixing already-mangled names. > > > > > > /Bruce > > > > Isn't mailmap only needed when there are multiple email addresses in the commit log? > > Yes, but we also want the full list in order to make sure > there is no typo when writing name or email. > That's the dirty job maintainers are doing... > > coming to the party late, does this fix the problem of the CI rejecting patches that have @microsoft.com vs @linux.microsoft.com for me? because if it does i'm on board with this change. this arises for me if i work on my "work" provided systems which use a default user.email, if i don't notice then it's stuck in the history and i have to stuff around to fix the commits. thanks for doing this.