From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A2D0A00C2; Wed, 30 Nov 2022 17:54:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2B5240395; Wed, 30 Nov 2022 17:54:26 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 1BDA640151 for ; Wed, 30 Nov 2022 17:54:24 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id o5-20020a17090a678500b00218cd5a21c9so2772526pjj.4 for ; Wed, 30 Nov 2022 08:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Xo8rW9xs60qTi+9Es8cjV/no7WSgSiAOuUNj44xtNJo=; b=r08viLFwVUgtGiZwKtFF5Aj5A6tu5ByozWFRlrLYEBO0YzNkGBhFJl5FYIFIX79hy3 EnOvLUCCNWi0CYowyva6Feqk5/QVfe/hkfZBlxZqZaEIiYbXrtfKcgr1I3N484Xy8kN7 JwefSu79PNwybP+HVcULD2kMP+agH1zKuDC/TE1ffilz7mVCAhE+8V62ODJ9oNdgRwBV D/DplroctjhCLIz0MqcufQgccb2Cp+gwHHCgiAeFFbFOr4t8xMEEsV/QRCXqIKqx8Pz1 xX+nTd6ymB+Pu6aSMj2oF8wT6xFwTAe1NbCEwCYv2vIIl1RaL2qMwfSEHI/L0kOj3Em3 maqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xo8rW9xs60qTi+9Es8cjV/no7WSgSiAOuUNj44xtNJo=; b=EPtQ9kAl+l8IoMFoWhbpazvMzTPK+vGT6Okq3YOrqWJoiBaI8im9rpS+tgzWXT7LyJ UKSe7+t2dz87J562XeYtl+tPVfotIICmZcBKSWthmkfqW9K9dqOZRGE+OZHIswfjjtae fYqf+Z0Xy8Dmo+BCKnn8K422G30K7up6oiS37dZcLpSdct/6yYOw+daWmW5+L3lud3he 0pRSIy1t/yo53T52iPsZ3/0dH9Hzhjnb6eZTNwEhtbdFc5FWVy66UlpoY9uXaDvLdb59 yk8QFqGO1phj030VvbJmWlLw0PLtCE8+292V/EgAHf8RbqtixFmEIGoetrLf83hGu0TS DeCg== X-Gm-Message-State: ANoB5pkR2Hn4HLfHZ08T+htw831O/qHA6ZlI9y1wclENa7p8hi8Ka+Mn VpvBUU3cYbYJAurat3CwNy4VmQ== X-Google-Smtp-Source: AA0mqf7oKo65qqCKajQNQBfyKZiMo2Xo/igOVcuKuekRf8BfSxT7iUbJOLjM+IAuZzOT9a58o/4a9w== X-Received: by 2002:a17:902:9889:b0:182:e9dd:936d with SMTP id s9-20020a170902988900b00182e9dd936dmr44186718plp.6.1669827263950; Wed, 30 Nov 2022 08:54:23 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id t10-20020a1709027fca00b00186c3727294sm902301plb.270.2022.11.30.08.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 08:54:23 -0800 (PST) Date: Wed, 30 Nov 2022 08:54:21 -0800 From: Stephen Hemminger To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, eperezma@redhat.com Subject: Re: [PATCH v1 19/21] net/virtio-user: forward control messages to shadow queue Message-ID: <20221130085421.31ef0a2d@hermes.local> In-Reply-To: <20221130155639.150553-20-maxime.coquelin@redhat.com> References: <20221130155639.150553-1-maxime.coquelin@redhat.com> <20221130155639.150553-20-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Nov 2022 16:56:37 +0100 Maxime Coquelin wrote: > + if (status != 0 || !dev->scvq) > + goto out; > + > + status = virtio_send_command(&dev->scvq->cq, (struct virtio_pmd_ctrl *)hdr, dlen, nb_dlen); > +out: Maybe I am looking at the diff only, and not seeing something but. This looks like just an if statement, why the goto here?