* [PATCH v1] eventdev/crypto: overflow in circular buffer
@ 2022-11-30 15:42 Ganapati Kundapura
0 siblings, 0 replies; only message in thread
From: Ganapati Kundapura @ 2022-11-30 15:42 UTC (permalink / raw)
To: dev, jerinj, s.v.naga.harish.k, abhinandan.gujjar; +Cc: jay.jayatheerthan
Crypto adapter checks CPM backpressure once in enq_run()
This leads to buffer overflow if some ops failed to flush
to cryptodev.
Checked CPM backpressure for every iteration in enq_run()
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c
index 3c585d7..e7e9455 100644
--- a/lib/eventdev/rte_event_crypto_adapter.c
+++ b/lib/eventdev/rte_event_crypto_adapter.c
@@ -585,14 +585,15 @@ eca_crypto_adapter_enq_run(struct event_crypto_adapter *adapter,
if (adapter->mode == RTE_EVENT_CRYPTO_ADAPTER_OP_NEW)
return 0;
- if (unlikely(adapter->stop_enq_to_cryptodev)) {
- nb_enqueued += eca_crypto_enq_flush(adapter);
+ for (nb_enq = 0; nb_enq < max_enq; nb_enq += n) {
- if (unlikely(adapter->stop_enq_to_cryptodev))
- goto skip_event_dequeue_burst;
- }
+ if (unlikely(adapter->stop_enq_to_cryptodev)) {
+ nb_enqueued += eca_crypto_enq_flush(adapter);
+
+ if (unlikely(adapter->stop_enq_to_cryptodev))
+ break;
+ }
- for (nb_enq = 0; nb_enq < max_enq; nb_enq += n) {
stats->event_poll_count++;
n = rte_event_dequeue_burst(event_dev_id,
event_port_id, ev, BATCH_SIZE, 0);
@@ -603,8 +604,6 @@ eca_crypto_adapter_enq_run(struct event_crypto_adapter *adapter,
nb_enqueued += eca_enq_to_cryptodev(adapter, ev, n);
}
-skip_event_dequeue_burst:
-
if ((++adapter->transmit_loop_count &
(CRYPTO_ENQ_FLUSH_THRESHOLD - 1)) == 0) {
nb_enqueued += eca_crypto_enq_flush(adapter);
--
2.6.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-30 15:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-30 15:42 [PATCH v1] eventdev/crypto: overflow in circular buffer Ganapati Kundapura
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).