DPDK patches and discussions
 help / color / mirror / Atom feed
From: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
To: xiao.w.wang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, chenbo.xia@intel.com,
	purna.chandra.mandal@intel.com,
	Abhishek Maheshwari <abhishek.maheshwari@intel.com>
Subject: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices
Date: Tue,  6 Dec 2022 18:25:24 +0530	[thread overview]
Message-ID: <20221206125524.339468-1-abhishek.maheshwari@intel.com> (raw)
In-Reply-To: <20221206125041.339275-1-abhishek.maheshwari@intel.com>

Fixing the match table for vdpa/ifcvf driver because as per the Virtio
device specification, for modern virtio devices, drivers MAY match any
PCI Subsystem Vendor ID and any PCI Subsystem Device ID value.

Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device")
Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device")
Cc: stable@dpdk.org

Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 49d68ad1b1..214d6e1f60 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
 	{ .class_id = RTE_CLASS_ANY_ID,
 	  .vendor_id = IFCVF_VENDOR_ID,
 	  .device_id = IFCVF_NET_MODERN_DEVICE_ID,
-	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
-	  .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
+	  .subsystem_vendor_id = RTE_PCI_ANY_ID,
+	  .subsystem_device_id = RTE_PCI_ANY_ID,
 	},
 
 	{ .class_id = RTE_CLASS_ANY_ID,
@@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
 	{ .class_id = RTE_CLASS_ANY_ID,
 	  .vendor_id = IFCVF_VENDOR_ID,
 	  .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
-	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
-	  .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
+	  .subsystem_vendor_id = RTE_PCI_ANY_ID,
+	  .subsystem_device_id = RTE_PCI_ANY_ID,
 	},
 
 	{ .vendor_id = 0, /* sentinel */
-- 
2.31.1


  reply	other threads:[~2022-12-06 13:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 12:50 [PATCH] " Abhishek Maheshwari
2022-12-06 12:55 ` Abhishek Maheshwari [this message]
2022-12-08 13:08   ` [PATCH v2] " Wang, Xiao W
2022-12-09  2:37     ` Pei, Andy
2022-12-15  3:42   ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
2022-12-15  3:48     ` [PATCH v4] " Abhishek Maheshwari
2022-12-16  1:58       ` Pei, Andy
2023-01-19 14:09       ` Maxime Coquelin
2023-02-03 14:57       ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206125524.339468-1-abhishek.maheshwari@intel.com \
    --to=abhishek.maheshwari@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=purna.chandra.mandal@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).