* [PATCH] doc: update recipe for static rdma-core in mlx guides
@ 2022-12-08 11:16 Thomas Monjalon
2022-12-08 11:33 ` Bruce Richardson
2023-01-11 8:45 ` [PATCH v2] " Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-12-08 11:16 UTC (permalink / raw)
To: dev; +Cc: alialnu, Matan Azrad, Viacheslav Ovsiienko
With recent versions of rdma-core, it becomes important to install,
so some non-standard compiler tricks are avoided.
While at it, disabling unneeded pyVerbs and man pages.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/nics/mlx4.rst | 3 ++-
doc/guides/platform/mlx5.rst | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 924ce6f64b..c6279f51d0 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -209,8 +209,9 @@ Current RDMA core package and Linux kernel (recommended)
- Starting with rdma-core v21, static libraries can be built::
cd build
- CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+ CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
ninja
+ ninja install
.. _`RDMA core installation documentation`: https://raw.githubusercontent.com/linux-rdma/rdma-core/master/README.md
diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst
index 3cc1dd29e2..5784b9a87b 100644
--- a/doc/guides/platform/mlx5.rst
+++ b/doc/guides/platform/mlx5.rst
@@ -162,8 +162,9 @@ https://github.com/linux-rdma/rdma-core
It is possible to build rdma-core as static libraries starting with version 21::
cd build
- CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+ CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
ninja
+ ninja install
NVIDIA MLNX_OFED/EN
--
2.38.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] doc: update recipe for static rdma-core in mlx guides
2022-12-08 11:16 [PATCH] doc: update recipe for static rdma-core in mlx guides Thomas Monjalon
@ 2022-12-08 11:33 ` Bruce Richardson
2023-01-11 8:45 ` [PATCH v2] " Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2022-12-08 11:33 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, alialnu, Matan Azrad, Viacheslav Ovsiienko
On Thu, Dec 08, 2022 at 12:16:46PM +0100, Thomas Monjalon wrote:
> With recent versions of rdma-core, it becomes important to install,
> so some non-standard compiler tricks are avoided.
>
I think this paragraph could do with a bit more explanation in it, e.g. to
clarify that this is (presumably) installing package vs working with it in
build directory.
/Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] doc: update recipe for static rdma-core in mlx guides
2022-12-08 11:16 [PATCH] doc: update recipe for static rdma-core in mlx guides Thomas Monjalon
2022-12-08 11:33 ` Bruce Richardson
@ 2023-01-11 8:45 ` Thomas Monjalon
2023-03-07 11:16 ` Raslan Darawsheh
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2023-01-11 8:45 UTC (permalink / raw)
To: dev; +Cc: alialnu, bruce.richardson, Matan Azrad, Viacheslav Ovsiienko
With recent versions of rdma-core, it becomes important to install
the library after its compilation.
If including rdma-core library from its build directory,
some non-standard compiler tricks are used.
When using an install directory for rdma-core, DPDK compilation is fine.
While at it, disabling unneeded pyVerbs and man pages.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: reword commit log
---
doc/guides/nics/mlx4.rst | 3 ++-
doc/guides/platform/mlx5.rst | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 924ce6f64b..c6279f51d0 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -209,8 +209,9 @@ Current RDMA core package and Linux kernel (recommended)
- Starting with rdma-core v21, static libraries can be built::
cd build
- CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+ CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
ninja
+ ninja install
.. _`RDMA core installation documentation`: https://raw.githubusercontent.com/linux-rdma/rdma-core/master/README.md
diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst
index 3cc1dd29e2..5784b9a87b 100644
--- a/doc/guides/platform/mlx5.rst
+++ b/doc/guides/platform/mlx5.rst
@@ -162,8 +162,9 @@ https://github.com/linux-rdma/rdma-core
It is possible to build rdma-core as static libraries starting with version 21::
cd build
- CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+ CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
ninja
+ ninja install
NVIDIA MLNX_OFED/EN
--
2.39.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] doc: update recipe for static rdma-core in mlx guides
2023-01-11 8:45 ` [PATCH v2] " Thomas Monjalon
@ 2023-03-07 11:16 ` Raslan Darawsheh
0 siblings, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2023-03-07 11:16 UTC (permalink / raw)
To: NBU-Contact-Thomas Monjalon (EXTERNAL), dev
Cc: Ali Alnubani, bruce.richardson, Matan Azrad, Slava Ovsiienko
Hi,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, January 11, 2023 10:45 AM
> To: dev@dpdk.org
> Cc: Ali Alnubani <alialnu@nvidia.com>; bruce.richardson@intel.com; Matan
> Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH v2] doc: update recipe for static rdma-core in mlx guides
>
> With recent versions of rdma-core, it becomes important to install the library
> after its compilation.
> If including rdma-core library from its build directory, some non-standard
> compiler tricks are used.
> When using an install directory for rdma-core, DPDK compilation is fine.
>
> While at it, disabling unneeded pyVerbs and man pages.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: reword commit log
> ---
> doc/guides/nics/mlx4.rst | 3 ++-
> doc/guides/platform/mlx5.rst | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-07 11:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-08 11:16 [PATCH] doc: update recipe for static rdma-core in mlx guides Thomas Monjalon
2022-12-08 11:33 ` Bruce Richardson
2023-01-11 8:45 ` [PATCH v2] " Thomas Monjalon
2023-03-07 11:16 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).