From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9993AA00C2; Fri, 9 Dec 2022 09:18:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31C87410FB; Fri, 9 Dec 2022 09:18:17 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2132.outbound.protection.outlook.com [40.107.220.132]) by mails.dpdk.org (Postfix) with ESMTP id 3D90E40E03; Fri, 9 Dec 2022 09:18:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksp9xemfYosbIexfemRnVRiiw6/fhIEvsBHeoqlPgIvEtcGqgL3flhxB3HvCgVN6QnFw+WyXHfz6SKy9mJHANKAdwYKnezf4aaN/dRcXAAB9ASGZmFqFg/JDeRyGBEIhOv75/pwCvLmToEYholWtOHlCqrtlY2h5Wnmidc737zpweGBMaf0NbtprjzSIwhfXMB0YujdJywcOswIRFz2T8ezQYGRUkSq/ul2nX+M4qqQ8qPOXvPCvmG6/+zJFmSEKyr9NrUr3NlsxRT4BoJ9YcY9fyDOIuUIh62sGzOi69CXldTcx3/8du1A9Sv3T0BGlbydbXvkHi653u3FBwuzwyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3YpEYNzIX/bvdTqCe/WBsqJtkUogIZ3NMe3jzd68cG4=; b=AzHLVeHXkyP4A5IRLcrhzf3dgFxrgNGfWurEs5sVHnheJo3Sa7Y96xe2h6KNQNhVAh+XHU4j1ZzcJsTfdkurGYdx5SXyB96tQZNlHq5q6kxwSZ2GISiMDyf9/GWL1OKrRy+31jSPMHc1Vse/zISWFpJjOCK4AYsBKnUFo8oa3EkME+TwKnk3xFAHna14xzGD4MX5rZg8zhD+gQztNphOTw60y3WVMq81ISP13A5yomgw4d5Ya9dY9u8L0RpbkmVKw1jxt8vx5pi94D0Sa4uHn5UbelE8CNrOwvsq9n2rvzSDFCAVQD1Ecqi852oqEhX+Gi68s118foEXopIjInlsWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3YpEYNzIX/bvdTqCe/WBsqJtkUogIZ3NMe3jzd68cG4=; b=dF6gIiF9+qwsoTVRQiElUIRnaXrQD1SQ2tDvwaOJVoKKyCqCzyGnl2/4DLrVuS11kmm/JA62ZydZdALs1saer812KoHXj8E1CAmzDyKRB7oHJEZoGIHf4t7DHNb2LplDrbwwaOF+GiCNisRc3V+gU+FI8zCkcRA1LlGYyv8LMcQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB5609.namprd13.prod.outlook.com (2603:10b6:806:230::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 08:18:12 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::5122:8c31:51f3:4ee7]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::5122:8c31:51f3:4ee7%5]) with mapi id 15.20.5880.016; Fri, 9 Dec 2022 08:18:12 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2] net/nfp: store counter reset before zeroing flow query Date: Fri, 9 Dec 2022 16:17:47 +0800 Message-Id: <20221209081747.39507-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20221209062259.22341-1-chaoyong.he@corigine.com> References: <20221209062259.22341-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: ZR0P278CA0090.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::23) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA1PR13MB5609:EE_ X-MS-Office365-Filtering-Correlation-Id: 1778ee8d-b8eb-4825-9f68-08dad9bde999 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HKzYI3tYun1Sumg+Vb8FNhAw8XM3cQZm2ViwBU68hXJ26ohiMbCEdiKIgePDQj8dP0S/XaOeaB4BaYaXHz1AO0TXnSvfaGORJ+zAk8cUSij5/mXd3H8u+nl9CuGS+8c6QmSYFxm9cNViFTKv1dIu5NRpSbuMF8e4+K6URfyjc/Jkul9AiA32TSo7cxpLImrF8CUlegX/18sICSOybQaAdIp7YpWm4RQxIF5L22zBt33j63FRDbo7MLY92EEuGxONqsNIUVKl9+BHBewZofwUOCqXwJRNGd/lKfYD1jKQyb7ykIfPn7WiBjEAO3rOiKe5Hf1Zx1a7m8PVy678JzbYaT+Czq5TR5L/DltAg6PFKb9gVK4vrWmPFXhkhQZP9YO4n2exJ3WbdS1m3YTs3sG5zasS7nwErAdzsWp95EFeTCnwh5YwwzzlWWOOrwjyN3XyY6NtrXdTq5dYEcf1SslWqQlliRWmAd4AocoJR4mxTgO0duN7H8geGRY3fFE9HcyN4U8DYlYmXTyyIumhzQxxLRvMHaWMuzhXyMubnA7kwvHkmlsC1kWBTAfzCqbHndEMDmKDD12o6EpOiOzVnXfeaNiZ9vrSb4AGLlnE+6q4cClbvVBKHrQhMkPyUQ9rLPKGs0aBdK/htvfdarloXgJmBSf/G2xY1MYRpXYdM3mxUEPhw/+dyx8oYY208xd/mXJikMJoN9v1iQQJyU3MHmdD4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(136003)(39830400003)(396003)(366004)(451199015)(86362001)(41300700001)(52116002)(83380400001)(66574015)(8936002)(6486002)(6666004)(6506007)(2616005)(1076003)(186003)(5660300002)(478600001)(2906002)(36756003)(26005)(44832011)(8676002)(38350700002)(316002)(6512007)(38100700002)(6916009)(4326008)(66946007)(66476007)(66556008)(450100002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3FuNUc2SlJWWUdEWXJtckJXTVNZNzRvVStDdDNqRDJEK3dyQmo1VDZraGpl?= =?utf-8?B?N014eXZ2MUZQbGtENEtPSmFiME1UTFIwaW1nZmxFWVBoZk8yVFBrTTgxWms1?= =?utf-8?B?cW5oYnk4N0lkUHRucnBkbTAwTHIreG1hR21TY2hIMzFjcmV1YldqT1NGengv?= =?utf-8?B?Y3B0elV5RlpqejlNQVo4V3YydUJ1NjA0SFMveGl6eFJ0VWhlc1hSRUVwbFVV?= =?utf-8?B?M0Fwb0Y2Tzd1WVptTkxzdDgvUWplSVB0Mjc3a09hcWx4NjR2bEN5Z3VlM1NP?= =?utf-8?B?MGI1eGp6RDNsNGYxQU5oK3laTlpKaUdBSStLLy9iK3d0YllwZlNWL0VIeUNH?= =?utf-8?B?V09uZFFxOXQ4dkszMDRCWk5VMmlqdi8wS3Bqb0h6TnplbXNVaDZ2Q292bzZk?= =?utf-8?B?K1ZpUEFjMkxnZXRvUU9GUXllQkFyQUFkZ1dLNFZHQUdQRkhqSFZkQ0lOc0xo?= =?utf-8?B?ZHNuY08yZGJTbkd6YmR0Sytvam9SSlVwcWJhbFhpOGZPcXpTU2EzUHYwR0RX?= =?utf-8?B?ZFh4dG1lT1U5OFdjNFBWK0hlSnhoOFNvZENRTHpjUDBHbnFMdnZORjhuT3F2?= =?utf-8?B?KzNSMHNPRjFORXZ5OG8zcnU4R3pHRGR6NzMyR0Z2dEZHZmNuMkU0V2RVdS9O?= =?utf-8?B?SG1wcnBGRXVBdVJqcCtGZmdpb2MxV1JWeUdTb3UveW9NU2xtcDcwNXZTY0lF?= =?utf-8?B?R0diY2dJWnFGZ1FMNHgzVWZWM1ZJc0lMbXJaU0sxNnhRNmZ0Y2x2VSs2MWo2?= =?utf-8?B?WVZpVTR4MkhJTW9QZ2k0eExiWGx5dmJZTytvR3NBZFNGV2daeGNwNHJiWGdH?= =?utf-8?B?bFNScnV0RCtsMFJJdXg5L3hpV3Q2N1l5bmZaTnlVQkZwaXlFWTJGZzdIWXUx?= =?utf-8?B?d3hNd2hFZEhjYlMySGNxM3lScndWcW45by83LzYrZXJGNTNpUFdLMDFrUmVt?= =?utf-8?B?SS84T1orQ1hQRWlQRmpTTFhHSDhnRkdMV3JxcERZRi9EdWZxR20zaTNYTERK?= =?utf-8?B?NVNTdDdIaDNuemhvc2J2cFJMQnk0WThFcURDcmszU3FrK3pHd0gweG1WeUlN?= =?utf-8?B?QWFqVTZBcllJOFpNcXdoQXhYNWNRVlZDQk1jSGdJRHZOTjRlcDZ5SzJhcnh6?= =?utf-8?B?dWcvSSs3UDBrMG9LTUNvRE5nQ0dJdlpLV3BlOG9xTFA4UUVoN2tsVUVQUkti?= =?utf-8?B?NHBtSHdKdytHRTl3L3lGQXhXWWxreEJmcUtsL1NNeWdVMjF0OTRTR0E2Z0hr?= =?utf-8?B?TUQvR0V4Y3Z5K2hYNnlVMUV0a2UvbTQ0Q1BvYitEZXlsbkRHay9Lb1lVdU94?= =?utf-8?B?SG9ZV0RXR00xc05OcXExaFl6WmgwNUNmRnk4ZjI5Q3d4WWpWTE5qNHhZNG9v?= =?utf-8?B?bWlId1M0aXZsQ0lNUjF3QkRpc0VXalowQlp2OEJtLzIvMm52SmxyK1doT0N1?= =?utf-8?B?MVpIbmxiNHNTejRnQ3hVejZJRjlYZHo4MUtTcCtVVm5BcWtoTlphUXhHVmlH?= =?utf-8?B?eXVVMFY3QnpWeU1KU1RJeVJqRFpoQjVTbHNlTG1iT3ZESlk1QzlSamk2amtu?= =?utf-8?B?SVVBMFpZVnlHeUJtU3pIOGhkSEd3RWdmc1BWZ1ovUE01Q2pONk9hVFBGWnVj?= =?utf-8?B?VVVSM3ZDRG9qTnpxUkIreldoV0RPSnEyK1AyUnNyMXhiTmNRQzZXOEpvWHBl?= =?utf-8?B?d3hyUkorWFQwUjAwa2ZESFhRV2JvVG9RZkZNS3FqT0xBek1KSnd2eTBvSEJK?= =?utf-8?B?OGdpNVlwZEhETmVqd3RpR2QwZTk1K1hNaTI0aytlTm4wMitrQmFJbGVsc3Yy?= =?utf-8?B?b1ljd0kvZzNJaTVGTHd5aUQ5cWZBOWpBVHJZckw4Wk5XaDJoQ3RoSUhQQ1Yz?= =?utf-8?B?a3J3RHNodGpkVU1SaERFUFFFbmZZdnRycjl5MXBIUWVZQlA3Q0w5RmZrRGJI?= =?utf-8?B?ZEJYS2ZlenZLQmpCK1p1djFObEFEM1hGSDh1VTJrMkV6QmpRNDk3WENHdDhV?= =?utf-8?B?L3Q5bkw1QU9pK1pxekt2dEMzSjdvUlNhWEpKaDJpTm83WFRyMURSNklIMHZs?= =?utf-8?B?THdaVk1kQ1RlMGRUM2s5eDVkQk9zd2tkYWlxVFZsVnFSVUdtRDFZamR2WW5Y?= =?utf-8?B?ek9BS1lVbHlCNEdIckxjdUlaY2RjTllscjlDUi9xTndBSGZBTW1RZVM0bFZQ?= =?utf-8?B?a0E9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1778ee8d-b8eb-4825-9f68-08dad9bde999 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 08:18:12.1457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XYYK79J624tZTmUPZEcAprEV+cJs4mPMS759bWEX9OyG1YsMT/ENrM0oPg/rXpnLWhmyhDH7GqFxWp0gP9DxYoSc2fZfIe4nrQvQb5Hy6J0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5609 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The reset flag in the query structure are cleared by mistake, cause the flow count never be reset, so the query API will always has count value even the flow has stopped, and this will cause the flow never been aged. Fixes: 30ecce522732 ("net/nfp: support flow API") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- V2: * cc to stable * revise the logic --- drivers/net/nfp/nfp_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 6f79d950db..d1d209ce13 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -3809,6 +3809,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev, struct rte_flow *nfp_flow, void *data) { + bool reset; uint32_t ctx_id; struct rte_flow *flow; struct nfp_flow_priv *priv; @@ -3823,6 +3824,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev, } query = (struct rte_flow_query_count *)data; + reset = query->reset; memset(query, 0, sizeof(*query)); ctx_id = rte_be_to_cpu_32(nfp_flow->payload.meta->host_ctx_id); @@ -3834,7 +3836,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev, query->bytes = stats->bytes; query->hits_set = 1; query->bytes_set = 1; - if (query->reset != 0) { + if (reset) { stats->pkts = 0; stats->bytes = 0; } -- 2.29.3