From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8B79DA0543;
	Wed, 14 Dec 2022 01:16:20 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1EAF64021D;
	Wed, 14 Dec 2022 01:16:20 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 8FA2D4003F
 for <dev@dpdk.org>; Wed, 14 Dec 2022 01:16:18 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id A1C8B20B879F; Tue, 13 Dec 2022 16:16:17 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A1C8B20B879F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1670976977;
 bh=i9OMVfk08E2r9PhRt2yXSoUAxOUDOvuVlV9xjU0GBAw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=QpJAH5f/ALkqUCO8aqpoT3czxSjGO4MohqC/nzWnBqxVQphkiuBmz8JoGte0xcJDD
 Mggad6f38+iHkKme0DvN3xTZa+CzGlJa1iHbsTnxDTI8Ny3Q9QTH4Q9FHWqpUT4hZd
 /LbR2gg7/uoJ29VTTyB3PGqvw/iwxgh/IJWVmac4=
Date: Tue, 13 Dec 2022 16:16:17 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org,
 david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: help with pthread_t deprecation / api changes
Message-ID: <20221214001617.GA30757@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20221130225427.GA13682@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <5885133.UjTJXf6HLC@thomas>
 <20221213173843.GA8640@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <3905723.ZaRXLXkqSa@thomas>
 <98CBD80474FA8B44BF855DF32C47DC35D87595@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87595@smartserver.smartshare.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Dec 13, 2022 at 09:39:24PM +0100, Morten Brørup wrote:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, 13 December 2022 20.34
> > 
> > 13/12/2022 18:38, Tyler Retzlaff:
> > > Okay, just one final confirmation. This is what we would like?
> > >
> > > * completely remove the existing rte_thread_getname api.
> > >     - by implication this means remove the 1 use of it in eal in
> > >       logging.
> > >
> > > * introduce a new void rte_thread_set_name(rte_thread_t, const char
> > *name)
> > >   that:
> > >     - returns void (does not fail), but in cases it can be detected
> > will
> > >       log a DEBUG level log message.
> > >     - quietly truncates the name (if longer) to
> > RTE_MAX_THREAD_NAME_LEN on
> > >       all platforms.
> 
> Consider also DEBUG logging if truncating the name. Your choice - do or don't is fine with me.

will do.

> 
> > >     - document that it is best effort and only works if the stars
> > align
> > >       for the target platform.
> > >
> > > * there will be no unit test, since the set doesn't fail and there is
> > no
> > >   get to validate the set.
> > >
> > > once i get confirmation i'll update the series.
> > 
> > Just my opinion: this proposal is my preference, yes.
> > What others think?
> 
> LGTM.

okay, i'll re-spin the series and send a v2.

thanks