From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 385B3A0543; Wed, 14 Dec 2022 17:52:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2ADF34021D; Wed, 14 Dec 2022 17:52:43 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id D6FBE400D6 for ; Wed, 14 Dec 2022 17:52:41 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id 65so4861077pfx.9 for ; Wed, 14 Dec 2022 08:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/0k7m97FY8lenpFEy60qq4WqOZGzAoztXsOUJyr+1mU=; b=qywnCm7w0PNhrFeGve1HCLpr4wmLqYs2jjL2MTGEO8uEG5Q8nUzwB61MTCHxEFllvK 49AeecEw8XYv8w9y3ccZb/fTZnBHuBKgNC4UEL2pWXES51rlYaK2FXuRIhm0+wZmT0s1 lGVuk9Tual2fRlMOFyFCkkMHx24N6ThqnQT2zj1Cil4EXkpgKse7G5xWimbw414k4Ni8 k5BHWR8Z/2vDfD3vygg49le9KIsPa4tJxOv10W6oJSj99OU3G7QiWzU8QWblPpu1ydCo ZJj71wqs1l8bThiEs13ZGOAjjoLQXLnTC7KskgN62V/yJ1R93eQ9GMULm5Ur2Hm0mCnq 4pKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/0k7m97FY8lenpFEy60qq4WqOZGzAoztXsOUJyr+1mU=; b=ioN1kDwc0eIQv6fV2bT3X3UABC4TZvV72w7+XKcBnIl6DK8+LN3gKraBVpzIn/14ML vw+rlNQHAYix+VEwKDWo/SSG/Tg4pGGKWACbax5Rsp+aFetOKw4BDE0VnhuZuhDDAl+E GaSVc2pkeTmV0MbiETCGJRBNkeZkbl68drShd/286IikWXpRpnGUxbYTmfr63M7E5Vqp 5kb4eFCosShKP8nk/T3pF7NAhBlSHrjj7xF7N+Ar8MLIUfy1ytSZ5MJrZBmijPGLQEXc 1OwDDQiIl/d8oHcd0v1v+W4wMYVsM1VjxAFPTX6bCc26g3gUK/EX9KR5I2afxIfw45BL 0CJw== X-Gm-Message-State: ANoB5pmXWmaenJzDEA/6tXWxqBabBH23eb/IFffBz+/7EdUxfghC1gDR cZlm0JiIi7mPT+crZAgWUPBC889cwbwyEAD90cs= X-Google-Smtp-Source: AA0mqf5dYxJlccRqH2AJ7mUCI9gNzmlslRcwAB+wK+8GqIm4Cg/BRfuUQR+nUiX79qSVQWsHdhemmA== X-Received: by 2002:a62:8783:0:b0:577:9d32:b30f with SMTP id i125-20020a628783000000b005779d32b30fmr32108038pfe.15.1671036760990; Wed, 14 Dec 2022 08:52:40 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b62-20020a621b41000000b005743b5ebd7csm115778pfb.92.2022.12.14.08.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 08:52:40 -0800 (PST) Date: Wed, 14 Dec 2022 08:52:39 -0800 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, dmitry.kozliuk@gmail.com Subject: Re: [PATCH 1/2] eal: add missing call marking memory config complete Message-ID: <20221214085239.22dd8113@hermes.local> In-Reply-To: <1670287169-15325-2-git-send-email-roretzla@linux.microsoft.com> References: <1670287169-15325-1-git-send-email-roretzla@linux.microsoft.com> <1670287169-15325-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 5 Dec 2022 16:39:28 -0800 Tyler Retzlaff wrote: > Memory configuration was not being marked as completed add the missing > call to rte_eal_init() for Windows. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/windows/eal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c > index adb929a..56fadc7 100644 > --- a/lib/eal/windows/eal.c > +++ b/lib/eal/windows/eal.c > @@ -462,6 +462,9 @@ enum rte_proc_type_t > */ > rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MAIN); > rte_eal_mp_wait_lcore(); > + > + eal_mcfg_complete(); > + > return fctret; > } > Should this have a Fixes tag? Reviewed-by: Stephen Hemminger