From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00012A0543; Wed, 14 Dec 2022 18:38:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F8DC40684; Wed, 14 Dec 2022 18:38:47 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A964B400D6 for ; Wed, 14 Dec 2022 18:38:46 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id ED14E20B87CE; Wed, 14 Dec 2022 09:38:45 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ED14E20B87CE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1671039525; bh=ilG2/esA9Au3XhFqkEUDGTKsoOr/0f7v7ACMQqLeMck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LlLFKhLVOX4yn+CqTmk2Xwly+7GtvEoMLvRvYxfGZ6H80jsWj+fz2RGYWDEDJWxVl RC1JJJAX2ij2/XommdG1//siMHDlpGyPm68pXkdzGV3ljWE5fSzMifBUHiAhU447Uc uZRrq8F+IpACWn6SnASRRWw6d1zfmK+XlbTgH5/Y= Date: Wed, 14 Dec 2022 09:38:45 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64 Message-ID: <20221214173845.GC31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20221213182730.97065-1-bruce.richardson@intel.com> <20221213182730.97065-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221213182730.97065-3-bruce.richardson@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 13, 2022 at 06:27:25PM +0000, Bruce Richardson wrote: > For future standardization on the "uint" name for unsigned values rather > than the existing "u64" one, we can for now: > * rename all internal values to use uint rather than u64 > * add new function names to alias the existing u64 ones > > Suggested-by: Morten Brørup > Signed-off-by: Bruce Richardson > --- > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++++++++++++++++++++++ > lib/telemetry/telemetry.c | 16 +++++++-------- > lib/telemetry/telemetry_data.c | 28 ++++++++++++++++++-------- > lib/telemetry/telemetry_data.h | 4 ++-- > lib/telemetry/version.map | 7 +++++++ > 5 files changed, 73 insertions(+), 18 deletions(-) > > diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h > index c2ad65effe..60877dae0a 100644 > --- a/lib/telemetry/rte_telemetry.h > +++ b/lib/telemetry/rte_telemetry.h > @@ -8,6 +8,8 @@ > #ifndef _RTE_TELEMETRY_H_ > #define _RTE_TELEMETRY_H_ > > +#include > + > #ifdef __cplusplus > extern "C" { > #endif > @@ -121,6 +123,22 @@ int > rte_tel_data_add_array_int(struct rte_tel_data *d, int x); > > /** when adding __rte_experimental api i have been asked to add the following boilerplate documentation block. i'm not pushing it, just recalling it is what i get asked for, so in case it's something we do? see lib/eal/include/rte_thread.h as an example ``` * @warning * @b EXPERIMENTAL: this API may change without prior notice. ``` > + * Add an unsigned value to an array. > + * The array must have been started by rte_tel_data_start_array() with > + * RTE_TEL_UINT_VAL as the type parameter. > + * > + * @param d > + * The data structure passed to the callback > + * @param x > + * The number to be returned in the array > + * @return > + * 0 on success, negative errno on error > + */ > +__rte_experimental > +int > +rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x); > +