* [PATCH] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices
@ 2022-12-06 12:50 Abhishek Maheshwari
2022-12-06 12:55 ` [PATCH v2] " Abhishek Maheshwari
0 siblings, 1 reply; 9+ messages in thread
From: Abhishek Maheshwari @ 2022-12-06 12:50 UTC (permalink / raw)
To: xiao.w.wang
Cc: dev, stable, chenbo.xia, purna.chandra.mandal, Abhishek Maheshwari
Fixing the match table for vdpa/ifcvf driver because as per the Virtio
device specification, drivers MAY match any PCI Subsystem Vendor ID and
any PCI Subsystem Device ID value.
Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device")
Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device")
Cc: stable@dpdk.org
Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
---
drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 49d68ad1b1..214d6e1f60 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
{ .class_id = RTE_CLASS_ANY_ID,
.vendor_id = IFCVF_VENDOR_ID,
.device_id = IFCVF_NET_MODERN_DEVICE_ID,
- .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
- .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
+ .subsystem_vendor_id = RTE_PCI_ANY_ID,
+ .subsystem_device_id = RTE_PCI_ANY_ID,
},
{ .class_id = RTE_CLASS_ANY_ID,
@@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
{ .class_id = RTE_CLASS_ANY_ID,
.vendor_id = IFCVF_VENDOR_ID,
.device_id = IFCVF_BLK_MODERN_DEVICE_ID,
- .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
- .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
+ .subsystem_vendor_id = RTE_PCI_ANY_ID,
+ .subsystem_device_id = RTE_PCI_ANY_ID,
},
{ .vendor_id = 0, /* sentinel */
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices
2022-12-06 12:50 [PATCH] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Abhishek Maheshwari
@ 2022-12-06 12:55 ` Abhishek Maheshwari
2022-12-08 13:08 ` Wang, Xiao W
2022-12-15 3:42 ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
0 siblings, 2 replies; 9+ messages in thread
From: Abhishek Maheshwari @ 2022-12-06 12:55 UTC (permalink / raw)
To: xiao.w.wang
Cc: dev, stable, chenbo.xia, purna.chandra.mandal, Abhishek Maheshwari
Fixing the match table for vdpa/ifcvf driver because as per the Virtio
device specification, for modern virtio devices, drivers MAY match any
PCI Subsystem Vendor ID and any PCI Subsystem Device ID value.
Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device")
Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device")
Cc: stable@dpdk.org
Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
---
drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 49d68ad1b1..214d6e1f60 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
{ .class_id = RTE_CLASS_ANY_ID,
.vendor_id = IFCVF_VENDOR_ID,
.device_id = IFCVF_NET_MODERN_DEVICE_ID,
- .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
- .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
+ .subsystem_vendor_id = RTE_PCI_ANY_ID,
+ .subsystem_device_id = RTE_PCI_ANY_ID,
},
{ .class_id = RTE_CLASS_ANY_ID,
@@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
{ .class_id = RTE_CLASS_ANY_ID,
.vendor_id = IFCVF_VENDOR_ID,
.device_id = IFCVF_BLK_MODERN_DEVICE_ID,
- .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
- .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
+ .subsystem_vendor_id = RTE_PCI_ANY_ID,
+ .subsystem_device_id = RTE_PCI_ANY_ID,
},
{ .vendor_id = 0, /* sentinel */
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices
2022-12-06 12:55 ` [PATCH v2] " Abhishek Maheshwari
@ 2022-12-08 13:08 ` Wang, Xiao W
2022-12-09 2:37 ` Pei, Andy
2022-12-15 3:42 ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
1 sibling, 1 reply; 9+ messages in thread
From: Wang, Xiao W @ 2022-12-08 13:08 UTC (permalink / raw)
To: Maheshwari, Abhishek
Cc: dev, stable, Xia, Chenbo, Mandal, Purna Chandra, Pei, Andy
Hi Abhishek,
Please see comments inline.
BRs,
Xiao
> -----Original Message-----
> From: Maheshwari, Abhishek <abhishek.maheshwari@intel.com>
> Sent: Tuesday, December 6, 2022 8:55 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> Mandal, Purna Chandra <purna.chandra.mandal@intel.com>; Maheshwari,
> Abhishek <abhishek.maheshwari@intel.com>
> Subject: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio
> devices
>
> Fixing the match table for vdpa/ifcvf driver because as per the Virtio
> device specification, for modern virtio devices, drivers MAY match any
> PCI Subsystem Vendor ID and any PCI Subsystem Device ID value.
Here the "drivers" refers to virtio driver, not vdpa driver.
With below change, this vdpa/ifc driver would hit the standard virtio device which can't 100% match this driver.
>
> Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device")
> Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device")
> Cc: stable@dpdk.org
>
> Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
> ---
> drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 49d68ad1b1..214d6e1f60 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> { .class_id = RTE_CLASS_ANY_ID,
> .vendor_id = IFCVF_VENDOR_ID,
> .device_id = IFCVF_NET_MODERN_DEVICE_ID,
> - .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> - .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
> + .subsystem_vendor_id = RTE_PCI_ANY_ID,
> + .subsystem_device_id = RTE_PCI_ANY_ID,
> },
>
> { .class_id = RTE_CLASS_ANY_ID,
> @@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> { .class_id = RTE_CLASS_ANY_ID,
> .vendor_id = IFCVF_VENDOR_ID,
> .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> - .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> - .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
> + .subsystem_vendor_id = RTE_PCI_ANY_ID,
> + .subsystem_device_id = RTE_PCI_ANY_ID,
> },
>
> { .vendor_id = 0, /* sentinel */
> --
> 2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices
2022-12-08 13:08 ` Wang, Xiao W
@ 2022-12-09 2:37 ` Pei, Andy
0 siblings, 0 replies; 9+ messages in thread
From: Pei, Andy @ 2022-12-09 2:37 UTC (permalink / raw)
To: Wang, Xiao W, Maheshwari, Abhishek
Cc: dev, stable, Xia, Chenbo, Mandal, Purna Chandra
Hi Abhishek,
I agree with Xiao.
I think it will be better you just add subvendor and subdevice you want to be take care of by this vdpa driver.
> -----Original Message-----
> From: Wang, Xiao W <xiao.w.wang@intel.com>
> Sent: Thursday, December 8, 2022 9:09 PM
> To: Maheshwari, Abhishek <Abhishek.Maheshwari@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo <Chenbo.Xia@intel.com>;
> Mandal, Purna Chandra <Purna.Chandra.Mandal@intel.com>; Pei, Andy
> <andy.pei@intel.com>
> Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio
> devices
>
> Hi Abhishek,
>
> Please see comments inline.
>
> BRs,
> Xiao
>
> > -----Original Message-----
> > From: Maheshwari, Abhishek <abhishek.maheshwari@intel.com>
> > Sent: Tuesday, December 6, 2022 8:55 PM
> > To: Wang, Xiao W <xiao.w.wang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> > Mandal, Purna Chandra <purna.chandra.mandal@intel.com>; Maheshwari,
> > Abhishek <abhishek.maheshwari@intel.com>
> > Subject: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern
> > virtio devices
> >
> > Fixing the match table for vdpa/ifcvf driver because as per the Virtio
> > device specification, for modern virtio devices, drivers MAY match any
> > PCI Subsystem Vendor ID and any PCI Subsystem Device ID value.
>
> Here the "drivers" refers to virtio driver, not vdpa driver.
> With below change, this vdpa/ifc driver would hit the standard virtio device
> which can't 100% match this driver.
>
> >
> > Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device")
> > Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
> > ---
> > drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 49d68ad1b1..214d6e1f60 100644
> > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> > @@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> > { .class_id = RTE_CLASS_ANY_ID,
> > .vendor_id = IFCVF_VENDOR_ID,
> > .device_id = IFCVF_NET_MODERN_DEVICE_ID,
> > - .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> > - .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
> > + .subsystem_vendor_id = RTE_PCI_ANY_ID,
> > + .subsystem_device_id = RTE_PCI_ANY_ID,
> > },
> >
> > { .class_id = RTE_CLASS_ANY_ID,
> > @@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> > { .class_id = RTE_CLASS_ANY_ID,
> > .vendor_id = IFCVF_VENDOR_ID,
> > .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> > - .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> > - .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
> > + .subsystem_vendor_id = RTE_PCI_ANY_ID,
> > + .subsystem_device_id = RTE_PCI_ANY_ID,
> > },
> >
> > { .vendor_id = 0, /* sentinel */
> > --
> > 2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices
2022-12-06 12:55 ` [PATCH v2] " Abhishek Maheshwari
2022-12-08 13:08 ` Wang, Xiao W
@ 2022-12-15 3:42 ` Abhishek Maheshwari
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
1 sibling, 1 reply; 9+ messages in thread
From: Abhishek Maheshwari @ 2022-12-15 3:42 UTC (permalink / raw)
To: xiao.w.wang
Cc: dev, stable, chenbo.xia, purna.chandra.mandal, Abhishek Maheshwari
Ammending the match table for vdpa/ifcvf driver to work with virtio-blk
devices that have default subsystem IDs.
Cc: stable@dpdk.org
Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
---
v3:
* Removing match with ANY_IDs
* Adding support for only default subsystem IDs
v2:
* commit message update
---
drivers/vdpa/ifc/base/ifcvf.h | 1 +
drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
2 files changed, 8 insertions(+)
diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
index 3726da7a33..04c81c8196 100644
--- a/drivers/vdpa/ifc/base/ifcvf.h
+++ b/drivers/vdpa/ifc/base/ifcvf.h
@@ -20,6 +20,7 @@
#define IFCVF_SUBSYS_DEVICE_ID 0x001A
#define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001
#define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002
+#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000
#define IFCVF_MAX_QUEUES 32
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 49d68ad1b1..edc6db545d 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
.subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
},
+ { .class_id = RTE_CLASS_ANY_ID,
+ .vendor_id = IFCVF_VENDOR_ID,
+ .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
+ .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
+ .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID,
+ }, /* virtio-blk devices with default subsystem IDs */
+
{ .vendor_id = 0, /* sentinel */
},
};
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices
2022-12-15 3:42 ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
@ 2022-12-15 3:48 ` Abhishek Maheshwari
2022-12-16 1:58 ` Pei, Andy
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Abhishek Maheshwari @ 2022-12-15 3:48 UTC (permalink / raw)
To: xiao.w.wang
Cc: dev, stable, chenbo.xia, purna.chandra.mandal, Abhishek Maheshwari
Amending the match table for vdpa/ifcvf driver to work with virtio-blk
devices that have default subsystem IDs.
Cc: stable@dpdk.org
Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
---
v3:
* Removing match with ANY_IDs
* Adding support for only default subsystem IDs
v2:
* commit message update
---
drivers/vdpa/ifc/base/ifcvf.h | 1 +
drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
2 files changed, 8 insertions(+)
diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
index 3726da7a33..04c81c8196 100644
--- a/drivers/vdpa/ifc/base/ifcvf.h
+++ b/drivers/vdpa/ifc/base/ifcvf.h
@@ -20,6 +20,7 @@
#define IFCVF_SUBSYS_DEVICE_ID 0x001A
#define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001
#define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002
+#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000
#define IFCVF_MAX_QUEUES 32
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 49d68ad1b1..edc6db545d 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
.subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
},
+ { .class_id = RTE_CLASS_ANY_ID,
+ .vendor_id = IFCVF_VENDOR_ID,
+ .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
+ .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
+ .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID,
+ }, /* virtio-blk devices with default subsystem IDs */
+
{ .vendor_id = 0, /* sentinel */
},
};
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
@ 2022-12-16 1:58 ` Pei, Andy
2023-01-19 14:09 ` Maxime Coquelin
2023-02-03 14:57 ` Maxime Coquelin
2 siblings, 0 replies; 9+ messages in thread
From: Pei, Andy @ 2022-12-16 1:58 UTC (permalink / raw)
To: Maheshwari, Abhishek, Wang, Xiao W
Cc: dev, stable, Xia, Chenbo, Mandal, Purna Chandra, Maheshwari, Abhishek
Hi
Code looks good to me.
> -----Original Message-----
> From: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
> Sent: Thursday, December 15, 2022 11:48 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo <Chenbo.Xia@intel.com>;
> Mandal, Purna Chandra <Purna.Chandra.Mandal@intel.com>; Maheshwari,
> Abhishek <Abhishek.Maheshwari@intel.com>
> Subject: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-
> blk devices
>
> Amending the match table for vdpa/ifcvf driver to work with virtio-blk
> devices that have default subsystem IDs.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
>
> ---
> v3:
> * Removing match with ANY_IDs
> * Adding support for only default subsystem IDs
>
> v2:
> * commit message update
> ---
> drivers/vdpa/ifc/base/ifcvf.h | 1 +
> drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index 3726da7a33..04c81c8196 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -20,6 +20,7 @@
> #define IFCVF_SUBSYS_DEVICE_ID 0x001A
> #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001
> #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002
> +#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000
>
> #define IFCVF_MAX_QUEUES 32
>
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 49d68ad1b1..edc6db545d 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] =
> {
> .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
> },
>
> + { .class_id = RTE_CLASS_ANY_ID,
> + .vendor_id = IFCVF_VENDOR_ID,
> + .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> + .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> + .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID,
> + }, /* virtio-blk devices with default subsystem IDs */
> +
> { .vendor_id = 0, /* sentinel */
> },
> };
> --
> 2.31.1
Acked-by: Andy Pei <andy.pei@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
2022-12-16 1:58 ` Pei, Andy
@ 2023-01-19 14:09 ` Maxime Coquelin
2023-02-03 14:57 ` Maxime Coquelin
2 siblings, 0 replies; 9+ messages in thread
From: Maxime Coquelin @ 2023-01-19 14:09 UTC (permalink / raw)
To: Abhishek Maheshwari, xiao.w.wang
Cc: dev, stable, chenbo.xia, purna.chandra.mandal
Hi Abhishek,
On 12/15/22 04:48, Abhishek Maheshwari wrote:
> Amending the match table for vdpa/ifcvf driver to work with virtio-blk
> devices that have default subsystem IDs.
>
> Cc: stable@dpdk.org
Is that really a fix? If so, you need to add the Fixes tag so that LTS
maintainers know on which LTS it applies.
Other than that:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
If you provide me with the faulty commit, I can add it when applying.
Thanks,
Maxime
Thanks,
Maxime
>
> Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
>
> ---
> v3:
> * Removing match with ANY_IDs
> * Adding support for only default subsystem IDs
>
> v2:
> * commit message update
> ---
> drivers/vdpa/ifc/base/ifcvf.h | 1 +
> drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index 3726da7a33..04c81c8196 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -20,6 +20,7 @@
> #define IFCVF_SUBSYS_DEVICE_ID 0x001A
> #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001
> #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002
> +#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000
>
> #define IFCVF_MAX_QUEUES 32
>
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 49d68ad1b1..edc6db545d 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
> },
>
> + { .class_id = RTE_CLASS_ANY_ID,
> + .vendor_id = IFCVF_VENDOR_ID,
> + .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> + .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> + .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID,
> + }, /* virtio-blk devices with default subsystem IDs */
> +
> { .vendor_id = 0, /* sentinel */
> },
> };
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
2022-12-16 1:58 ` Pei, Andy
2023-01-19 14:09 ` Maxime Coquelin
@ 2023-02-03 14:57 ` Maxime Coquelin
2 siblings, 0 replies; 9+ messages in thread
From: Maxime Coquelin @ 2023-02-03 14:57 UTC (permalink / raw)
To: Abhishek Maheshwari, xiao.w.wang
Cc: dev, stable, chenbo.xia, purna.chandra.mandal
On 12/15/22 04:48, Abhishek Maheshwari wrote:
> Amending the match table for vdpa/ifcvf driver to work with virtio-blk
> devices that have default subsystem IDs.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
>
> ---
> v3:
> * Removing match with ANY_IDs
> * Adding support for only default subsystem IDs
>
> v2:
> * commit message update
> ---
> drivers/vdpa/ifc/base/ifcvf.h | 1 +
> drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-03 14:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-06 12:50 [PATCH] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Abhishek Maheshwari
2022-12-06 12:55 ` [PATCH v2] " Abhishek Maheshwari
2022-12-08 13:08 ` Wang, Xiao W
2022-12-09 2:37 ` Pei, Andy
2022-12-15 3:42 ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
2022-12-16 1:58 ` Pei, Andy
2023-01-19 14:09 ` Maxime Coquelin
2023-02-03 14:57 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).