* [PATCH 1/2] ci: sort packages
@ 2022-12-15 9:19 David Marchand
2022-12-15 9:19 ` [PATCH 2/2] ci: align Ubuntu and Fedora build coverage David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2022-12-15 9:19 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana
This list is hard to read.
Updating it has been done in an inconsistent way: container based and vm
based builds do not have the same coverage.
Prefer alphabetical order.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Note: I will likely squash this patch with the second one, but it is
easier to review in this form.
---
.github/workflows/build.yml | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6bad94098e..de9a28608c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -93,14 +93,14 @@ jobs:
- name: Update APT cache
run: sudo apt update || true
- name: Install packages
- run: sudo apt install -y ccache libnuma-dev python3-setuptools
- python3-wheel python3-pip python3-pyelftools ninja-build libbsd-dev
- libpcap-dev libibverbs-dev libcrypto++-dev libfdt-dev libjansson-dev
- libarchive-dev
+ run: sudo apt install -y ccache libarchive-dev libbsd-dev libcrypto++-dev
+ libfdt-dev libibverbs-dev libjansson-dev libnuma-dev libpcap-dev
+ ninja-build python3-pip python3-pyelftools python3-setuptools
+ python3-wheel
- name: Install libabigail build dependencies if no cache is available
if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true'
- run: sudo apt install -y autoconf automake libtool pkg-config libxml2-dev
- libdw-dev
+ run: sudo apt install -y autoconf automake libdw-dev libtool libxml2-dev
+ pkg-config
- name: Install i386 cross compiling packages
if: env.BUILD_32BIT == 'true'
run: sudo apt install -y gcc-multilib g++-multilib
@@ -174,10 +174,10 @@ jobs:
run: docker exec -i dpdk dnf update -y
- name: Install packages
if: steps.image_cache.outputs.cache-hit != 'true'
- run: docker exec -i dpdk dnf install -y ccache numactl-devel
- python3-setuptools python3-wheel python3-pip python3-pyelftools
- ninja-build libatomic libbpf-devel libfdt-devel libpcap-devel
- openssl-devel rdma-core-devel zlib-devel
+ run: docker exec -i dpdk dnf install -y ccache libatomic libbpf-devel
+ libfdt-devel libpcap-devel ninja-build numactl-devel openssl-devel
+ python3-pip python3-pyelftools python3-setuptools python3-wheel
+ rdma-core-devel zlib-devel
- name: Save image in cache
if: steps.image_cache.outputs.cache-hit != 'true'
run: |
@@ -248,10 +248,10 @@ jobs:
- name: Update
run: docker exec -i dpdk dnf update -y || true
- name: Install packages
- run: docker exec -i dpdk dnf install -y ccache numactl-devel
- python3-setuptools python3-wheel python3-pip python3-pyelftools
- ninja-build libatomic libbpf-devel libfdt-devel libpcap-devel
- openssl-devel rdma-core-devel zlib-devel ${{ matrix.config.compiler }}
+ run: docker exec -i dpdk dnf install -y ccache libatomic libbpf-devel
+ libfdt-devel libpcap-devel ninja-build numactl-devel openssl-devel
+ python3-pip python3-pyelftools python3-setuptools python3-wheel
+ rdma-core-devel zlib-devel ${{ matrix.config.compiler }}
- name: Run setup
run: docker exec -i dpdk .ci/linux-setup.sh
- name: Build
--
2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] ci: align Ubuntu and Fedora build coverage
2022-12-15 9:19 [PATCH 1/2] ci: sort packages David Marchand
@ 2022-12-15 9:19 ` David Marchand
2023-02-06 11:26 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2022-12-15 9:19 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana
Some dependencies were missing for builds in those two environments:
- for Ubuntu 20.04: libssl-dev, zlib1g-dev,
- for Fedora 35: libarchive-devel, libbsd-devel, jansson-devel,
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
.github/workflows/build.yml | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index de9a28608c..154be70cc1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -93,10 +93,10 @@ jobs:
- name: Update APT cache
run: sudo apt update || true
- name: Install packages
- run: sudo apt install -y ccache libarchive-dev libbsd-dev libcrypto++-dev
- libfdt-dev libibverbs-dev libjansson-dev libnuma-dev libpcap-dev
+ run: sudo apt install -y ccache libarchive-dev libbsd-dev libfdt-dev
+ libibverbs-dev libjansson-dev libnuma-dev libpcap-dev libssl-dev
ninja-build python3-pip python3-pyelftools python3-setuptools
- python3-wheel
+ python3-wheel zlib1g-dev
- name: Install libabigail build dependencies if no cache is available
if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true'
run: sudo apt install -y autoconf automake libdw-dev libtool libxml2-dev
@@ -174,10 +174,11 @@ jobs:
run: docker exec -i dpdk dnf update -y
- name: Install packages
if: steps.image_cache.outputs.cache-hit != 'true'
- run: docker exec -i dpdk dnf install -y ccache libatomic libbpf-devel
- libfdt-devel libpcap-devel ninja-build numactl-devel openssl-devel
- python3-pip python3-pyelftools python3-setuptools python3-wheel
- rdma-core-devel zlib-devel
+ run: docker exec -i dpdk dnf install -y ccache jansson-devel
+ libarchive-devel libatomic libbsd-devel libbpf-devel libfdt-devel
+ libpcap-devel ninja-build numactl-devel openssl-devel python3-pip
+ python3-pyelftools python3-setuptools python3-wheel rdma-core-devel
+ zlib-devel
- name: Save image in cache
if: steps.image_cache.outputs.cache-hit != 'true'
run: |
@@ -248,10 +249,12 @@ jobs:
- name: Update
run: docker exec -i dpdk dnf update -y || true
- name: Install packages
- run: docker exec -i dpdk dnf install -y ccache libatomic libbpf-devel
- libfdt-devel libpcap-devel ninja-build numactl-devel openssl-devel
- python3-pip python3-pyelftools python3-setuptools python3-wheel
- rdma-core-devel zlib-devel ${{ matrix.config.compiler }}
+ run: docker exec -i dpdk dnf install -y ccache jansson-devel
+ libarchive-devel libatomic libbsd-devel libbpf-devel libfdt-devel
+ libpcap-devel ninja-build numactl-devel openssl-devel python3-pip
+ python3-pyelftools python3-setuptools python3-wheel rdma-core-devel
+ zlib-devel
+ ${{ matrix.config.compiler }}
- name: Run setup
run: docker exec -i dpdk .ci/linux-setup.sh
- name: Build
--
2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ci: align Ubuntu and Fedora build coverage
2022-12-15 9:19 ` [PATCH 2/2] ci: align Ubuntu and Fedora build coverage David Marchand
@ 2023-02-06 11:26 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-02-06 11:26 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Aaron Conole, Michael Santana
15/12/2022 10:19, David Marchand:
> Some dependencies were missing for builds in those two environments:
> - for Ubuntu 20.04: libssl-dev, zlib1g-dev,
> - for Fedora 35: libarchive-devel, libbsd-devel, jansson-devel,
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Series applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-06 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 9:19 [PATCH 1/2] ci: sort packages David Marchand
2022-12-15 9:19 ` [PATCH 2/2] ci: align Ubuntu and Fedora build coverage David Marchand
2023-02-06 11:26 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).