From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73797A0543; Thu, 15 Dec 2022 18:58:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 235FA40E50; Thu, 15 Dec 2022 18:58:06 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8777040695 for ; Thu, 15 Dec 2022 18:58:04 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id C131E2048D65; Thu, 15 Dec 2022 09:58:03 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C131E2048D65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1671127083; bh=+ZubcGsTjA9i5vfxY/NBFEZXpNu9GSWdIAmbSwLoVAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o4Z3lgJjBY27hqYAgo1yttw1hWCmW0mtVfsmyPGLGnLQsTkkdvOBqL1u7c9vsmP1l wO+WKKi9RLevzs7/7lNvjuPKfbC29z4FLqY6mhHHOEtnB8Xe8W8FoVXmt+lIfaGB+j TlrUkdpC41QAxrwx08t1rU1zEpezIzGNpamLF5eQ= Date: Thu, 15 Dec 2022 09:58:03 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, Morten =?iso-8859-1?Q?Br=F8rup?= , thomas@monjalon.net, david.marchand@redhat.com Subject: Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64 Message-ID: <20221215175803.GC17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20221213182730.97065-1-bruce.richardson@intel.com> <20221213182730.97065-3-bruce.richardson@intel.com> <20221214173845.GC31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 15, 2022 at 09:44:49AM +0000, Bruce Richardson wrote: > On Wed, Dec 14, 2022 at 09:38:45AM -0800, Tyler Retzlaff wrote: > > On Tue, Dec 13, 2022 at 06:27:25PM +0000, Bruce Richardson wrote: > > > For future standardization on the "uint" name for unsigned values rather > > > than the existing "u64" one, we can for now: > > > * rename all internal values to use uint rather than u64 > > > * add new function names to alias the existing u64 ones > > > > > > Suggested-by: Morten Brørup > > > Signed-off-by: Bruce Richardson > > > --- > > > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++++++++++++++++++++++ > > > lib/telemetry/telemetry.c | 16 +++++++-------- > > > lib/telemetry/telemetry_data.c | 28 ++++++++++++++++++-------- > > > lib/telemetry/telemetry_data.h | 4 ++-- > > > lib/telemetry/version.map | 7 +++++++ > > > 5 files changed, 73 insertions(+), 18 deletions(-) > > > > > > diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h > > > index c2ad65effe..60877dae0a 100644 > > > --- a/lib/telemetry/rte_telemetry.h > > > +++ b/lib/telemetry/rte_telemetry.h > > > @@ -8,6 +8,8 @@ > > > #ifndef _RTE_TELEMETRY_H_ > > > #define _RTE_TELEMETRY_H_ > > > > > > +#include > > > + > > > #ifdef __cplusplus > > > extern "C" { > > > #endif > > > @@ -121,6 +123,22 @@ int > > > rte_tel_data_add_array_int(struct rte_tel_data *d, int x); > > > > > > /** > > > > when adding __rte_experimental api i have been asked to add the > > following boilerplate documentation block. i'm not pushing it, just > > recalling it is what i get asked for, so in case it's something we do? > > see lib/eal/include/rte_thread.h as an example > > > > > > ``` > > * @warning > > * @b EXPERIMENTAL: this API may change without prior notice. > > ``` > > > > Ok, thanks for the notice. > > Actually, related to this, since we are adding these functions as aliases > for existing stable functions, I would like to see these being added not as > experimental. The reason for that, is that while they are experimental, we > cannot feasibly mark the old function names as deprecated. :-( seems reasonable to me, if they're just aliases and they haven't churned then i don't see a reason why they need to spend time being experimental. > > Adding Thomas and David on CC for their thoughts. > > /Bruce