From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9434CA0543;
	Thu, 15 Dec 2022 19:07:35 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 339C940695;
	Thu, 15 Dec 2022 19:07:35 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 4D52A40685
 for <dev@dpdk.org>; Thu, 15 Dec 2022 19:07:33 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 85B662048D6D; Thu, 15 Dec 2022 10:07:32 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 85B662048D6D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1671127652;
 bh=ZBp0LNQ2Guf/9SGufS4KughtVcWqGLEIho/naS/pvFs=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=mn/t7SyRWxX4s/w0YCT+OkuItCJlnZbjRTrPhEavTj7BwjJDHquxscV116dSlYR4s
 VnCG/8zie8dWGS7t5Qy1yDhnHHYpGKxFwh7z1QpemkHEzQ7AITvusKvR7pOvqFhFNp
 Pwv+SNk6eB+W612CIpte6k98aTqpw8z4BswWqCyI=
Date: Thu, 15 Dec 2022 10:07:32 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com,
 Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] eal: add missing call marking memory config complete
Message-ID: <20221215180732.GE17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1670287169-15325-1-git-send-email-roretzla@linux.microsoft.com>
 <1670287169-15325-2-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8z-r5E=wKWu7N+=LmkKFDH-5=Px7VpcHtaFP0iRuwcu9A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8z-r5E=wKWu7N+=LmkKFDH-5=Px7VpcHtaFP0iRuwcu9A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Dec 15, 2022 at 10:59:07AM +0100, David Marchand wrote:
> On Tue, Dec 6, 2022 at 1:39 AM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Memory configuration was not being marked as completed add the missing
> > call to rte_eal_init() for Windows.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> The change is ok.
> 
> The commitlog misses some context: I guess the point is to let
> rte_thread_register work on Windows.

oh i guess i better provide a better message. the reason is i want to
run the test_ctrl_thread() (in test_lcores.c) which is an api available
on windows. maybe when i add the replacement control thread creation it
should be moved to / live in test_threads.c?

it is nice as a side-effect it did pick up that the mcfg hadn't been
marked as done. (though i understand that's not the purpose of the
test).

i'll have another whack at changing the log.

> So we can mark this change as:
> Fixes: 5c307ba2a5b1 ("eal: register non-EAL threads as lcores")
> 
> WDYT?

yep, v2 will fix the message & the Fixes tag.

> 
> 
> In any case, this change won't fix anything related to mp.
> If mp is supported one day on Windows, other calls to eal_mcfg* would
> be required.

agreed.

> 
> -- 
> David Marchand