From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84272A034C; Thu, 22 Dec 2022 10:27:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CF9F40698; Thu, 22 Dec 2022 10:27:47 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A0E86400D7 for ; Thu, 22 Dec 2022 10:27:45 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BM7Mp6p015823; Thu, 22 Dec 2022 01:27:43 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=nAoCe50bf6bUW3XFFVPMJYJ3KckzfbW0/BAdGd3K30c=; b=Gw9P4AhsuyZwxbAn9i/kXzXgFdilnMRzxV2Flp51ES5XCgXYjyY2IoNWQrUvkkQQwcZF shSVDWUs4JsaA935+zBZUIOeDKasT9Ktv3tYCrQWBJ/ownxTl6ejH8AKRL3zHFKCkd1+ VFOMqJB3fekAf+2A4Ty6QYr5iSY/JhA8OyTztk68PEdnwsAYbB5GDmcGc70rkbykKb+U 79n5rHwPUOkbw1I2zC1r7YXmtEZrQx+OKdKoeIM7EwrlO7y4Slq6TR4wreG7wAk0QOPT CxK95qo7PJefd0t9561/IUFA0I3Lvf8VmveY58Ny8aCwl7hiWTmC5gJFZnuxQEud8vch nQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3mm79c3stv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 01:25:28 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 22 Dec 2022 01:25:26 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Thu, 22 Dec 2022 01:25:26 -0800 Received: from BG-LT92004.corp.innovium.com (unknown [10.193.66.59]) by maili.marvell.com (Postfix) with ESMTP id 87AB13F705D; Thu, 22 Dec 2022 01:25:22 -0800 (PST) From: Anoob Joseph To: Thomas Monjalon , Akhil Goyal , Jerin Jacob , Konstantin Ananyev , Bernard Iremonger CC: Hemant Agrawal , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , "Kiran Kumar K" , Volodymyr Fialko , , Olivier Matz Subject: [PATCH 0/5] lib: add pdcp protocol Date: Thu, 22 Dec 2022 14:55:17 +0530 Message-ID: <20221222092522.1628-1-anoobj@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221027052140.155-1-anoobj@marvell.com> References: <20221027052140.155-1-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: I5yUsSg5CVKmn6pngtFS8MsQmR0v5LlZ X-Proofpoint-GUID: I5yUsSg5CVKmn6pngtFS8MsQmR0v5LlZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-22_03,2022-12-21_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following options, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4. Uplink data compression 5. Ciphering and integrity protection PDCP library provides following control path APIs that is used to configure various PDCP entities, 1. rte_pdcp_entity_establish() 2. rte_pdcp_entity_suspend() 3. rte_pdcp_entity_release() PDCP process is split into 2 parts. One before crypto processing (rte_pdcp_pkt_pre_process()) and one after crypto processing (rte_pdcp_pkt_post_process()). Since cryptodev dequeue can return crypto operations belonging to multiple entities, rte_pdcp_pkt_crypto_group() is added to help grouping crypto operations belonging to same entity. Similar to lib IPsec, lib PDCP would allow application to use same API sequence while leveraging protocol offload features enabled by rte_security library. Lib PDCP would internally change the handles registered for *pre_process* and *post_process* based on features enabled in the entity. Lib PDCP would create the required sessions on the device provided in entity to minimize the application requirements. Also, the crypto_op allocation and free would also be done internally by lib PDCP to allow the library to create crypto ops as required for the input packets. For example, when control PDUs are received, no cryptodev enqueue-dequeue is expected for the same and lib PDCP is expected to handle it differently. Changes from RFC - Implementation for all APIs covering basic control plane & user plane packets - Unit test leveraging existing PDCP vectors available in test_cryptodev - Unit test performing both UL & DL operations to verify various protocol features - Updated documentation Changes planned for next version - Add APIs for rte_pdcp_entity_re_establish, rte_pdcp_entity_reconfigure - Framework to handle control PDUs - Eventdev based timer integration for t-Reordering & discardTimer - Integration with reorder library to handle in-order delivery Sample application sequence: struct rte_mbuf **out_mb, *pkts[MAX_BURST_SIZE]; struct rte_crypto_op *cop[MAX_BURST_SIZE]; struct rte_pdcp_group grp[MAX_BURST_SIZE]; struct rte_pdcp_entity *pdcp_entity; int nb_max_out_mb, ret, nb_grp; /* Create PDCP entity */ pdcp_entity = rte_pdcp_entity_establish(&conf); /** * Allocate buffer for holding mbufs returned during PDCP suspend, * release & post-process APIs. */ /* Max packets that can be cached in entity + burst size */ nb_max_out_mb = pdcp_entity->max_pkt_cache + 1; out_mb = rte_malloc(NULL, nb_max_out_mb * sizeof(uintptr_t), 0); if (out_mb == NULL) { /* Handle error */ } while (1) { /* Receive packet and form mbuf */ /** * Prepare packets for crypto operation. Following operations * would be done, * * Transmitting entity/UL (only data PDUs): * - Perform compression * - Assign sequence number * - Add PDCP header * - Create & prepare crypto_op * - Prepare IV for crypto operation (auth_gen, encrypt) * - Save original PDCP SDU (during PDCP re-establishment, * unconfirmed PDCP SDUs need to crypto processed again and * transmitted/re-transmitted) * * Receiving entity/DL: * - Any control PDUs received would be processed and * appropriate actions taken. If data PDU, continue. * - Determine sequence number (based on HFN & per packet SN) * - Prepare crypto_op * - Prepare IV for crypto operation (decrypt, auth_verify) */ nb_success = rte_pdcp_pkt_pre_process(pdcp_entity, pkts, cop, nb_rx, &nb_err); if (nb_err != 0) { /* Handle error packets */ } if ((rte_cryptodev_enqueue_burst(dev_id, qp_id, cop, nb_success) != nb_success) { /* Retry for enqueue failure packets */ } ... ret = rte_cryptodev_dequeue_burst(dev_id, qp_id, cop, MAX_BURST_SIZE); if (ret == 0) continue; /** * Received a burst of completed crypto ops from cryptodev. It * may belong to various entities. Group similar ones together * for entity specific post-processing. */ /** * Groups similar entities together. Frees crypto op and based * on crypto_op status, set mbuf->ol_flags which would be * checked in rte_pdcp_pkt_post_process(). */ nb_grp = rte_pdcp_pkt_crypto_group(cop, pkts, grp, ret); for (i = 0; i != nb_grp; i++) { /** * Post process packets after crypto completion. * Following operations would be done, * * Transmitting entity/UL: * - Check crypto result * * Receiving entity/DL: * - Check crypto operation status * - Check for duplication (if yes, drop duplicate) * - Perform decompression * - Trim PDCP header * - Hold packet (SDU) for in-order delivery (return * completed packets as and when sequence is * completed) * - If not in sequence, cache the packet and start * t-Reordering timer. When timer expires, the * packets need to delivered to upper layers (not * treated as error packets). */ nb_success = rte_pdcp_pkt_post_process(grp[i].id.ptr, grp[i].m, out_mb, grp[i].cnt, &nb_err); if (nb_err != 0) { /* Handle error packets */ } /* Perform additional operations */ /** * Tranmitting entity/UL * - If duplication is enabled, duplicate PDCP PDUs * - When lower layers confirm reception of a PDCP PDU, * it should be communicated to PDCP layer so that * PDCP can drop the corresponding SDU */ } } Anoob Joseph (3): lib: add pdcp protocol app/test: add lib pdcp tests doc: add PDCP library guide Volodymyr Fialko (2): net: add PDCP header app/test: pdcp HFN tests in combined mode app/test/meson.build | 1 + app/test/test_cryptodev.h | 3 + app/test/test_pdcp.c | 999 ++++++++++++++ doc/api/doxy-api-index.md | 4 +- doc/api/doxy-api.conf.in | 1 + .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pdcp_lib.rst | 211 +++ lib/meson.build | 1 + lib/net/meson.build | 1 + lib/net/rte_pdcp_hdr.h | 93 ++ lib/pdcp/meson.build | 8 + lib/pdcp/pdcp_crypto.c | 240 ++++ lib/pdcp/pdcp_crypto.h | 20 + lib/pdcp/pdcp_entity.h | 218 +++ lib/pdcp/pdcp_process.c | 1195 +++++++++++++++++ lib/pdcp/pdcp_process.h | 13 + lib/pdcp/rte_pdcp.c | 136 ++ lib/pdcp/rte_pdcp.h | 263 ++++ lib/pdcp/rte_pdcp_group.h | 133 ++ lib/pdcp/version.map | 13 + 21 files changed, 3554 insertions(+), 1 deletion(-) create mode 100644 app/test/test_pdcp.c create mode 100644 doc/guides/prog_guide/img/pdcp_functional_overview.svg create mode 100644 doc/guides/prog_guide/pdcp_lib.rst create mode 100644 lib/net/rte_pdcp_hdr.h create mode 100644 lib/pdcp/meson.build create mode 100644 lib/pdcp/pdcp_crypto.c create mode 100644 lib/pdcp/pdcp_crypto.h create mode 100644 lib/pdcp/pdcp_entity.h create mode 100644 lib/pdcp/pdcp_process.c create mode 100644 lib/pdcp/pdcp_process.h create mode 100644 lib/pdcp/rte_pdcp.c create mode 100644 lib/pdcp/rte_pdcp.h create mode 100644 lib/pdcp/rte_pdcp_group.h create mode 100644 lib/pdcp/version.map -- 2.25.1