From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 658D51B2EC for ; Mon, 6 Nov 2017 16:58:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1102B20CDD; Mon, 6 Nov 2017 10:58:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 10:58:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LQMjyD4jtCfZMRcO0do4Rfq7AG aPUzCbel2xk994KBY=; b=htX/rrowrDdWDP19hYPNwxILiGZoe4NHCZMJWCFPyp ZpUmc/63lsjhccm2NoPiloZ1blT2kt2K+iKh5UdR+fa78N/DMCedL4ndwC3hTnjm Jd8/KJqPk+7q4vpBZ0LXEFTVB4dbA+LrXJNb5jei9ytN+0Y2tsdlWorPNEFKOBf2 o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LQMjyD 4jtCfZMRcO0do4Rfq7AGaPUzCbel2xk994KBY=; b=RlptFVQThGTgAPN2oU1gzX aW4GCyomggz1QV3sPczJWUNg6P7R3qRo8s/mvWaQvw7RZjf1trH5j92PXv9OALLQ JxBsjkvbjgGQRTOMRfNvvvdKXO/jVHBCf5t2Gko0ce2Z+QlNdXxYVsEpnkhFGtzk OvnpGhOV/yoRtkZjdabJHPIPVSTv8FIWS6BYZbwkW4b63lxdJOagh3bILfZm27wC Bg6tR/Hdwm9cqy+Ck9JRTfWQd91cTXK2PoYM0IX7HyS3wRC9DYYTF5TDhyFyYAAE 5qXLqQv+Bc+rcB8x59Aj0+MD3aYBxC1Fvs/5MC4b6ReGxi/gpWNv77M5EuUWyp1A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BD2F97E6B8; Mon, 6 Nov 2017 10:58:14 -0500 (EST) From: Thomas Monjalon To: Olivier MATZ Cc: Santosh Shukla , sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org Date: Mon, 06 Nov 2017 16:58:13 +0100 Message-ID: <2022205.xxQWC8C0TJ@xps> In-Reply-To: <20171106154930.f4ax36mllm45ion4@platinum> References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <20171106014141.13266-11-thomas@monjalon.net> <20171106154930.f4ax36mllm45ion4@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 10/15] mempool: rename populate functions to IOVA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 15:58:15 -0000 06/11/2017 16:49, Olivier MATZ: > On Mon, Nov 06, 2017 at 02:41:36AM +0100, Thomas Monjalon wrote: > > The functions rte_mempool_populate_phys() and > > rte_mempool_populate_phys_tab() are renamed to > > rte_mempool_populate_iova() and rte_mempool_populate_iova_tab(). > > The deprecated functions are kept as aliases to avoid breaking the API. > > > > Signed-off-by: Thomas Monjalon > > I agree with the changes of that patch too. > However, after the patches, few references to phys address still > remain in rte_mempool.h. Some examples below: > > /** Mempool over one chunk of physically continuous memory */ > #define MEMPOOL_PG_NUM_DEFAULT 1 > ... > * The memory chunks where objects are stored. Each chunk is virtually > * and physically contiguous. > ... > #define MEMPOOL_F_NO_PHYS_CONTIG 0x0020 /**< Don't need physically contiguous objs. */ > /** > * This capability flag is advertised by a mempool handler, if the whole > * memory area containing the objects must be physically contiguous. > * Note: This flag should not be passed by application. > */ > #define MEMPOOL_F_CAPA_PHYS_CONTIG 0x0040 > ... > * - Mempool driver must also set MEMPOOL_F_CAPA_PHYS_CONTIG flag along with > * MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS. > ... > * - Otherwise, rte_mempool_populate_phys fails thus pool create fails. > ... > * - MEMPOOL_F_NO_PHYS_CONTIG: If set, allocated objects won't > * necessarily be contiguous in physical memory. > ... > ... > > I think we should also change them to IO. Yes I did not change them because I was not sure how to word it. Feel free to send a patch for the flags and few other doxygen comments. Thanks