From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com,
Michael Santana <maicolgabriel@hotmail.com>,
Lincoln Lavoie <lylavoie@iol.unh.edu>,
Owen Hilyard <ohilyard@iol.unh.edu>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH] ci: remove outdated default reference tag for ABI
Date: Wed, 09 Feb 2022 14:37:55 +0100 [thread overview]
Message-ID: <2022216.KlZ2vcFHjT@thomas> (raw)
In-Reply-To: <f7t8rul8kfu.fsf@redhat.com>
08/02/2022 16:08, Aaron Conole:
> Thomas Monjalon <thomas@monjalon.net> writes:
>
> > The variable REF_GIT_TAG is set in the CI configuration
> > like .travis.yml or .github/workflows/build.yml.
> > The default value is outdated and probably unused.
> > It is removed completely to avoid forgetting an update in future.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> I think the default was there for labs that run the build script
> manually. Maybe there are no such users, though. I believe the lab has
> its own script for doing such ABI checks (but can't remember off the top
> of my head).
>
> CC'd Lincoln and Owen just to confirm.
>
> Assuming the UNH/other lab doesn't use this feature of the linux build
> script,
>
> Acked-by: Aaron Conole <aconole@redhat.com>
I could also remove this variable:
LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6}
It is confusing to see an old version here,
while we use the version 1.8.
If no objection, I'll send a v2.
next prev parent reply other threads:[~2022-02-09 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 13:47 Thomas Monjalon
2022-02-08 15:08 ` Aaron Conole
2022-02-08 22:03 ` Brandon Lo
2022-02-09 13:37 ` Thomas Monjalon [this message]
2022-02-09 14:04 ` David Marchand
2022-03-01 9:56 ` [PATCH v2] ci: remove outdated default versions for ABI check Thomas Monjalon
2022-03-01 10:07 ` David Marchand
2022-03-06 9:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2022216.KlZ2vcFHjT@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=lylavoie@iol.unh.edu \
--cc=maicolgabriel@hotmail.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).