From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96D2CA0579; Thu, 8 Apr 2021 17:54:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52E15141122; Thu, 8 Apr 2021 17:54:31 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id ADA384068B for ; Thu, 8 Apr 2021 17:54:29 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 54ADA5C013F; Thu, 8 Apr 2021 11:54:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 08 Apr 2021 11:54:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= R9LyOO0fGNAL+LGilPb7cQ4wjAef7zmf+2f0oqynYIs=; b=pqtALYOPZnxNE0We HppMUGI02jKnLspLUsWxKE46wjkShF8QVb0Yqwpmr+BVO7Hhzx6/T+4I8g4Tsz67 zLSflNqc/EuGVJBekbgooWb/XOUIt3BFBpIUavy/CalTe3hMhHLNh+/H5nP3A88K jzB4a0wsYIRZojstPylfNERSwGbKwoiZpRsY/weF3vbso1VFPOzfFLjDjZcj7nsn cPUHVFY2zGnCFFBc3Qkaywx/rx6FfCevDnOLTK5ZzniPxLRPfaCqQqWwLRliHKzF K48xCSuK4iAEGfVeoJB9dTMFTmOXfBQuCFU4aFAg4SkAbCn1jcQB9o5VztE6sv6v WEoNMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=R9LyOO0fGNAL+LGilPb7cQ4wjAef7zmf+2f0oqynY Is=; b=wL2g9Qi5R4V5q2A8scvUzCRtOA9GeWXzFxNfMKTRmOlJBYEBklMDnpCF7 VOkoCHFtRaiY+BJ0pMjftXJ8Tru0Et6XyjVSfYT7TQAMR9QUEHz8IsaIIPcWMYW9 CoVb0r72WW32uvGnZBoNQQz83PBx9SyAyyUkX1wJQWKCuJ7gnSm9SggFapDu7h4V b0yo4EXi16jV3t0zYJO+9hxkAk9U3APDF6+Pslyr/SngfCjxGnB2iY8VeOwjvoIu 4ij9V1HWH1RKqdfZlHXupbQamqPXHre/pYQfj3eDpnQOvRc/8K7LWTtx7BUXBhDR PJ/+58yxR/S20I1t6yG7JI/lq5/eQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejledgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 315071080057; Thu, 8 Apr 2021 11:54:26 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, arybchenko@solarflare.com, l.wojciechow@partner.samsung.com, Ilya Maximets Date: Thu, 08 Apr 2021 17:54:25 +0200 Message-ID: <20224994.fzTK4MuzM9@thomas> In-Reply-To: <20210324103213.29922-3-david.marchand@redhat.com> References: <20200626114751.22523-1-david.marchand@redhat.com> <20210324103213.29922-1-david.marchand@redhat.com> <20210324103213.29922-3-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/3] log: track log level changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/03/2021 11:32, David Marchand: > Add a log message when registering log types and changing log levels. [...] > + RTE_LOG(DEBUG, EAL, "%s logtype level changed from %s to %s\n", I would prefer "foo log level changed" instead of "foo logtype level changed". Opinions? > + rte_logs.dynamic_types[type].name == NULL ? > + "" : rte_logs.dynamic_types[type].name, In which case the logtype name is undefined? If it is unexexpected, should we have "unknown" instead of ""?