From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0141FA00C2; Wed, 4 Jan 2023 11:01:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DB1240A82; Wed, 4 Jan 2023 11:01:23 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id AC14F40697; Wed, 4 Jan 2023 11:01:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672826482; x=1704362482; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=b3hDKXU0v9kwntNP+KMSWD/AphOrydyt96CMoKkZcBM=; b=bq+A4J49+u6SkNbOFQK4ySw7j/L/zxhwUmVch8uUA/yiosTcgtQp+Z79 bq4KEieFAf9vD33wjxmRJC3c/mRncbG2zQ9R/h6kGyv6Jz0jaUXIRXt8q bSI4ON0qDbxgSAbC52Jzx8mFfHkQx8Wr9Ci2D0lGJwxpDAA4WXZONMCDm qdOiWubOEshcB16Vrt8zMg7WR6naiiOGYuem6s4Hc41VeeQ9o3XzitLPw mHnv/8mU9fT3i5Oj6T/BlsoAD+ZTeGDIrQdpoLGCiBNBDlaD2S6+qCcX1 KSMpDe1k9WC5SeCllHJ+Fa4e/ooFhQZW42mXJyYi9Z4QQq928uuOMGLD7 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="408155806" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="408155806" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 02:01:19 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="743795430" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="743795430" Received: from unknown (HELO root..) ([10.239.252.111]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 02:01:16 -0800 From: Shiyang He To: dev@dpdk.org Cc: yidingx.zhou@intel.com, Shiyang He , stable@dpdk.org, Qiming Yang , Wenjun Wu , Remy Horton Subject: [PATCH] net/ixgbe: fix ixgbe firmware version get Date: Wed, 4 Jan 2023 09:51:42 +0000 Message-Id: <20230104095142.86796-1-shiyangx.he@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The firmware version obtained by dpdk-ethtool is inconsistent with that obtained by linux-ethtool. This commit fixes the issue. Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") Cc: stable@dpdk.org Signed-off-by: Shiyang He --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ae9f65b334..012096021e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3859,7 +3859,7 @@ ixgbe_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size) ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh); ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl); - etrack_id = (eeprom_verh << 16) | eeprom_verl; + etrack_id = (eeprom_verl << 16) | eeprom_verh; ret = snprintf(fw_version, fw_size, "0x%08x", etrack_id); if (ret < 0) return -EINVAL; -- 2.34.1