From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 844FBA00C2; Fri, 6 Jan 2023 17:41:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E1B240141; Fri, 6 Jan 2023 17:41:28 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 99BF1400EF for ; Fri, 6 Jan 2023 17:41:27 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id y1so2201155plb.2 for ; Fri, 06 Jan 2023 08:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jM4gq7T0nY6EIL03f8JwskQTLRsU7S6ARFiA3E7vww8=; b=rYWFUqrrkUxMiioOV5HxYnAwoFORvaZTiyjM1rR85HuEZvZVeFMMzXJCrmEMWbfLT/ v5nVQIYx1cI6/c/qIrtS9BgzZEFWJhTbPnJzHEwi/kU7VjJ4st5FZkdrgs50mfQArJq4 b8FgkmAuugJdGDi9zuTb6gvCtidBTdrFZZN++R7vd7mZNp8Cc8lZwKZYTzTPCSEHm0c2 hqcPd08z7PnwwHQNCQ9eiZPy6J+VppEgZVwNpRpXS6dTfvpoTJ5+qe5GVjW3dSJInVYb DS8ePZckyoCbxziNH2zlmVyj7s+8tFB1XLRJ152mgY6PERpgfUyQ+bb8Hk290o+VoXVH AEXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jM4gq7T0nY6EIL03f8JwskQTLRsU7S6ARFiA3E7vww8=; b=LFjp221uUkukJLYLNg+ODJmUpRLt5PMsEYrJQzc3FHPcngfCo7sf6hZsS91OQyGScd JVIh2BkCaXKzPEoVMW0WcyvINWHPNaHk0Fmcj6f7xDWbVnxTV8Vn9FWHsVVRN00cl37n LNgP9sfRAhqIN/WYLZh1V0EOQlaT/u6k5IwPOeiT1I3uSNJhaRrDan6pcPVe4G+PKOWi KV0mzwIxH+2RqIYAuOv4wHMFqvKUcsoUu3d83uM/5oonGXEwrHG8NShYQxiptuocHWP9 H+IJS+cgBRYuhnFzq3RXeWciVVzCTFpHF2lEt+gw4avFh4mMaixHU+zhZOBcrZFhJeex GbuA== X-Gm-Message-State: AFqh2kqVaasThmc7tcuiZ8zzbithtcZYVcYIu0t4cZwm9QcdpUQvipAF GsI5JZTTsntuD5uCYYy+c8Bmhw== X-Google-Smtp-Source: AMrXdXuv58zOixbN5mxxVD1xg3zxGYde4N2KYil01PYAPVu6+1wEma4wZStHPA66eNizgNQLGmsytQ== X-Received: by 2002:a17:902:8a82:b0:192:f79e:79dd with SMTP id p2-20020a1709028a8200b00192f79e79ddmr7973320plo.30.1673023286659; Fri, 06 Jan 2023 08:41:26 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id m15-20020a170902db0f00b00189393ab02csm1193143plx.99.2023.01.06.08.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 08:41:26 -0800 (PST) Date: Fri, 6 Jan 2023 08:41:23 -0800 From: Stephen Hemminger To: Amit Prakash Shukla Cc: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "dev@dpdk.org" Subject: Re: [EXT] Re: [RFC PATCH] graph: add support for pcap trace for graph Message-ID: <20230106084123.1d50848e@hermes.local> In-Reply-To: References: <20221223120235.3171516-1-amitprakashs@marvell.com> <20221223084714.446ebc08@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 6 Jan 2023 10:40:30 +0000 Amit Prakash Shukla wrote: > Thanks Stephen for the review. Sure, will use lib/pcapng. > > I see dpdk libpcapng adds most of the debugging data, however I would like to add a node name to the packets which I am thinking of adding using 'comment' option under 'Enhanced Packet Block' . > > Please let me know if that's fine. > > Thanks, > Amit Shukla The pcapng supports comment on file, and the revised version has more interface info. If you want comment on a per-packet basis that should not be a major change. Rather than node name, maybe packet id would be better (epb_packetid)