From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F5B5A00C2; Fri, 6 Jan 2023 21:33:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 100F640141; Fri, 6 Jan 2023 21:33:54 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4102B400EF for ; Fri, 6 Jan 2023 21:33:52 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 7C2E720B92AA; Fri, 6 Jan 2023 12:33:51 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7C2E720B92AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1673037231; bh=E0Tzmki/Y19/a+J25l7n2rIj+7Mzy7WCBpn658JvFQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tL8UiMkbhmdQLxFEPDOpJKG3EL523WKYyaJm4I38GGh5L0I026lIJGqchwdkfs12S QrRBhOIpYKUvLTuvVMIv7Sj+iH6+xg+QlVI++MPm+7yIShilqsgx8uuZL0L+odcyeH lhDayew8Eg/o4FokKsqQz7bziCyDVr1Q/iGCWUJc= Date: Fri, 6 Jan 2023 12:33:51 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: Thomas Monjalon , Ruifeng Wang , Stanislaw Kardach , "dev@dpdk.org" , David Marchand , bluca@debian.org, christian.ehrhardt@canonical.com Subject: Re: [PATCH] build: avoid deprecated function for Meson properties Message-ID: <20230106203351.GC20685@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230104113635.206506-1-thomas@monjalon.net> <3394891.QJadu78ljV@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 06, 2023 at 12:30:38PM +0000, Bruce Richardson wrote: > On Thu, Jan 05, 2023 at 10:14:04AM +0100, Thomas Monjalon wrote: > > 05/01/2023 05:25, Ruifeng Wang: > > > From: Thomas Monjalon > > > > -* Meson (version 0.53.2+) and ninja > > > > +* Meson (version 0.54+) and ninja > > > > > > > meson.build:15 needs update to reflect the version pump. > > > And .ci/linux-setup.sh:7 also defines meson version. But I'm not sure whether this file is still in use. > > > > > > With the changes: > > > Acked-by: Ruifeng Wang > > > > Thanks Ruifeng for the good review. > > It will be fixed in v2. > > > > The question remaining is about distributions support. > > Do we care or rely on pip? > > Why did we recently agree to use 0.53.2? > > > > Do we want to wait a little for using 0.54? > > > Personally I am fine either way. Since using pip is so easy I don't > think we need to be that concerned about distro support. i'm not sure if it is relevant but for windows platform we would generally avoid depending on pip.