From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFBD5423B8; Thu, 12 Jan 2023 17:32:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A524A42D55; Thu, 12 Jan 2023 17:32:09 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 51B6F42D4F for <dev@dpdk.org>; Thu, 12 Jan 2023 17:32:08 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id s13-20020a17090a6e4d00b0022900843652so2599093pjm.1 for <dev@dpdk.org>; Thu, 12 Jan 2023 08:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=C7gSv0q2suOBqX1ic7MV9+lGILZ9ADQGjAm3CW+NqQA=; b=H+QFYIHu0SP2Hk5ycZFRSfI0882rs0itB3iirC1MWVCpjTvez1atMUZbZ7mKujFm75 S2BAV3a7CkcJ1i6YnZTgGXv97Yy4rS9g9Jk+9jaBBQXfv2dzTimwYQsezfNi13kEEilC 76i8qmSmKhJhfw6zaOkkcgUGjFMdT9YhrmAse/mhBaI8rGts0DdiDyU0naj6maku/Waf tgilv7GcfJjJJaGiWXN5NyYwPfp8BhmsPUrMUW65rsTddmrUjw9H2IRztj46LLUMcece tCpApZa6H46y29FimgNtf9N80p/4Sd/JzpXqQ+Lyh4Y98/YbGBiTLLuy9HZ/jFiKujsp VHrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C7gSv0q2suOBqX1ic7MV9+lGILZ9ADQGjAm3CW+NqQA=; b=YK4RdkpANALft60PLAzWpjAt/vkRtaULQ0eaPMIIOBYV2q9q+tnYFAfWJ6bYm4b5NX uhDlkb2jhktfxviiJv6y5LE5wK4+/6dm7M9mb6aLBxSButrvK7i/np8T8bb1fO3+A9SF hw+8BiUPT4E0JGytxlJU3/BbrXP9cz7Zrg/DHkJY/5bHit6gfIZZttJcTmsyZQTesgXd qnqwWfh3v98xYrlr4pZLE/djTr475f0zu6gZZujx1AgAE9aEGmnPcSUqcTM1ohSHvuPV Csi6HE1piBAeVASGvpwy4Y51wk3jHewchaHK53mgX8Zo7OCglFPUmyRSpvloR/mgGojL Bnmw== X-Gm-Message-State: AFqh2koM+DmN/+HWJz6Qvq1kAfD7itZKALBnILgXEEQ8kaODT9nW7rUE pCW/Kn9j5WRPQpqZHm91IotTZw== X-Google-Smtp-Source: AMrXdXuKH8Nm8SLbUuCROaP+RCRtQy/yVqVQ64O86nfImbKrgiH3spVqehD3QaEXVBHg5ju3NVskHA== X-Received: by 2002:a17:902:7d94:b0:194:6432:f15f with SMTP id a20-20020a1709027d9400b001946432f15fmr1546526plm.48.1673541127574; Thu, 12 Jan 2023 08:32:07 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id o6-20020a170902d4c600b0019280bac7a6sm12368646plg.152.2023.01.12.08.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 08:32:07 -0800 (PST) Date: Thu, 12 Jan 2023 08:32:05 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Ke Zhang <ke1x.zhang@intel.com> Cc: qi.z.zhang@intel.com, yuying.zhang@intel.com, dev@dpdk.org Subject: Re: [PATCH v3] net/ice: add devargs for disabling default mac Message-ID: <20230112083205.7798fb75@hermes.local> In-Reply-To: <20230112075538.206709-1-ke1x.zhang@intel.com> References: <20221221035804.1241780-1-ke1x.zhang@intel.com> <20230112075538.206709-1-ke1x.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 12 Jan 2023 15:55:38 +0800 Ke Zhang <ke1x.zhang@intel.com> wrote: > From: "ke1x.zhang" <ke1x.zhang@intel.com> > > Add the feature that support to disable default mac which > will be used by ice driver when setting dpdk_devargs config > field. > > Default mac is not disabled in default, user can > choose to disable the default mac > by setting ``devargs`` parameter ``default-mac-disable``, > > for example:: > -a 80:00.0,default-mac-disable=1 > > Signed-off-by: ke1x.zhang <ke1x.zhang@intel.com> Why is the driver specific option needed? Can't it be handled more generally by the application.