From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09D2E423B8; Thu, 12 Jan 2023 17:30:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC0C342D8B; Thu, 12 Jan 2023 17:30:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 28D4142D6D for ; Thu, 12 Jan 2023 17:30:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673541047; x=1705077047; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bpTVcZvYZrPNsT7YkAVlzox5jsUQcPock+5BXAWCrFM=; b=WEoE2EfruGySh+eb7CrbVrMwX9TC08cdbO3P0hfCWfQIKi/Y5cQBtsb3 MayYTchxQ6RUb5xLSBCkRjD2vcrwvsgyR0fAbJw1EewPHhjpNh/OJyeyb EBR53+fMGs+zWmo9UkqL6HykQ9uWH/pCj0hMKC/k1Or/Ij7aNWgk499fe ofzdoSoIbP11H85tk2oPlyRPPpQZDI1T72Mw7MNO4e/mXHQpKkf9V5iz3 fjKFakYL0McuGuJ3lwKQW6Cs10hDQNJ6KW1jYwqTkIsYzBl3n7V9EDA5H w0lN5I+dGsl2JzWzHLL3jIuH3C8K6tlPMnOqv9XRhNM+Dr5pidtksnCB5 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="307298285" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="307298285" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 08:30:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="721151304" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="721151304" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by fmsmga008.fm.intel.com with ESMTP; 12 Jan 2023 08:30:46 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v7 4/4] eventdev/timer: change eventdev reconfig logic Date: Thu, 12 Jan 2023 10:30:35 -0600 Message-Id: <20230112163035.1970151-4-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20230112163035.1970151-1-s.v.naga.harish.k@intel.com> References: <20230104064145.2600261-1-s.v.naga.harish.k@intel.com> <20230112163035.1970151-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application is no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for timer adapter when the adapter is created using above mentioned api. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * fix build error in documentation v3: * update doxygen v4: * fix programmer guide v5: * update doxygen as per review comments v6: * fix adapter cretae logic with correct event port id v7: * updated 23.03 release notes --- --- doc/guides/prog_guide/event_timer_adapter.rst | 18 +++++++++++++++ doc/guides/rel_notes/release_23_03.rst | 10 ++++++++ lib/eventdev/rte_event_timer_adapter.c | 23 +++++++++++-------- lib/eventdev/rte_event_timer_adapter.h | 14 +++++++++++ 4 files changed, 55 insertions(+), 10 deletions(-) diff --git a/doc/guides/prog_guide/event_timer_adapter.rst b/doc/guides/prog_guide/event_timer_adapter.rst index d7307a29bb..b5cd95fef1 100644 --- a/doc/guides/prog_guide/event_timer_adapter.rst +++ b/doc/guides/prog_guide/event_timer_adapter.rst @@ -139,6 +139,24 @@ This function is passed a callback function that will be invoked if the adapter needs to create an event port, giving the application the opportunity to control how it is done. +Event device configuration for service based adapter +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +When rte_event_timer_adapter_create() is used for creating +adapter instance, ``rte_event_dev_config::nb_event_ports`` is +automatically incremented, and the event device is reconfigured with +additional event port during service initialization. +This event device reconfigure logic also increments the +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +Application no longer needs to account for the +``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for timer adapter in event device configuration, +when the adapter is created using the above-mentioned API. + Adapter modes ^^^^^^^^^^^^^ An event timer adapter can be configured in either periodic or non-periodic mode diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index b8c5b68d6c..1815604598 100644 --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst @@ -55,6 +55,16 @@ New Features Also, make sure to start the actual text at the margin. ======================================================= +* **Updated the eventdev reconfigure logic for service based adapters.** + + * This eventdev reconfig logic is enhanced to increment the + ``rte_event_dev_config::nb_single_link_event_port_queues`` + parameter if event port config is of type + ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * With this change, the application no longer needs to account for the + ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter + required for adapters. + * This change is added for eth_rx, eth_tx, crypto and timer eventdev adapters. Removed Items ------------- diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index a0f14bf861..66554f13fc 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -88,7 +88,20 @@ default_port_conf_cb(uint16_t id, uint8_t event_dev_id, uint8_t *event_port_id, rte_event_dev_stop(dev_id); port_id = dev_conf.nb_event_ports; + if (conf_arg != NULL) + port_conf = conf_arg; + else { + port_conf = &def_port_conf; + ret = rte_event_port_default_conf_get(dev_id, (port_id - 1), + port_conf); + if (ret < 0) + return ret; + } + dev_conf.nb_event_ports += 1; + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; + ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret < 0) { EVTIM_LOG_ERR("failed to configure event dev %u\n", dev_id); @@ -99,16 +112,6 @@ default_port_conf_cb(uint16_t id, uint8_t event_dev_id, uint8_t *event_port_id, return ret; } - if (conf_arg != NULL) - port_conf = conf_arg; - else { - port_conf = &def_port_conf; - ret = rte_event_port_default_conf_get(dev_id, port_id, - port_conf); - if (ret < 0) - return ret; - } - ret = rte_event_port_setup(dev_id, port_id, port_conf); if (ret < 0) { EVTIM_LOG_ERR("failed to setup event port %u on event dev %u\n", diff --git a/lib/eventdev/rte_event_timer_adapter.h b/lib/eventdev/rte_event_timer_adapter.h index cd10db19e4..e21588bede 100644 --- a/lib/eventdev/rte_event_timer_adapter.h +++ b/lib/eventdev/rte_event_timer_adapter.h @@ -212,6 +212,20 @@ typedef int (*rte_event_timer_adapter_port_conf_cb_t)(uint16_t id, * * This function must be invoked first before any other function in the API. * + * When this API is used for creating adapter instance, + * ``rte_event_dev_config::nb_event_ports`` is automatically incremented, + * and the event device is reconfigured with additional event port during + * service initialization. This event device reconfigure logic also increments + * the ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * Application no longer needs to account for + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for Timer adapter in event device configuration + * when the adapter is created with this API. + * * @param conf * The event timer adapter configuration structure. * -- 2.25.1