From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F076141B61; Sat, 14 Jan 2023 01:36:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B649640156; Sat, 14 Jan 2023 01:36:14 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 913EA40042 for ; Sat, 14 Jan 2023 01:36:13 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so28580307pjj.2 for ; Fri, 13 Jan 2023 16:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dlhj56BamXjPFWANOEJOt+7lLo/V2uuzDxSg0ImgAEc=; b=hm7E3ZzHinuWndx+fom8Ivk1nBvagYE/8CRe5WRiUP1MmFRmV6u7Q9AjDcFRgwe5RP aojv7C49UU48H1IhTXStcaqo72pK+3M46zDedx12ek1mIYskZzfNKr/hfIGuse3XHgkD YmDig26HKdOyL9taBN4rQiiMwpJwb3cOg2cXmRaVFzEcBUDUNrq9OIB0nXZ0yhpPbNLe i9jWzZnjruDRZdbQfWHjO18zp/k/r41tAoFaggMfT9LC39FrFcU52e7ZaYFpyoQtL8IQ TzwD7K5+eEs00ntEafuQTtZn3ImQijyBluvBdM7wcH6zwrSPTnXcjxN6R4qIO7nJVjOH aUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlhj56BamXjPFWANOEJOt+7lLo/V2uuzDxSg0ImgAEc=; b=j2VeCrJ57LAANsarekwngPqbh1jmcirV52JQZgaGhxfYWAu2ZbqeI4agUHo/3JesXU XM02HbcPxniA4oiA7Ju7m/tb5s5t8tU59NNXlWhjlju0NYQbsDB0PaEGviFQSSRfBHG7 rQuSvoEn5ECnlhMc3ktBGljZuKofFkutZ/G/33jZ513rTMMJIp5OhyF2qXCRQPii8o/q qO8bvvfRzMMX7IouTFSqPqXJDAWjmMAAMSkcVvaaNxzPSQ78LcQeliuOMZ1w3NWF9RuJ 6REkklcPrlJuQEaLGeW1monE3nXXQDSMwqYbguv+lP/ckocQnnTL4P6hr5Z9CFnJRNz5 jPiA== X-Gm-Message-State: AFqh2koYKCU5J7tcwY6+4cNPtUwpAfg+045i5Zc22pgRViQnURFkouIW EJbSNfuEkXmKxn7UhuzSR+7l6Q== X-Google-Smtp-Source: AMrXdXum5nQ8AgohL2QKFJGr1jl4mYhBL6XHg3RcGYJYeuy2DziB+xulvTqY6QTF+SUxkUrad5Smgg== X-Received: by 2002:a17:902:76cb:b0:18d:dd85:303c with SMTP id j11-20020a17090276cb00b0018ddd85303cmr11258974plt.8.1673656572204; Fri, 13 Jan 2023 16:36:12 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j1-20020a170902c3c100b0018853416bbcsm14909692plj.7.2023.01.13.16.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 16:36:12 -0800 (PST) Date: Fri, 13 Jan 2023 16:36:10 -0800 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Yipeng Wang , Sameh Gobriel Subject: Re: [PATCH 1/7] member: replace zero length array with flex array Message-ID: <20230113163610.7c43893f@hermes.local> In-Reply-To: <20230114001921.GB24758@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230113215205.125767-1-stephen@networkplumber.org> <20230113215205.125767-2-stephen@networkplumber.org> <20230114001921.GB24758@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 13 Jan 2023 16:19:21 -0800 Tyler Retzlaff wrote: > On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote: > > Zero length arrays are GNU extension. Replace with > > standard flex array. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/member/rte_member_heap.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h > > index 9c4a01aebe95..ab6319bc2de4 100644 > > --- a/lib/member/rte_member_heap.h > > +++ b/lib/member/rte_member_heap.h > > @@ -26,7 +26,7 @@ struct hash { > > uint16_t bkt_cnt; > > uint16_t num_item; > > uint32_t seed; > > - struct hash_bkt buckets[0]; > > + struct hash_bkt buckets[]; > > }; > > > > struct node { > > -- > > i suppose arguably this series depends on the series Bruce is putting > up defaulting the minimum C standard to C99 since technically that's the > minimum needed for the flexible array members. > > Series-acked-by: Tyler Retzlaff > There is already flex array usage in several places in DPDK. Therefore this won't be raising the requirements.