From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9555B41B61;
	Sat, 14 Jan 2023 01:42:48 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 43F4440156;
	Sat, 14 Jan 2023 01:42:48 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 71C9940042
 for <dev@dpdk.org>; Sat, 14 Jan 2023 01:42:46 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id A1AD320DFE22; Fri, 13 Jan 2023 16:42:45 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A1AD320DFE22
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1673656965;
 bh=rpH/1tXvjeKjhadc9i8vYK3NJOqU1pXxeuGsemlDqac=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=ILhWGpU88B+4VxlW8aFpzb+nG03df/zhDBJvN7lMoF/bc62sw3lBwE8OfkS5QSi0f
 hhj61Q8FIJvGppybEglT3T/1+b+zVlGMUdzNbZretbZsjEshVTOCVzeZZYhff5lEcW
 FCRO807TRn1VcdwvPAkO1Q6v0l8FaxDKQgLEQYTM=
Date: Fri, 13 Jan 2023 16:42:45 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Yipeng Wang <yipeng1.wang@intel.com>,
 Sameh Gobriel <sameh.gobriel@intel.com>
Subject: Re: [PATCH 1/7] member: replace zero length array with flex array
Message-ID: <20230114004245.GC24758@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230113215205.125767-1-stephen@networkplumber.org>
 <20230113215205.125767-2-stephen@networkplumber.org>
 <20230114001921.GB24758@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <20230113163610.7c43893f@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230113163610.7c43893f@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Jan 13, 2023 at 04:36:10PM -0800, Stephen Hemminger wrote:
> On Fri, 13 Jan 2023 16:19:21 -0800
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> 
> > On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote:
> > > Zero length arrays are GNU extension. Replace with
> > > standard flex array.
> > > 
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> > >  lib/member/rte_member_heap.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
> > > index 9c4a01aebe95..ab6319bc2de4 100644
> > > --- a/lib/member/rte_member_heap.h
> > > +++ b/lib/member/rte_member_heap.h
> > > @@ -26,7 +26,7 @@ struct hash {
> > >  	uint16_t bkt_cnt;
> > >  	uint16_t num_item;
> > >  	uint32_t seed;
> > > -	struct hash_bkt buckets[0];
> > > +	struct hash_bkt buckets[];
> > >  };
> > >  
> > >  struct node {
> > > --   
> > 
> > i suppose arguably this series depends on the series Bruce is putting
> > up defaulting the minimum C standard to C99 since technically that's the
> > minimum needed for the flexible array members.
> > 
> > Series-acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > 
> 
> There is already flex array usage in several places in DPDK.
> Therefore this won't be raising the requirements.

agreed.