From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 483B4423D9; Sat, 14 Jan 2023 23:21:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E271440156; Sat, 14 Jan 2023 23:21:37 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A0DF440042 for ; Sat, 14 Jan 2023 23:21:36 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id C847520DFE3C; Sat, 14 Jan 2023 14:21:35 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C847520DFE3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1673734895; bh=qHJ0AqqNRYqmDOJ7HUwOFZRjxB4JfwvPj5kO6zp7Tdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kkKxbQTD34gkjh6Fxx4NAr5kHoRDDZWYlV9auJNOgh47EMjTKGP+SSKuK4ufeKlAr uo4oomIfhKd4OQcY7Ra1npzTFrh/nl2nJdTUFKX/JVeM1/dkB13qqE9EdOpUOjbnDW X0cWlrw5McAi21H8Wok3ALCVFra/bgTqvfNnpESM= Date: Sat, 14 Jan 2023 14:21:35 -0800 From: Tyler Retzlaff To: Stephen Hemminger Cc: Thomas Monjalon , dev@dpdk.org, Cristian Dumitrescu , Bruce Richardson , Anatoly Burakov Subject: Re: [RFC] Remove Kernel Network Interface (KNI) Message-ID: <20230114222135.GA1572@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230113050313.87378-1-stephen@networkplumber.org> <2383172.OBFZWjSADL@thomas> <20230113091326.20d210c9@hermes.local> <3142342.SvYEEZNnvj@thomas> <20230113152530.634e6d1e@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113152530.634e6d1e@hermes.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 13, 2023 at 03:25:30PM -0800, Stephen Hemminger wrote: > On Fri, 13 Jan 2023 19:34:24 +0100 > Thomas Monjalon wrote: > > > 13/01/2023 18:13, Stephen Hemminger: > > > On Fri, 13 Jan 2023 09:12:16 +0100 > > > Thomas Monjalon wrote: > > > > > > > 13/01/2023 06:03, Stephen Hemminger: > > > > > The Linux special network driver for kernel networking has been > > > > > a long term problem for DPDK. The performance benefits of KNI > > > > > are available via virtio-user and XDP, and the simpler kernel > > > > > interface via TAP is also available. > > > > > > > > > > This driver has required lots of effort to keep up with the > > > > > kernel API changes. And the overall architecture of the driver > > > > > is fundamentally insecure and has unfixable locking and data > > > > > race problems. No developer has been willing to do extensive > > > > > tests or be the maintainer. > > > > > > > > > > In short, the time has come to do some early spring cleaning > > > > > and remove KNI from DPDK 23.03. > > > > > > > > In doc/guides/rel_notes/deprecation.rst it is announced > > > > to be removed in 23.11. Let's keep this RFC for later :) > > > > > > > > > > > > > > For 23.03 could we add a deprecation log message when library is > > > used and when kernel module is loaded. > > > > We already have a message in the lib: > > > > int > > rte_kni_init(unsigned int max_kni_ifaces __rte_unused) > > { > > RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n"); > > > > It is a good idea to add a message in the kernel module loading. > > > > > > > > > > No matter how much we tell users, guarantee someone will still miss it and complain :-) one of the techniques we use is to remove the headers in advance of removing the ABI. the warning becomes a lot more clear when you can't compile anymore but your existing binaries continue to run.