From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 580D1423F2; Mon, 16 Jan 2023 18:55:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48CB640151; Mon, 16 Jan 2023 18:55:35 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 78E2740151 for ; Mon, 16 Jan 2023 18:55:34 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id g68so19075930pgc.11 for ; Mon, 16 Jan 2023 09:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=osU+dsmsRFXzn+bSN/Rk4naHp3wpmIwrRHEwrjT06w8=; b=s2hMdBxBXml/xZei99T3c54bz2zVDvBnbUUj5n+VV6VfCMNSpguBa/I/0uC5sWFIHH mNBBtdCG1YZBOjremve0xrCAm5hhqZ4WD+pDZ8MQSdKYp6tTsW2xJRPn7drYJp6Dx+Eb rEyZvUsrxZDxzCPYxZyIOsAmLy/hKtpjD0n7MQB/EV3dJ/jzHriYTwZs4fW4I/FxKDhZ XY8XLFCds5xKafLGTP+imnQIMbDlvCKuoUL3ru29RP2pbjdn87vXgmwZ0IYMZAEBmFEk lXNIa2DRsdzgiPYCQIKzu6cmRUX8S3PtcvVoWnPz1o2w2cLT7cNu1FeXEscz63F9CLgd wymg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=osU+dsmsRFXzn+bSN/Rk4naHp3wpmIwrRHEwrjT06w8=; b=XyNIByUsYg7qG7GD3Ya3GvnEBzBs4+Z3GXGFcA8S4KSTI5408NGX8/Tzhbj68okCaM W+bwxSmRhf5lWNsh/JUxV4TREtUtfyhdLzWxg2em4tAZG1xV9CPt4t4DrAytixblogJc Az+nIiLxaRwjfusTHoORJ6CZ++5+WSzTeZhW5QHZt6d156aiYy/7bY2jcRrPSKFZuxmS Vl9RmHpTFRTf9lEHc/J4nBE7xqWxiejddop/f2M+No+UzmWLQJgTgxO/J66VLggHRtYp fIKawxryczq6fTsD2VX9PMP1xFVTzeJL9/9XDTDlzxE40XzPCZOZlknpdogfCQ3kGwW8 1Vvg== X-Gm-Message-State: AFqh2krEnZ8NWt/RTkVLoZMuN+CqUkoRQFKASzxCkTlwvN+H76uiKW9T 6LDcDsFM58fQH2aRIxB7LPMqzg== X-Google-Smtp-Source: AMrXdXsy5f/89/o0SZHZySUCnb0Az5KeGN39fZ8ospeWgJomFmvq8Np6btcQfQ5SiQCBSDGVTHWOlw== X-Received: by 2002:a05:6a00:2ba:b0:576:7fb9:85cc with SMTP id q26-20020a056a0002ba00b005767fb985ccmr405449pfs.14.1673891733688; Mon, 16 Jan 2023 09:55:33 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b75-20020a621b4e000000b0058ba53aaa75sm8194600pfb.99.2023.01.16.09.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 09:55:33 -0800 (PST) Date: Mon, 16 Jan 2023 09:55:31 -0800 From: Stephen Hemminger To: Vipin P R Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Message-ID: <20230116095531.7a84ff1d@hermes.local> In-Reply-To: <1673615963-21216-2-git-send-email-vipinp@vmware.com> References: <1673615963-21216-1-git-send-email-vipinp@vmware.com> <1673615963-21216-2-git-send-email-vipinp@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 13 Jan 2023 13:19:23 +0000 Vipin P R wrote: > In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and VIRTCHNL_OP_ADD_ETH_ADDR are unsupported. > i40evf_execute_vf_cmd is invoked with these operations as part of i40evf_set_mc_addr_list() > > The cases are not handled in i40evf_execute_vf_cmd() thus hitting the default case. > There is a retry logic of upto 200 times (2000 in iavf) with a delay of 10ms (1ms in iavf). > This results in a needless delay of 2s in the init phase for each VNIC. > > The patch aims to rectify that delay. > In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was deleted. Hence adding this in iavf_vchnl.c. > > Cc: stable@dpdk.org > > Signed-off-by: Vipin P R > --- > drivers/net/iavf/iavf_vchnl.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Please run checkpatch, the DPDK style is to indent with tabs not spaces.