From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F186E423F4; Tue, 17 Jan 2023 01:15:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EABB42D22; Tue, 17 Jan 2023 01:15:00 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 563F54067E for ; Tue, 17 Jan 2023 01:14:58 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id bj3so27444977pjb.0 for ; Mon, 16 Jan 2023 16:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FvIBNuwL25YpKK4lJ3AyY38LDT00VejYT2NOllEA7hY=; b=MgefrxHDnbpZr8UY3VjqaWfp77W02ZXZjJc7uUpOMR5346HmbF0H4RHrHzjIMd16f7 vKmRSVryZQOrL0e9qwBcyJ90xWdLJhtvwSco4tgoadY9mx376XL+XxJ9SEXBlLoac71f S7RaEVjdhqQb1GQsPX6N+mLHCfOFKH1HFMESQ/0W/uGKoN/Xodx7ZfvblVF8CxCN56I4 F27ezIF04LyAkaHYDk2srj81xa3NEH4RoxP4ey2VSqFLLWrsvHayQjyyY4pGCLdWnDu3 UQOtj60rWCmhoyMWS+020X2OAozgofqZb3GblLu96NCCuHWD/yz9llssEZiCwymCm80s lcVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FvIBNuwL25YpKK4lJ3AyY38LDT00VejYT2NOllEA7hY=; b=mSHuOvi6eb83JkJgmgmMk9fxSmWqstLSAFvv2vsnDjKG9vrqzT45oFV93LxDFtBkl1 wDqnuyTB9NdXW4I9sLlespOFDWEpmmCVBXzusPnP1A1L+XsIPPPN5RYXpr+e8bJnUp9i LLijGZgW1SP6SagSUCrvEmrbBV8SN+y8IaQcydk24LQnSCj7KxdsLTo63qVkmj9ZzPLZ arojzam0SYYi3dA+C3dTdBZpU1oxxRkZWcw+PHvmyy7snflFx8f4u34c1EpqUZZBtyFz fq1QN5vIWTlC35a6RDOrQpPaSzdfaqZQCBLnIvDuABqojEjaWg61wY4UcpAKNKmmZNl0 y4Nw== X-Gm-Message-State: AFqh2kp3+j1jZeZIbznC4Up/KU3ddKJ1jJ+ob4SQHYPL5rkE4CmNpjpg Jnl0j0k6LaP4ieCahApjhmB12XwLLgqYrZh0vnw= X-Google-Smtp-Source: AMrXdXs7WK5TK0UAiLBMKRzuEQdpPZrDN7xdxeAyYlsQ4RvooiOi5v7DoRKi4lDF2JDJnPBE5lqBvg== X-Received: by 2002:a05:6a20:c189:b0:b8:6168:bc2e with SMTP id bg9-20020a056a20c18900b000b86168bc2emr963014pzb.52.1673914497264; Mon, 16 Jan 2023 16:14:57 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id z24-20020a630a58000000b004790eb3fee1sm15940614pgk.90.2023.01.16.16.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 16:14:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Aman Singh , Yuying Zhang Subject: [PATCH v3 2/7] testpmd: fix whitespace Date: Mon, 16 Jan 2023 16:14:48 -0800 Message-Id: <20230117001453.94082-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230117001453.94082-1-stephen@networkplumber.org> References: <20230116172732.84976-1-stephen@networkplumber.org> <20230117001453.94082-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The style standard is to use blank after keywords. I.e "if (" not "if(" Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 33 +++++++++++++++++---------------- app/test-pmd/parameters.c | 12 +++++++----- app/test-pmd/testpmd.c | 2 +- 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b32dc8bfd445..d2a52ac7b723 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2728,13 +2728,14 @@ parse_reta_config(const char *str, unsigned long int_fld[_NUM_FLD]; char *str_fld[_NUM_FLD]; - while ((p = strchr(p0,'(')) != NULL) { + while ((p = strchr(p0, '(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -3242,15 +3243,15 @@ cmd_config_thresh_parsed(void *parsed_result, if (!strcmp(res->name, "txpt")) tx_pthresh = res->value; - else if(!strcmp(res->name, "txht")) + else if (!strcmp(res->name, "txht")) tx_hthresh = res->value; - else if(!strcmp(res->name, "txwt")) + else if (!strcmp(res->name, "txwt")) tx_wthresh = res->value; - else if(!strcmp(res->name, "rxpt")) + else if (!strcmp(res->name, "rxpt")) rx_pthresh = res->value; - else if(!strcmp(res->name, "rxht")) + else if (!strcmp(res->name, "rxht")) rx_hthresh = res->value; - else if(!strcmp(res->name, "rxwt")) + else if (!strcmp(res->name, "rxwt")) rx_wthresh = res->value; else { fprintf(stderr, "Unknown parameter\n"); @@ -4084,8 +4085,8 @@ cmd_vlan_offload_parsed(void *parsed_result, len = strnlen(str, STR_TOKEN_SIZE); i = 0; /* Get port_id first */ - while(i < len){ - if(str[i] == ',') + while (i < len) { + if (str[i] == ',') break; i++; @@ -4093,7 +4094,7 @@ cmd_vlan_offload_parsed(void *parsed_result, str[i]='\0'; tmp = strtoul(str, NULL, 0); /* If port_id greater that what portid_t can represent, return */ - if(tmp >= RTE_MAX_ETHPORTS) + if (tmp >= RTE_MAX_ETHPORTS) return; port_id = (portid_t)tmp; @@ -4104,17 +4105,17 @@ cmd_vlan_offload_parsed(void *parsed_result, if (!strcmp(res->what, "strip")) rx_vlan_strip_set(port_id, on); - else if(!strcmp(res->what, "stripq")){ + else if (!strcmp(res->what, "stripq")) { uint16_t queue_id = 0; /* No queue_id, return */ - if(i + 1 >= len) { + if (i + 1 >= len) { fprintf(stderr, "must specify (port,queue_id)\n"); return; } tmp = strtoul(str + i + 1, NULL, 0); /* If queue_id greater that what 16-bits can represent, return */ - if(tmp > 0xffff) + if (tmp > 0xffff) return; queue_id = (uint16_t)tmp; @@ -7252,7 +7253,7 @@ static void cmd_mac_addr_parsed(void *parsed_result, ret = rte_eth_dev_mac_addr_remove(res->port_num, &res->address); /* check the return value and print it if is < 0 */ - if(ret < 0) + if (ret < 0) fprintf(stderr, "mac_addr_cmd error: (%s)\n", strerror(-ret)); } @@ -7825,7 +7826,7 @@ static void cmd_vf_mac_addr_parsed(void *parsed_result, res->vf_num); #endif - if(ret < 0) + if (ret < 0) fprintf(stderr, "vf_mac_addr_cmd error: (%s)\n", strerror(-ret)); } diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index d597c209ba5e..1e619db64891 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -306,13 +306,14 @@ parse_portnuma_config(const char *q_arg) char *str_fld[_NUM_FLD]; /* reset from value set at definition */ - while ((p = strchr(p0,'(')) != NULL) { + while ((p = strchr(p0, '(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -368,11 +369,12 @@ parse_ringnuma_config(const char *q_arg) /* reset from value set at definition */ while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 134d79a55547..c38e8fecc50a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2408,7 +2408,7 @@ start_packet_forwarding(int with_tx_first) test_done = 0; - if(!no_flush_rx) + if (!no_flush_rx) flush_fwd_rx_queues(); rxtx_config_display(); -- 2.39.0