From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
David Hunt <david.hunt@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [PATCH v3 5/7] examples: fix whitespace
Date: Mon, 16 Jan 2023 16:14:51 -0800 [thread overview]
Message-ID: <20230117001453.94082-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20230117001453.94082-1-stephen@networkplumber.org>
The style standard is to use blank after keywords.
I.e "if (" not "if("
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
examples/ip_reassembly/main.c | 2 +-
examples/l3fwd-power/main.c | 9 +++++----
examples/l3fwd/main.c | 9 +++++----
examples/multi_process/symmetric_mp/main.c | 6 +++---
examples/qos_sched/app_thread.c | 6 +++---
examples/qos_sched/args.c | 2 +-
examples/qos_sched/init.c | 2 +-
examples/qos_sched/main.c | 2 +-
8 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
index bd0b1d31decf..7e84b4944759 100644
--- a/examples/ip_reassembly/main.c
+++ b/examples/ip_reassembly/main.c
@@ -300,7 +300,7 @@ send_single_packet(struct rte_mbuf *m, uint16_t port)
TX_LCORE_STAT_UPDATE(&qconf->tx_stat, queue, 1);
txmb->m_table[txmb->head] = m;
- if(++txmb->head == len)
+ if (++txmb->head == len)
txmb->head = 0;
return 0;
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index fd3ade330f82..513a1b21a69e 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1785,13 +1785,14 @@ parse_config(const char *q_arg)
nb_lcore_params = 0;
- while ((p = strchr(p0,'(')) != NULL) {
+ while ((p = strchr(p0, '(')) != NULL) {
++p;
- if((p0 = strchr(p,')')) == NULL)
+ p0 = strchr(p, ')');
+ if (p0 == NULL)
return -1;
size = p0 - p;
- if(size >= sizeof(s))
+ if (size >= sizeof(s))
return -1;
snprintf(s, sizeof(s), "%.*s", size, p);
@@ -2946,7 +2947,7 @@ main(int argc, char **argv)
fflush(stdout);
/* init RX queues */
- for(queue = 0; queue < qconf->n_rx_queue; ++queue) {
+ for (queue = 0; queue < qconf->n_rx_queue; ++queue) {
struct rte_eth_rxconf rxq_conf;
portid = qconf->rx_queue_list[queue].port_id;
diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 5198ff30dd00..687a81892aad 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -514,13 +514,14 @@ parse_config(const char *q_arg)
nb_lcore_params = 0;
- while ((p = strchr(p0,'(')) != NULL) {
+ while ((p = strchr(p0, '(')) != NULL) {
++p;
- if((p0 = strchr(p,')')) == NULL)
+ p0 = strchr(p, ')');
+ if (p0 == NULL)
return -1;
size = p0 - p;
- if(size >= sizeof(s))
+ if (size >= sizeof(s))
return -1;
snprintf(s, sizeof(s), "%.*s", size, p);
@@ -1366,7 +1367,7 @@ l3fwd_poll_resource_setup(void)
printf("\nInitializing rx queues on lcore %u ... ", lcore_id );
fflush(stdout);
/* init RX queues */
- for(queue = 0; queue < qconf->n_rx_queue; ++queue) {
+ for (queue = 0; queue < qconf->n_rx_queue; ++queue) {
struct rte_eth_rxconf rxq_conf;
portid = qconf->rx_queue_list[queue].port_id;
diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index 1ff85875dfdf..9c5348bd36ed 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -156,7 +156,7 @@ smp_parse_args(int argc, char **argv)
/* get the port numbers from the port mask */
RTE_ETH_FOREACH_DEV(i)
- if(port_mask & (1 << i))
+ if (port_mask & (1 << i))
ports[num_ports++] = (uint8_t)i;
ret = optind-1;
@@ -470,8 +470,8 @@ main(int argc, char **argv)
/* Primary instance initialized. 8< */
if (num_ports & 1)
rte_exit(EXIT_FAILURE, "Application must use an even number of ports\n");
- for(i = 0; i < num_ports; i++){
- if(proc_type == RTE_PROC_PRIMARY)
+ for (i = 0; i < num_ports; i++){
+ if (proc_type == RTE_PROC_PRIMARY)
if (smp_port_init(ports[i], mp, (uint16_t)num_procs) < 0)
rte_exit(EXIT_FAILURE, "Error initialising ports\n");
}
diff --git a/examples/qos_sched/app_thread.c b/examples/qos_sched/app_thread.c
index dbc878b55394..a49356fecf5f 100644
--- a/examples/qos_sched/app_thread.c
+++ b/examples/qos_sched/app_thread.c
@@ -79,7 +79,7 @@ app_rx_thread(struct thread_conf **confs)
if (likely(nb_rx != 0)) {
APP_STATS_ADD(conf->stat.nb_rx, nb_rx);
- for(i = 0; i < nb_rx; i++) {
+ for (i = 0; i < nb_rx; i++) {
get_pkt_sched(rx_mbufs[i],
&subport, &pipe, &traffic_class, &queue, &color);
rte_sched_port_pkt_write(conf->sched_port,
@@ -91,7 +91,7 @@ app_rx_thread(struct thread_conf **confs)
if (unlikely(rte_ring_sp_enqueue_bulk(conf->rx_ring,
(void **)rx_mbufs, nb_rx, NULL) == 0)) {
- for(i = 0; i < nb_rx; i++) {
+ for (i = 0; i < nb_rx; i++) {
rte_pktmbuf_free(rx_mbufs[i]);
APP_STATS_ADD(conf->stat.nb_drop, 1);
@@ -137,7 +137,7 @@ app_send_packets(struct thread_conf *qconf, struct rte_mbuf **mbufs, uint32_t nb
uint32_t i, len;
len = qconf->n_mbufs;
- for(i = 0; i < nb_pkt; i++) {
+ for (i = 0; i < nb_pkt; i++) {
qconf->m_table[len] = mbufs[i];
len++;
/* enough pkts to be sent */
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index b2959499ae9a..b752eb221f7c 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -451,7 +451,7 @@ app_parse_args(int argc, char **argv)
/* sanity check for cores assignment */
nb_lcores = app_cpu_core_count();
- for(i = 0; i < nb_pfc; i++) {
+ for (i = 0; i < nb_pfc; i++) {
if (qos_conf[i].rx_core >= nb_lcores) {
RTE_LOG(ERR, APP, "pfc %u: invalid RX lcore index %u\n", i + 1,
qos_conf[i].rx_core);
diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
index 0709aec10c31..41b46b296298 100644
--- a/examples/qos_sched/init.c
+++ b/examples/qos_sched/init.c
@@ -323,7 +323,7 @@ int app_init(void)
rte_exit(EXIT_FAILURE, "Invalid configuration profile\n");
/* Initialize each active flow */
- for(i = 0; i < nb_pfc; i++) {
+ for (i = 0; i < nb_pfc; i++) {
uint32_t socket = rte_lcore_to_socket_id(qos_conf[i].rx_core);
struct rte_ring *ring;
diff --git a/examples/qos_sched/main.c b/examples/qos_sched/main.c
index dc6a17a6464a..366f9125268c 100644
--- a/examples/qos_sched/main.c
+++ b/examples/qos_sched/main.c
@@ -152,7 +152,7 @@ app_stat(void)
static struct rte_eth_stats tx_stats[MAX_DATA_STREAMS];
/* print statistics */
- for(i = 0; i < nb_pfc; i++) {
+ for (i = 0; i < nb_pfc; i++) {
struct flow_conf *flow = &qos_conf[i];
rte_eth_stats_get(flow->rx_port, &stats);
--
2.39.0
next prev parent reply other threads:[~2023-01-17 0:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 17:27 [PATCH 0/7] space after keyword cleanups Stephen Hemminger
2023-01-16 17:27 ` [PATCH 1/7] test: fix whitespace Stephen Hemminger
2023-01-16 17:27 ` [PATCH 2/7] testpmd: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 3/7] net/e1000: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 4/7] i40e: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 5/7] examples: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 6/7] cmdline: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 7/7] ip_frag: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 0/7] space after keyword cleanups Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 1/7] test: fix whitespace Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 2/7] testpmd: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 3/7] net/e1000: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 4/7] i40e: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 5/7] examples: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 6/7] cmdline: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 7/7] ip_frag: " Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 0/7] add space after keywords Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 1/7] test: fix whitespace Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 2/7] testpmd: " Stephen Hemminger
2023-01-31 8:21 ` Singh, Aman Deep
2023-01-17 0:14 ` [PATCH v3 3/7] net/e1000: " Stephen Hemminger
2023-01-17 1:21 ` Wu, Wenjun1
2023-01-17 1:26 ` Su, Simei
2023-01-17 0:14 ` [PATCH v3 4/7] i40e: " Stephen Hemminger
2023-01-17 0:26 ` Xing, Beilei
2023-01-17 0:14 ` Stephen Hemminger [this message]
2023-01-17 0:14 ` [PATCH v3 6/7] cmdline: " Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 7/7] ip_frag: " Stephen Hemminger
2023-01-22 16:00 ` Konstantin Ananyev
2023-03-12 11:28 ` [PATCH v3 0/7] add space after keywords Thomas Monjalon
2023-03-14 18:06 ` Stephen Hemminger
2023-03-14 18:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117001453.94082-6-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).