From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19F464241C; Thu, 19 Jan 2023 20:42:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2CA740223; Thu, 19 Jan 2023 20:42:06 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 3274F400D5 for ; Thu, 19 Jan 2023 20:42:06 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id a14-20020a17090a70ce00b00229a2f73c56so6852842pjm.3 for ; Thu, 19 Jan 2023 11:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=f5GAaq1usDGoM8QbidQ6I/Ko1yXAGUDX4hzU8pjAlzI=; b=nBaY2tLuvYDL9wUhi/rPyeeO1nIfmL2zghbl5e/og5LMSUXd0VotYl/iMR1QR8j1N9 x9m8vW7s+lWWMYHJ1mgkWTA5e9rAVAkUH/t3Xi6ZDV96/jroAzRSjCpCpLKNnEmmJDXW nd2rP7yFvIBbPIAFfdhf2MFgRP2W2FpDZhaCzbDUpF2G3RuIqz00sxpiyA+ZJw5/ZiNp 5p4SZE4pi5w/IdF5quqph8ImmaJFoqusU8jOXP2WGolbt75GoiCpllJGwYaHsBdEPVji ZsXDdUGDusIHlf4yYKxHIowgIF+aQmV2ZR3Gx2hbs0+22rkZN+X3yN9mrJttBfCpawiE EL7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f5GAaq1usDGoM8QbidQ6I/Ko1yXAGUDX4hzU8pjAlzI=; b=PSByi4Abb/PDUqo3cpb3BK5ykq1UUK7Y6MolyE11xtefG9KxU3xtyw8PCWpXVTMK+U 1KfD47EMiMN8pkfaq6QRoM85aGrxvlLihKf4pYq1Y4/pv8ztf7IOaGMlYgiXXY6DvciD /ZZrBJ2GjUDGRq6uPMcKlbjZ8653q/cloxdBdBs4UvSdo+W7S6ft6oZMvbO4IY5nW8aS mjXfw3w9nkuyuF163K5BOdpDDvVe3mRvF3ZOwg9oGRXPSY/jL7LiGu1+mjptpvvcIOey IEOTjsp6v144NUmjXEkwc7paC6kOLvfESvrOgkXlzM/+380jVBotYoAtRIQMmL2tXQiI mEJw== X-Gm-Message-State: AFqh2krX/WBbHcY+giUDi/Sk4oy31GFNlrbxEVuMou4Oj8uzKIvf5H2h rFeuCXa4O4fL5h+odQtUgNMVMA== X-Google-Smtp-Source: AMrXdXv1vJGllwYTTs2zewjZfkR0qRl+vkbFdvDBlpcTiSYGcQbBlWe4XKz2huGKe1CzCoogbWRscg== X-Received: by 2002:a17:902:f789:b0:192:9550:339a with SMTP id q9-20020a170902f78900b001929550339amr13524063pln.52.1674157325301; Thu, 19 Jan 2023 11:42:05 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id n9-20020a170903110900b00178b6ccc8a0sm25656338plh.51.2023.01.19.11.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 11:42:05 -0800 (PST) Date: Thu, 19 Jan 2023 11:42:02 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, maxime.coquelin@redhat.com, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com, Anatoly Burakov , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , David Christensen , Bruce Richardson , Konstantin Ananyev Subject: Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock Message-ID: <20230119114202.27f7da80@hermes.local> In-Reply-To: <20230119184620.3195267-2-david.marchand@redhat.com> References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> <20230119184620.3195267-2-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 19 Jan 2023 19:46:12 +0100 David Marchand wrote: > +#ifndef __DOXYGEN__ > + __rte_exclusive_lock_function(&seqlock->lock) > +#endif > { Would be cleaner any required ifdefs was in rte_lock_annotations rather than sprinkling the code